From 480f969e07c3282c50bc326babbc5812baac5dae Mon Sep 17 00:00:00 2001
From: Mutasem <mutdmour@gmail.com>
Date: Fri, 9 Jul 2021 11:01:46 +0200
Subject: [PATCH] address comments

---
 packages/editor-ui/src/Interface.ts           | 32 +++----------------
 .../editor-ui/src/components/MainSidebar.vue  |  5 +--
 .../editor-ui/src/components/VersionCard.vue  | 15 ++-------
 3 files changed, 10 insertions(+), 42 deletions(-)

diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts
index 81008201a8e..c773d7710a0 100644
--- a/packages/editor-ui/src/Interface.ts
+++ b/packages/editor-ui/src/Interface.ts
@@ -20,6 +20,11 @@ import {
 	WorkflowExecuteMode,
 } from 'n8n-workflow';
 
+import {
+	IN8nUISettings,
+	IVersionNotificationSettings,
+} from 'n8n';
+
 import {
 	PaintStyle,
 } from 'jsplumb';
@@ -445,33 +450,6 @@ export interface IPushDataConsoleMessage {
 	message: string;
 }
 
-export interface IVersionNotificationSettings {
-	enabled: boolean;
-	endpoint: string;
-	infoUrl: string;
-}
-
-export interface IN8nUISettings {
-	endpointWebhook: string;
-	endpointWebhookTest: string;
-	saveDataErrorExecution: string;
-	saveDataSuccessExecution: string;
-	saveManualExecutions: boolean;
-	timezone: string;
-	executionTimeout: number;
-	maxExecutionTimeout: number;
-	oauthCallbackUrls: {
-		oauth1: string;
-		oauth2: string;
-	};
-	urlBaseWebhook: string;
-	versionCli: string;
-	n8nMetadata?: {
-		[key: string]: string | number | undefined;
-	};
-	versionNotifications: IVersionNotificationSettings;
-}
-
 export interface IWorkflowSettings extends IWorkflowSettingsWorkflow {
 	errorWorkflow?: string;
 	saveDataErrorExecution?: string;
diff --git a/packages/editor-ui/src/components/MainSidebar.vue b/packages/editor-ui/src/components/MainSidebar.vue
index 720086ff8d4..59be0386b13 100644
--- a/packages/editor-ui/src/components/MainSidebar.vue
+++ b/packages/editor-ui/src/components/MainSidebar.vue
@@ -127,7 +127,7 @@
 
 				<MenuItemsIterator :items="sidebarMenuBottomItems" :root="true"/>
 
-				<div class="foot-menu-items">
+				<div class="footer-menu-items">
 					<el-menu-item index="updates" class="updates" v-if="hasVersionUpdates" @click="openUpdatesPanel">
 						<div class="gift-container">
 							<div class="gift-icon">
@@ -597,11 +597,12 @@ a.logo {
 	}
 }
 
-.foot-menu-items {
+.footer-menu-items {
 	display: flex;
 	flex-grow: 1;
 	flex-direction: column;
 	justify-content: flex-end;
+	padding-bottom: 32px;
 }
 
 .el-menu-item.updates {
diff --git a/packages/editor-ui/src/components/VersionCard.vue b/packages/editor-ui/src/components/VersionCard.vue
index 27717e948ba..26d18d483c2 100644
--- a/packages/editor-ui/src/components/VersionCard.vue
+++ b/packages/editor-ui/src/components/VersionCard.vue
@@ -27,7 +27,7 @@
 		</div>
 		<div>
 			<div v-html="version.description" :class="$style.description"></div>
-			<div :class="`${$style.nodes} ${hasMoreThan2Rows ? $style.expanded: ''}`" v-if="version.nodes && version.nodes.length > 0">
+			<div :class="$style.nodes" v-if="version.nodes && version.nodes.length > 0">
 				<NodeIcon 
 					v-for="node in version.nodes"
 					:key="node.name"
@@ -41,7 +41,6 @@
 <script lang="ts">
 import Vue from 'vue';
 import NodeIcon from './NodeIcon.vue';
-import { IVersion } from '@/Interface';
 import TimeAgo from './TimeAgo.vue';
 import Badge from './Badge.vue';
 import WarningTooltip from './WarningTooltip.vue';
@@ -51,12 +50,6 @@ export default Vue.extend({
 	components: { NodeIcon, TimeAgo, Badge, WarningTooltip },
 	name: 'UpdatesPanel',
 	props: ['version'],
-	computed: {
-		hasMoreThan2Rows(): boolean {
-			const version = this.version as IVersion;
-			return version.nodes && version.nodes.length > 20;
-		},
-	},
 });
 </script>
 
@@ -119,11 +112,7 @@ export default Vue.extend({
 	.nodes {
 		display: grid;
 		grid-template-columns: repeat(10, 1fr);
-		grid-row-gap: 5px;
+		grid-row-gap: 12px;
 		margin-block-start: 24px;
 	}
-
-	.expanded {
-		grid-row-gap: 8px;
-	}
 </style>