github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-07-28 03:24:59 +02:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity Graph

fix(core): Narrow mcp apps frame domains (no-changelog) (#33123)

Browse Source
This commit is contained in:
Milorad FIlipović 2026-06-30 15:30:10 +02:00 committed by GitHub
parent c4e0bf310f
commit 44d5faeb7d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/@n8n/mcp-apps/README.md
View File

@ -85,11 +85,13 @@ URL handling is locked down by `isAllowedWorkflowUrl` in
host are accepted, both when reading the tool result and right before calling
`openLink`. This is defense in depth on top of the host's own validation.
The workflow preview iframe uses a server-provided `previewUrl` when available.
Otherwise it uses the existing n8n preview service because instance routes are
commonly blocked or unreachable from MCP hosts. The resource metadata declares
broad `frameDomains` for `http` and `https` so hosts that enforce MCP Apps CSP
can load instance-specific or configured preview URLs. The framed n8n server's
The workflow preview iframe loads the shared n8n preview service
(`WORKFLOW_PREVIEW_ORIGIN`). The preview is instance-agnostic: the workflow
graph is pushed into the iframe via `postMessage` rather than fetched from the
instance, so a single origin renders both cloud and self-hosted workflows. The
resource metadata therefore declares exactly one `frameDomains` entry — the
preview-service origin. Keep this list narrow: MCP hosts (e.g. the ChatGPT
connector review) reject broad or wildcard frame domains. The framed server's
own frame policy still applies, so the app falls back to the open-workflow
button when the preview cannot load.

12
packages/@n8n/mcp-apps/src/server/constants.ts
View File

@ -3,9 +3,9 @@ export const RESOURCE_URI_META_KEY = 'ui/resourceUri';
export const WORKFLOW_PREVIEW_APP_URI = 'ui://workflow-preview/workflow-preview.html';
export const WORKFLOW_PREVIEW_ORIGIN = 'https://n8n-preview-service.internal.n8n.cloud';
export const WORKFLOW_PREVIEW_FRAME_DOMAINS = [
WORKFLOW_PREVIEW_ORIGIN,
'https://*',
'http://localhost:*',
'http://127.0.0.1:*',
] as const;
// Scoped to the single preview-service origin (CSP `frame-src`). The preview is
// instance-agnostic: workflow data is pushed into the iframe via postMessage, so
// the same origin renders cloud and self-hosted workflows without needing the
// instance origin framed. Keep this narrow — MCP hosts reject broad/wildcard
// frame domains.
export const WORKFLOW_PREVIEW_FRAME_DOMAINS = [WORKFLOW_PREVIEW_ORIGIN] as const;