From 37d11ff71feb6328faf65c9a665ac3cb0b9e4339 Mon Sep 17 00:00:00 2001
From: Mutasem <mutdmour@gmail.com>
Date: Fri, 2 Jul 2021 14:05:47 +0200
Subject: [PATCH] fix bug when no updates

---
 packages/editor-ui/src/components/Modal.vue | 2 +-
 packages/editor-ui/src/modules/ui.ts        | 3 +++
 packages/editor-ui/src/views/NodeView.vue   | 4 +++-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/packages/editor-ui/src/components/Modal.vue b/packages/editor-ui/src/components/Modal.vue
index bb58de009c0..072473209a3 100644
--- a/packages/editor-ui/src/components/Modal.vue
+++ b/packages/editor-ui/src/components/Modal.vue
@@ -4,7 +4,7 @@
 			v-if="drawer"
 			:direction="drawerDirection"
 			:before-close="closeDialog"
-			:visible="dialogVisible"
+			:visible="true"
 			:size="drawerWidth"
 			>
 			<template v-slot:title>
diff --git a/packages/editor-ui/src/modules/ui.ts b/packages/editor-ui/src/modules/ui.ts
index c93cbe75eb6..88a236b84e7 100644
--- a/packages/editor-ui/src/modules/ui.ts
+++ b/packages/editor-ui/src/modules/ui.ts
@@ -28,6 +28,9 @@ const module: Module<IUiState, IRootState> = {
 		isPageLoading: true,
 	},
 	getters: {
+		isVersionsOpen: (state: IUiState) => {
+			return state.modals[VERSIONS_MODAL_KEY].open;
+		},
 		isModalOpen: (state: IUiState) => {
 			return (name: string) => state.modals[name].open;
 		},
diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue
index f024913cbac..4380a30492a 100644
--- a/packages/editor-ui/src/views/NodeView.vue
+++ b/packages/editor-ui/src/views/NodeView.vue
@@ -2239,12 +2239,14 @@ export default mixins(
 				setTimeout(async () => {
 					await this.$store.dispatch('versions/fetchVersions');
 					const currentVersion: IVersion | undefined = this.$store.getters['versions/currentVersion'];
-					if (currentVersion && currentVersion.hasSecurityIssue) {
+					const nextVersions: IVersion[] = this.$store.getters['versions/nextVersions'];
+					if (currentVersion && currentVersion.hasSecurityIssue && nextVersions.length) {
 						const fixVersion = currentVersion.securityIssueFixVersion;
 						let message = `Please update to latest version.`;
 						if (fixVersion) {
 							message = `Please update to version ${fixVersion} or higher.`;
 						}
+
 						message = `${message}<br/><a class="primary-color">More info</a>`;
 						this.$showWarning('Critical Update', message, {
 							onClick: () => {