diff --git a/cypress/e2e/group1/20-workflow-executions.cy.ts b/cypress/e2e/group1/20-workflow-executions.cy.ts index f3527eda0ef..3dff64ebf31 100644 --- a/cypress/e2e/group1/20-workflow-executions.cy.ts +++ b/cypress/e2e/group1/20-workflow-executions.cy.ts @@ -100,7 +100,8 @@ describe('Workflow Executions', () => { .should('be.visible'); }); - it('should show workflow data in executions tab after hard reload and modify name and tags', () => { + // eslint-disable-next-line n8n-local-rules/no-skipped-tests + it.skip('should show workflow data in executions tab after hard reload and modify name and tags', () => { executionsTab.actions.switchToExecutionsTab(); checkMainHeaderELements(); workflowPage.getters.saveButton().find('button').should('not.exist'); diff --git a/cypress/e2e/group2/26-resource-locator.cy.ts b/cypress/e2e/group2/26-resource-locator.cy.ts deleted file mode 100644 index fc117e15c9b..00000000000 --- a/cypress/e2e/group2/26-resource-locator.cy.ts +++ /dev/null @@ -1,107 +0,0 @@ -import { WorkflowPage, NDV, CredentialsModal } from '../../pages'; -import { getVisiblePopper } from '../../utils'; - -const workflowPage = new WorkflowPage(); -const ndv = new NDV(); -const credentialsModal = new CredentialsModal(); - -const NO_CREDENTIALS_MESSAGE = 'Add your credential'; -const INVALID_CREDENTIALS_MESSAGE = 'Check your credential'; -const MODE_SELECTOR_LIST = 'From list'; - -describe('Resource Locator', () => { - beforeEach(() => { - workflowPage.actions.visit(); - }); - - it('should render both RLC components in google sheets', () => { - workflowPage.actions.addInitialNodeToCanvas('Manual'); - workflowPage.actions.addNodeToCanvas('Google Sheets', true, true, 'Update row in sheet'); - ndv.getters.resourceLocator('documentId').should('be.visible'); - ndv.getters.resourceLocator('sheetName').should('be.visible'); - ndv.getters - .resourceLocatorModeSelector('documentId') - .find('input') - .should('have.value', MODE_SELECTOR_LIST); - ndv.getters - .resourceLocatorModeSelector('sheetName') - .find('input') - .should('have.value', MODE_SELECTOR_LIST); - }); - - it('should show appropriate error when credentials are not set', () => { - workflowPage.actions.addInitialNodeToCanvas('Manual'); - workflowPage.actions.addNodeToCanvas('Google Sheets', true, true, 'Update row in sheet'); - ndv.getters.resourceLocator('documentId').should('be.visible'); - ndv.getters.resourceLocatorInput('documentId').click(); - ndv.getters.resourceLocatorErrorMessage().should('contain', NO_CREDENTIALS_MESSAGE); - }); - - it('should show create credentials modal when clicking "add your credential"', () => { - workflowPage.actions.addInitialNodeToCanvas('Manual'); - workflowPage.actions.addNodeToCanvas('Google Sheets', true, true, 'Update row in sheet'); - ndv.getters.resourceLocator('documentId').should('be.visible'); - ndv.getters.resourceLocatorInput('documentId').click(); - ndv.getters.resourceLocatorErrorMessage().should('contain', NO_CREDENTIALS_MESSAGE); - ndv.getters.resourceLocatorAddCredentials().click(); - credentialsModal.getters.credentialsEditModal().should('be.visible'); - }); - - it('should show appropriate error when credentials are not valid', () => { - workflowPage.actions.addInitialNodeToCanvas('Manual'); - workflowPage.actions.addNodeToCanvas('Google Sheets', true, true, 'Update row in sheet'); - - // Add oAuth credentials - workflowPage.getters.nodeCredentialsSelect().click(); - workflowPage.getters.nodeCredentialsCreateOption().click(); - credentialsModal.getters.credentialsEditModal().should('be.visible'); - credentialsModal.getters.credentialAuthTypeRadioButtons().should('have.length', 2); - credentialsModal.getters.credentialAuthTypeRadioButtons().first().click(); - credentialsModal.actions.fillCredentialsForm(); - cy.get('.el-message-box').find('button').contains('Close').click(); - - ndv.getters.resourceLocatorInput('documentId').click(); - ndv.getters.resourceLocatorErrorMessage().should('contain', INVALID_CREDENTIALS_MESSAGE); - }); - - it('should show appropriate errors when search filter is required', () => { - workflowPage.actions.addNodeToCanvas('Github', true, true, 'On pull request'); - ndv.getters.resourceLocator('owner').should('be.visible'); - ndv.getters.resourceLocatorInput('owner').click(); - ndv.getters.resourceLocatorErrorMessage().should('contain', NO_CREDENTIALS_MESSAGE); - }); - - it('should reset resource locator when dependent field is changed', () => { - workflowPage.actions.addInitialNodeToCanvas('Manual'); - workflowPage.actions.addNodeToCanvas('Google Sheets', true, true, 'Update row in sheet'); - ndv.actions.setRLCValue('documentId', '123'); - ndv.actions.setRLCValue('sheetName', '123'); - ndv.actions.setRLCValue('documentId', '321'); - ndv.getters.resourceLocatorInput('sheetName').should('have.value', ''); - }); - - // unlike RMC and remote options, RLC does not support loadOptionDependsOn - it('should retrieve list options when other params throw errors', () => { - workflowPage.actions.addInitialNodeToCanvas('E2e Test', { action: 'Resource Locator' }); - - ndv.getters.resourceLocatorInput('rlc').click(); - - cy.getByTestId('rlc-item').should('exist'); - getVisiblePopper() - .should('have.length', 1) - .findChildByTestId('rlc-item') - .should('have.length', 5); - - ndv.actions.setInvalidExpression({ fieldName: 'fieldId' }); - - ndv.getters.inputPanel().click(); // remove focus from input, hide expression preview - - ndv.getters.resourceLocatorInput('rlc').click(); - - cy.getByTestId('rlc-item').should('exist'); - getVisiblePopper() - .should('have.length', 1) - .findChildByTestId('rlc-item') - .should('have.length', 5); - }); -}); diff --git a/packages/testing/playwright/tests/ui/11-inline-expression-editor.spec.ts b/packages/testing/playwright/tests/ui/11-inline-expression-editor.spec.ts index 34189357da5..c8508455181 100644 --- a/packages/testing/playwright/tests/ui/11-inline-expression-editor.spec.ts +++ b/packages/testing/playwright/tests/ui/11-inline-expression-editor.spec.ts @@ -31,7 +31,8 @@ test.describe('Inline expression editor', () => { await expect(n8n.ndv.getInlineExpressionEditorOutput()).toBeHidden(); }); - test('should switch between expression and fixed using keyboard', async ({ n8n }) => { + // NODE-3721 + test.skip('should switch between expression and fixed using keyboard', async ({ n8n }) => { await n8n.canvas.addNode(EDIT_FIELDS_SET_NODE_NAME); // Should switch to expression with = diff --git a/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts b/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts index f4f34ec0919..7701430f22b 100644 --- a/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts +++ b/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts @@ -107,7 +107,8 @@ test.describe('Resource Locator', () => { }); // unlike RMC and remote options, RLC does not support loadOptionDependsOn - test('should retrieve list options when other params throw errors', async ({ n8n }) => { + // NODE-3720 + test.skip('should retrieve list options when other params throw errors', async ({ n8n }) => { await n8n.canvas.addNode(E2E_TEST_NODE_NAME, { closeNDV: false, action: 'Resource Locator' }); await n8n.ndv.getResourceLocatorInput('rlc').click();