From 25033dfaed7dfed3ba0b017a7436bb85d4eab9be Mon Sep 17 00:00:00 2001 From: RomanDavydchuk Date: Fri, 3 Oct 2025 18:53:57 +0300 Subject: [PATCH] fix: Flaky E2E test for the RLC (no-changelog) (#20366) --- packages/testing/playwright/pages/NodeDetailsViewPage.ts | 2 +- .../testing/playwright/tests/ui/26-resource-locator.spec.ts | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/testing/playwright/pages/NodeDetailsViewPage.ts b/packages/testing/playwright/pages/NodeDetailsViewPage.ts index 71a7c739089..99538af6b23 100644 --- a/packages/testing/playwright/pages/NodeDetailsViewPage.ts +++ b/packages/testing/playwright/pages/NodeDetailsViewPage.ts @@ -1013,7 +1013,7 @@ export class NodeDetailsViewPage extends BasePage { await this.activateParameterExpressionEditor(fieldName); const editor = this.getInlineExpressionEditorInput(fieldName); await editor.click(); - await this.page.keyboard.type(invalidExpression ?? '{{ invalid_expression'); + await this.page.keyboard.type(invalidExpression ?? '{{ =()'); } /** diff --git a/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts b/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts index 7701430f22b..e8f044a32b6 100644 --- a/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts +++ b/packages/testing/playwright/tests/ui/26-resource-locator.spec.ts @@ -107,8 +107,7 @@ test.describe('Resource Locator', () => { }); // unlike RMC and remote options, RLC does not support loadOptionDependsOn - // NODE-3720 - test.skip('should retrieve list options when other params throw errors', async ({ n8n }) => { + test('should retrieve list options when other params throw errors', async ({ n8n }) => { await n8n.canvas.addNode(E2E_TEST_NODE_NAME, { closeNDV: false, action: 'Resource Locator' }); await n8n.ndv.getResourceLocatorInput('rlc').click(); @@ -122,6 +121,9 @@ test.describe('Resource Locator', () => { await n8n.ndv.getInputPanel().click(); // remove focus from input, hide expression preview + // wait for the expression to be evaluated and show the error + await expect(n8n.ndv.getParameterInputHint()).toContainText('ERROR'); + await n8n.ndv.getResourceLocatorInput('rlc').click(); await expect(n8n.page.getByTestId('rlc-item').first()).toBeVisible();