From 1b6891cd0f97c2156b5765623f4ce11fa14bf7b5 Mon Sep 17 00:00:00 2001 From: Declan Carroll Date: Thu, 20 Nov 2025 17:14:40 +0000 Subject: [PATCH] test: Fixing flaky tests (#22108) --- .../testing/playwright/tests/ui/12-canvas.spec.ts | 11 +++++++++-- .../tests/ui/inject-previous-execution.spec.ts | 10 ---------- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/packages/testing/playwright/tests/ui/12-canvas.spec.ts b/packages/testing/playwright/tests/ui/12-canvas.spec.ts index 5ad64e22f85..c05d89a8f1e 100644 --- a/packages/testing/playwright/tests/ui/12-canvas.spec.ts +++ b/packages/testing/playwright/tests/ui/12-canvas.spec.ts @@ -100,12 +100,19 @@ test.describe('Canvas Node Manipulation and Navigation', () => { await n8n.canvas.clickZoomToFitButton(); await n8n.canvas.connectNodesByDrag(MANUAL_TRIGGER_NODE_DISPLAY_NAME, 'Edit Fields1', 0, 0); + await expect( + n8n.canvas.connectionBetweenNodes(MANUAL_TRIGGER_NODE_DISPLAY_NAME, 'Edit Fields1').first(), + ).toBeAttached(); await n8n.canvas.connectNodesByDrag('Edit Fields', MERGE_NODE_NAME, 0, 0); + await expect( + n8n.canvas.connectionBetweenNodes('Edit Fields', MERGE_NODE_NAME).first(), + ).toBeAttached(); await n8n.canvas.connectNodesByDrag('Edit Fields1', MERGE_NODE_NAME, 0, 1); - - await checkConnections(); + await expect( + n8n.canvas.connectionBetweenNodes('Edit Fields1', MERGE_NODE_NAME).first(), + ).toBeAttached(); await n8n.canvas.saveWorkflow(); await expect(n8n.canvas.getWorkflowSaveButton()).toContainText('Saved'); diff --git a/packages/testing/playwright/tests/ui/inject-previous-execution.spec.ts b/packages/testing/playwright/tests/ui/inject-previous-execution.spec.ts index f6fadb792b6..365180b0670 100644 --- a/packages/testing/playwright/tests/ui/inject-previous-execution.spec.ts +++ b/packages/testing/playwright/tests/ui/inject-previous-execution.spec.ts @@ -14,11 +14,6 @@ test.describe('Inject previous execution', () => { await n8n.canvas.clickZoomToFitButton(); await n8n.canvas.clickExecuteWorkflowButton(); - await expect(n8n.canvas.getExecuteWorkflowButtonSpinner()).toBeVisible(); - await expect(n8n.canvas.clearExecutionDataButton()).toBeHidden(); - await expect(n8n.canvas.stopExecutionButton()).toBeVisible(); - await expect(n8n.canvas.stopExecutionWaitingForWebhookButton()).toBeHidden(); - await n8n.notifications.waitForNotificationAndClose( NOTIFICATIONS.WORKFLOW_EXECUTED_SUCCESSFULLY, ); @@ -49,11 +44,6 @@ test.describe('Inject previous execution', () => { await n8n.canvas.clickZoomToFitButton(); await n8n.canvas.clickExecuteWorkflowButton(); - await expect(n8n.canvas.getExecuteWorkflowButtonSpinner()).toBeVisible(); - await expect(n8n.canvas.clearExecutionDataButton()).toBeHidden(); - await expect(n8n.canvas.stopExecutionButton()).toBeVisible(); - await expect(n8n.canvas.stopExecutionWaitingForWebhookButton()).toBeHidden(); - await n8n.notifications.waitForNotificationAndClose( NOTIFICATIONS.WORKFLOW_EXECUTED_SUCCESSFULLY, );