From 17635d0eaa65c408aa1af8ed2cbb3ed523fb6e13 Mon Sep 17 00:00:00 2001 From: Alex Grozav Date: Tue, 14 Oct 2025 11:04:38 +0300 Subject: [PATCH] refactor(editor): Extract `apiKeys` code into features (no-changelog) (#20648) --- packages/frontend/editor-ui/src/components/Modals.vue | 4 ++-- packages/frontend/editor-ui/src/constants.ts | 1 - .../editor-ui/src/features/apiKeys/apiKeys.constants.ts | 1 + .../src/{stores => features/apiKeys}/apiKeys.store.ts | 0 .../src/{ => features/apiKeys}/components/ApiKeyCard.vue | 0 .../apiKeys}/components/ApiKeyCreateOrEditModal.test.ts | 4 ++-- .../apiKeys}/components/ApiKeyCreateOrEditModal.vue | 7 ++++--- .../src/{ => features/apiKeys}/components/ApiKeyScopes.vue | 0 .../{ => features/apiKeys}/views/SettingsApiView.test.ts | 2 +- .../src/{ => features/apiKeys}/views/SettingsApiView.vue | 7 ++++--- packages/frontend/editor-ui/src/router.ts | 2 +- packages/frontend/editor-ui/src/stores/ui.store.ts | 2 +- 12 files changed, 16 insertions(+), 14 deletions(-) create mode 100644 packages/frontend/editor-ui/src/features/apiKeys/apiKeys.constants.ts rename packages/frontend/editor-ui/src/{stores => features/apiKeys}/apiKeys.store.ts (100%) rename packages/frontend/editor-ui/src/{ => features/apiKeys}/components/ApiKeyCard.vue (100%) rename packages/frontend/editor-ui/src/{ => features/apiKeys}/components/ApiKeyCreateOrEditModal.test.ts (98%) rename packages/frontend/editor-ui/src/{ => features/apiKeys}/components/ApiKeyCreateOrEditModal.vue (97%) rename packages/frontend/editor-ui/src/{ => features/apiKeys}/components/ApiKeyScopes.vue (100%) rename packages/frontend/editor-ui/src/{ => features/apiKeys}/views/SettingsApiView.test.ts (99%) rename packages/frontend/editor-ui/src/{ => features/apiKeys}/views/SettingsApiView.vue (96%) diff --git a/packages/frontend/editor-ui/src/components/Modals.vue b/packages/frontend/editor-ui/src/components/Modals.vue index a868202f30a..7f62d526f9d 100644 --- a/packages/frontend/editor-ui/src/components/Modals.vue +++ b/packages/frontend/editor-ui/src/components/Modals.vue @@ -2,7 +2,6 @@ import { ABOUT_MODAL_KEY, ANNOTATION_TAGS_MANAGER_MODAL_KEY, - API_KEY_CREATE_OR_EDIT_MODAL_KEY, CHANGE_PASSWORD_MODAL_KEY, CHAT_EMBED_MODAL_KEY, COMMUNITY_PACKAGE_CONFIRM_MODAL_KEY, @@ -51,9 +50,10 @@ import { SOURCE_CONTROL_PULL_MODAL_KEY, SOURCE_CONTROL_PUSH_MODAL_KEY, } from '@/features/sourceControl.ee/sourceControl.constants'; +import { API_KEY_CREATE_OR_EDIT_MODAL_KEY } from '@/features/apiKeys/apiKeys.constants'; import AboutModal from '@/components/AboutModal.vue'; import ActivationModal from '@/components/ActivationModal.vue'; -import ApiKeyCreateOrEditModal from '@/components/ApiKeyCreateOrEditModal.vue'; +import ApiKeyCreateOrEditModal from '@/features/apiKeys/components/ApiKeyCreateOrEditModal.vue'; import NewAssistantSessionModal from '@/features/assistant/components/Chat/NewAssistantSessionModal.vue'; import ChangePasswordModal from '@/features/auth/components/ChangePasswordModal.vue'; import ConfirmPasswordModal from '@/features/auth/components/ConfirmPasswordModal.vue'; diff --git a/packages/frontend/editor-ui/src/constants.ts b/packages/frontend/editor-ui/src/constants.ts index 30a89a325fd..c7271f9a2a8 100644 --- a/packages/frontend/editor-ui/src/constants.ts +++ b/packages/frontend/editor-ui/src/constants.ts @@ -52,7 +52,6 @@ export const CHAT_EMBED_MODAL_KEY = 'chatEmbed'; export const CHANGE_PASSWORD_MODAL_KEY = 'changePassword'; export const CONFIRM_PASSWORD_MODAL_KEY = 'confirmPassword'; export const CREDENTIAL_EDIT_MODAL_KEY = 'editCredential'; -export const API_KEY_CREATE_OR_EDIT_MODAL_KEY = 'createOrEditApiKey'; export const CREDENTIAL_SELECT_MODAL_KEY = 'selectCredential'; export const DELETE_USER_MODAL_KEY = 'deleteUser'; export const INVITE_USER_MODAL_KEY = 'inviteUser'; diff --git a/packages/frontend/editor-ui/src/features/apiKeys/apiKeys.constants.ts b/packages/frontend/editor-ui/src/features/apiKeys/apiKeys.constants.ts new file mode 100644 index 00000000000..8857078b463 --- /dev/null +++ b/packages/frontend/editor-ui/src/features/apiKeys/apiKeys.constants.ts @@ -0,0 +1 @@ +export const API_KEY_CREATE_OR_EDIT_MODAL_KEY = 'createOrEditApiKey'; diff --git a/packages/frontend/editor-ui/src/stores/apiKeys.store.ts b/packages/frontend/editor-ui/src/features/apiKeys/apiKeys.store.ts similarity index 100% rename from packages/frontend/editor-ui/src/stores/apiKeys.store.ts rename to packages/frontend/editor-ui/src/features/apiKeys/apiKeys.store.ts diff --git a/packages/frontend/editor-ui/src/components/ApiKeyCard.vue b/packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCard.vue similarity index 100% rename from packages/frontend/editor-ui/src/components/ApiKeyCard.vue rename to packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCard.vue diff --git a/packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.test.ts b/packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCreateOrEditModal.test.ts similarity index 98% rename from packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.test.ts rename to packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCreateOrEditModal.test.ts index 2ff859ea307..3821058888c 100644 --- a/packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.test.ts +++ b/packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCreateOrEditModal.test.ts @@ -1,12 +1,12 @@ import { createComponentRenderer } from '@/__tests__/render'; import { createTestingPinia } from '@pinia/testing'; -import { API_KEY_CREATE_OR_EDIT_MODAL_KEY } from '@/constants'; +import { API_KEY_CREATE_OR_EDIT_MODAL_KEY } from '../apiKeys.constants'; import { STORES } from '@n8n/stores'; import { mockedStore, retry } from '@/__tests__/utils'; import ApiKeyEditModal from './ApiKeyCreateOrEditModal.vue'; import userEvent from '@testing-library/user-event'; -import { useApiKeysStore } from '@/stores/apiKeys.store'; +import { useApiKeysStore } from '../apiKeys.store'; import { DateTime } from 'luxon'; import type { ApiKeyWithRawValue } from '@n8n/api-types'; import { useSettingsStore } from '@/stores/settings.store'; diff --git a/packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.vue b/packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCreateOrEditModal.vue similarity index 97% rename from packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.vue rename to packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCreateOrEditModal.vue index bc9606583a1..94cdb233b98 100644 --- a/packages/frontend/editor-ui/src/components/ApiKeyCreateOrEditModal.vue +++ b/packages/frontend/editor-ui/src/features/apiKeys/components/ApiKeyCreateOrEditModal.vue @@ -1,15 +1,16 @@