github-mirror/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-05-30 08:17:06 +02:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity Graph

fix(editor): Disallow drag-and-drop for non-immediate-ancestors of Python code node (#20773)

Browse Source
This commit is contained in:
Iván Ovejero 2025-10-15 09:45:03 +02:00 committed by GitHub
parent 86af6e95c2
commit 0fab5ea3d3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
packages/frontend/editor-ui/src/features/editors/components/CodeNodeEditor/utils.test.ts
View File

@ -123,6 +123,36 @@ const y = f({ a: 'c' })
valueToInsert('{{ $json.foo.bar[0].baz }}', 'pythonNative', 'runOnceForEachItem'),
).toBe('{{ _item["json"]["foo"]["bar"][0]["baz"] }}');
});
it('should return empty string for specific node references (single quotes), runOnceForAllItems', () => {
expect(
valueToInsert(
"{{ $('Some Previous Node').item.json.foo.bar[0].baz }}",
'pythonNative',
'runOnceForAllItems',
),
).toBe('');
});
it('should return empty string for specific node references (double quotes), runOnceForAllItems', () => {
expect(
valueToInsert(
'{{ $("Some Previous Node").item.json.foo.bar[0].baz }}',
'pythonNative',
'runOnceForAllItems',
),
).toBe('');
});
it('should return empty string for specific node references, runOnceForEachItem', () => {
expect(
valueToInsert(
"{{ $('Some Previous Node').item.json.foo.bar[0].baz }}",
'pythonNative',
'runOnceForEachItem',
),
).toBe('');
});
});
});
});

3
packages/frontend/editor-ui/src/features/editors/components/CodeNodeEditor/utils.ts
View File

@ -67,6 +67,9 @@ const toBracketNotation = (input: string): string => {
};
const pythonInsert = (value: string, mode: CodeExecutionMode): string => {
// Python supports only direct parent node references
if (value.includes('$(')) return '';
const base =
mode === 'runOnceForAllItems'
? value.replace('$json', '_items[0]["json"]')