From 075b035d64d462e84e35c2e3b73afee0fca592b8 Mon Sep 17 00:00:00 2001 From: Guillaume Jacquart Date: Mon, 26 May 2025 13:42:53 +0200 Subject: [PATCH] fix(editor): Fix update panel icon display. Fix title on insights dashboard (#15593) --- .../frontend/editor-ui/src/components/UpdatesPanel.vue | 1 + .../features/insights/components/InsightsDashboard.test.ts | 1 + .../src/features/insights/components/InsightsDashboard.vue | 7 ++++++- .../frontend/editor-ui/src/plugins/i18n/locales/en.json | 1 + 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/frontend/editor-ui/src/components/UpdatesPanel.vue b/packages/frontend/editor-ui/src/components/UpdatesPanel.vue index bf7c0af6109..7e62924b580 100644 --- a/packages/frontend/editor-ui/src/components/UpdatesPanel.vue +++ b/packages/frontend/editor-ui/src/components/UpdatesPanel.vue @@ -106,6 +106,7 @@ const i18n = useI18n(); .link { padding-left: 0px; + display: flex; } .link:hover { diff --git a/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.test.ts b/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.test.ts index 855643d9eb4..60b097a09b9 100644 --- a/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.test.ts +++ b/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.test.ts @@ -21,6 +21,7 @@ describe('InsightsDashboard', () => { it('should render without error', () => { mockedStore(useInsightsStore); expect(() => renderComponent()).not.toThrow(); + expect(document.title).toBe('Insights - n8n'); }); it('should update the selected time range', async () => { diff --git a/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.vue b/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.vue index 09c344a9680..980662184cb 100644 --- a/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.vue +++ b/packages/frontend/editor-ui/src/features/insights/components/InsightsDashboard.vue @@ -4,10 +4,11 @@ import { useTelemetry } from '@/composables/useTelemetry'; import InsightsSummary from '@/features/insights/components/InsightsSummary.vue'; import { useInsightsStore } from '@/features/insights/insights.store'; import type { InsightsDateRange, InsightsSummaryType } from '@n8n/api-types'; -import { computed, defineAsyncComponent, ref, watch } from 'vue'; +import { computed, defineAsyncComponent, onMounted, ref, watch } from 'vue'; import { TELEMETRY_TIME_RANGE, UNLICENSED_TIME_RANGE } from '../insights.constants'; import InsightsDateRangeSelect from './InsightsDateRangeSelect.vue'; import InsightsUpgradeModal from './InsightsUpgradeModal.vue'; +import { useDocumentTitle } from '@/composables/useDocumentTitle'; const InsightsPaywall = defineAsyncComponent( async () => await import('@/features/insights/components/InsightsPaywall.vue'), @@ -116,6 +117,10 @@ watch( immediate: true, }, ); + +onMounted(() => { + useDocumentTitle().set(i18n.baseText('insights.heading')); +});