Jan Kara 619f75dae2 ext4: fix warning in ext4_dio_write_end_io() ... The syzbot has reported that it can hit the warning in ext4_dio_write_end_io() because i_size < i_disksize. Indeed the reproducer creates a race between DIO IO completion and truncate expanding the file and thus ext4_dio_write_end_io() sees an inconsistent inode state where i_disksize is already updated but i_size is not updated yet. Since we are careful when setting up DIO write and consider it extending (and thus performing the IO synchronously with i_rwsem held exclusively) whenever it goes past either of i_size or i_disksize, we can use the same test during IO completion without risking entering ext4_handle_inode_extension() without i_rwsem held. This way we make it obvious both i_size and i_disksize are large enough when we report DIO completion without relying on unreliable WARN_ON. Reported-by: <syzbot+47479b71cdfc78f56d30@syzkaller.appspotmail.com> Fixes: 91562895f8 ("ext4: properly sync file size update after O_SYNC direct IO") Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> Link: https://lore.kernel.org/r/20231130095653.22679-1-jack@suse.cz Signed-off-by: Theodore Ts'o <tytso@mit.edu>		2023-11-30 23:29:34 -05:00
..
.kunitconfig
acl.c
acl.h	ext4: apply umask if ACL support is disabled	2023-10-05 22:32:15 -04:00
balloc.c	ext4: add some kunit stub for mballoc kunit test	2023-10-05 22:32:16 -04:00
bitmap.c
block_validity.c
crypto.c
dir.c
ext4_extents.h
ext4_jbd2.c
ext4_jbd2.h
ext4.h	Many singleton patches against the MM code. The patch series which are	2023-11-02 19:38:47 -10:00
extents_status.c	Many singleton patches against the MM code. The patch series which are	2023-11-02 19:38:47 -10:00
extents_status.h
extents.c	Cleanup ext4's multi-block allocator, including adding some unit	2023-11-02 07:45:14 -10:00
fast_commit.c	ext4: make state in ext4_mb_mark_bb to be bool	2023-10-05 22:32:15 -04:00
fast_commit.h
file.c	ext4: fix warning in ext4_dio_write_end_io()	2023-11-30 23:29:34 -05:00
fsmap.c	ext4: Convert to bdev_open_by_dev()	2023-10-28 13:29:20 +02:00
fsmap.h
fsync.c
hash.c
ialloc.c	ext4: convert to new timestamp accessors	2023-10-18 13:26:21 +02:00
indirect.c
inline.c	ext4: convert to new timestamp accessors	2023-10-18 13:26:21 +02:00
inode-test.c
inode.c	Many singleton patches against the MM code. The patch series which are	2023-11-02 19:38:47 -10:00
ioctl.c	ext4: convert to new timestamp accessors	2023-10-18 13:26:21 +02:00
Kconfig
Makefile
mballoc-test.c	ext4: run mballoc test with different layouts setting	2023-10-05 22:32:16 -04:00
mballoc.c	ext4: prevent the normalized size from exceeding EXT_MAX_BLOCKS	2023-11-30 21:57:38 -05:00
mballoc.h
migrate.c
mmp.c
move_extent.c	buffer: remove folio_create_empty_buffers()	2023-10-25 16:47:10 -07:00
namei.c	Cleanup ext4's multi-block allocator, including adding some unit	2023-11-02 07:45:14 -10:00
orphan.c
page-io.c
readpage.c	ext4: use folio_end_read()	2023-10-18 14:34:16 -07:00
resize.c	ext4: remove unnecessary initialization of count2 in set_flexbg_block_bitmap	2023-10-05 22:32:15 -04:00
super.c	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
symlink.c
sysfs.c
truncate.h
verity.c
xattr_hurd.c
xattr_security.c
xattr_trusted.c
xattr_user.c
xattr.c	vfs-6.7.ctime	2023-10-30 09:47:13 -10:00
xattr.h	ext4: move ext4_xattr_handlers to .rodata	2023-10-09 16:24:16 +02:00