Matteo Croce ffab47bf69 mvpp2: fix panic on module removal ... [ Upstream commit 944a83a266 ] mvpp2 uses a delayed workqueue to gather traffic statistics. On module removal the workqueue can be destroyed before calling cancel_delayed_work_sync() on its works. Fix it by moving the destroy_workqueue() call after mvpp2_port_remove(). Also remove an unneeded call to flush_workqueue() # rmmod mvpp2 [ 2743.311722] mvpp2 f4000000.ethernet eth1: phy link down 10gbase-kr/10Gbps/Full [ 2743.320063] mvpp2 f4000000.ethernet eth1: Link is Down [ 2743.572263] mvpp2 f4000000.ethernet eth2: phy link down sgmii/1Gbps/Full [ 2743.580076] mvpp2 f4000000.ethernet eth2: Link is Down [ 2744.102169] mvpp2 f2000000.ethernet eth0: phy link down 10gbase-kr/10Gbps/Full [ 2744.110441] mvpp2 f2000000.ethernet eth0: Link is Down [ 2744.115614] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 2744.115615] Mem abort info: [ 2744.115616] ESR = 0x96000005 [ 2744.115617] Exception class = DABT (current EL), IL = 32 bits [ 2744.115618] SET = 0, FnV = 0 [ 2744.115619] EA = 0, S1PTW = 0 [ 2744.115620] Data abort info: [ 2744.115621] ISV = 0, ISS = 0x00000005 [ 2744.115622] CM = 0, WnR = 0 [ 2744.115624] user pgtable: 4k pages, 39-bit VAs, pgdp=0000000422681000 [ 2744.115626] [0000000000000000] pgd=0000000000000000, pud=0000000000000000 [ 2744.115630] Internal error: Oops: 96000005 [#1] SMP [ 2744.115632] Modules linked in: mvpp2(-) algif_hash af_alg nls_iso8859_1 nls_cp437 vfat fat xhci_plat_hcd m25p80 spi_nor xhci_hcd mtd usbcore i2c_mv64xxx sfp usb_common marvell10g phy_generic spi_orion mdio_i2c i2c_core mvmdio phylink sbsa_gwdt ip_tables x_tables autofs4 [last unloaded: mvpp2] [ 2744.115654] CPU: 3 PID: 8357 Comm: kworker/3:2 Not tainted 5.3.0-rc2 #1 [ 2744.115655] Hardware name: Marvell 8040 MACCHIATOBin Double-shot (DT) [ 2744.115665] Workqueue: events_power_efficient phylink_resolve [phylink] [ 2744.115669] pstate: a0000085 (NzCv daIf -PAN -UAO) [ 2744.115675] pc : __queue_work+0x9c/0x4d8 [ 2744.115677] lr : __queue_work+0x170/0x4d8 [ 2744.115678] sp : ffffff801001bd50 [ 2744.115680] x29: ffffff801001bd50 x28: ffffffc422597600 [ 2744.115684] x27: ffffff80109ae6f0 x26: ffffff80108e4018 [ 2744.115688] x25: 0000000000000003 x24: 0000000000000004 [ 2744.115691] x23: ffffff80109ae6e0 x22: 0000000000000017 [ 2744.115694] x21: ffffffc42c030000 x20: ffffffc42209e8f8 [ 2744.115697] x19: 0000000000000000 x18: 0000000000000000 [ 2744.115699] x17: 0000000000000000 x16: 0000000000000000 [ 2744.115701] x15: 0000000000000010 x14: ffffffffffffffff [ 2744.115702] x13: ffffff8090e2b95f x12: ffffff8010e2b967 [ 2744.115704] x11: ffffff8010906000 x10: 0000000000000040 [ 2744.115706] x9 : ffffff80109223b8 x8 : ffffff80109223b0 [ 2744.115707] x7 : ffffffc42bc00068 x6 : 0000000000000000 [ 2744.115709] x5 : ffffffc42bc00000 x4 : 0000000000000000 [ 2744.115710] x3 : 0000000000000000 x2 : 0000000000000000 [ 2744.115712] x1 : 0000000000000008 x0 : ffffffc42c030000 [ 2744.115714] Call trace: [ 2744.115716] __queue_work+0x9c/0x4d8 [ 2744.115718] delayed_work_timer_fn+0x28/0x38 [ 2744.115722] call_timer_fn+0x3c/0x180 [ 2744.115723] expire_timers+0x60/0x168 [ 2744.115724] run_timer_softirq+0xbc/0x1e8 [ 2744.115727] __do_softirq+0x128/0x320 [ 2744.115731] irq_exit+0xa4/0xc0 [ 2744.115734] __handle_domain_irq+0x70/0xc0 [ 2744.115735] gic_handle_irq+0x58/0xa8 [ 2744.115737] el1_irq+0xb8/0x140 [ 2744.115738] console_unlock+0x3a0/0x568 [ 2744.115740] vprintk_emit+0x200/0x2a0 [ 2744.115744] dev_vprintk_emit+0x1c8/0x1e4 [ 2744.115747] dev_printk_emit+0x6c/0x7c [ 2744.115751] __netdev_printk+0x104/0x1d8 [ 2744.115752] netdev_printk+0x60/0x70 [ 2744.115756] phylink_resolve+0x38c/0x3c8 [phylink] [ 2744.115758] process_one_work+0x1f8/0x448 [ 2744.115760] worker_thread+0x54/0x500 [ 2744.115762] kthread+0x12c/0x130 [ 2744.115764] ret_from_fork+0x10/0x1c [ 2744.115768] Code: aa1403e0 97fffbbe aa0003f5 b4000700 (f9400261) Fixes: 118d6298f6 ("net: mvpp2: add ethtool GOP statistics") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Matteo Croce <mcroce@redhat.com> Acked-by: Antoine Tenart <antoine.tenart@bootlin.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-08-09 17:52:30 +02:00
..
accessibility
acpi	ACPI: blacklist: fix clang warning for unused DMI table	2019-08-06 19:06:50 +02:00
amba
android	binder: fix possible UAF when freeing buffer	2019-08-04 09:30:53 +02:00
ata	libata: don't request sense data on !ZAC ATA devices	2019-07-26 09:14:12 +02:00
atm	atm: iphase: Fix Spectre v1 vulnerability	2019-08-09 17:52:29 +02:00
auxdisplay	auxdisplay: hd44780: Fix memory leak on ->remove()	2019-04-20 09:15:55 +02:00
base	drivers/base: Introduce kill_device()	2019-08-09 17:52:28 +02:00
bcma
block	nbd: replace kill_bdev() with __invalidate_device() again	2019-08-06 19:06:55 +02:00
bluetooth	Bluetooth: hci_uart: check for missing tty operations	2019-08-04 09:30:55 +02:00
bus
cdrom	cdrom: Fix race condition in cdrom_sysctl_register	2019-04-05 22:33:10 +02:00
char	hpet: Fix division by zero in hpet_time_div()	2019-07-31 07:27:10 +02:00
clk	clk: sprd: Add check for return value of sprd_clk_regmap_init()	2019-08-06 19:06:49 +02:00
clocksource	clocksource/drivers/exynos_mct: Increase priority over ARM arch timer	2019-07-26 09:14:12 +02:00
connector	connector: fix unsafe usage of ->real_parent	2019-03-19 13:12:38 +01:00
cpufreq	cpufreq: kirkwood: fix possible object reference leak	2019-05-31 06:46:24 -07:00
cpuidle
crypto	crypto: caam - limit output IV to CBC to work around CTR mode DMA issue	2019-07-26 09:14:29 +02:00
dax	mm/huge_memory: fix vmf_insert_pfn_{pmd, pud}() crash, handle unaligned addresses	2019-05-22 07:37:40 +02:00
dca
devfreq
dio
dma	dmaengine: rcar-dmac: Reject zero-length slave DMA requests	2019-08-06 19:06:48 +02:00
dma-buf	dma-buf: Discard old fence_excl on retrying get_fences_rcu for realloc	2019-07-28 08:29:28 +02:00
edac	EDAC: Fix global-out-of-bounds write when setting edac_mc_poll_msec	2019-07-26 09:14:13 +02:00
eisa
extcon	extcon: arizona: Disable mic detect if running when driver is removed	2019-05-31 06:46:23 -07:00
firewire
firmware	firmware/psci: psci_checker: Park kthreads before stopping them	2019-08-06 19:06:48 +02:00
fmc
fpga	fpga-manager: altera-ps-spi: Fix build error	2019-07-31 07:27:10 +02:00
fsi
gnss	gnss: sirf: fix premature wakeup interrupt enable	2019-03-10 07:17:21 +01:00
gpio	gpiolib: fix incorrect IRQ requesting of an active-low lineevent	2019-08-06 19:06:54 +02:00
gpu	drm/i915/gvt: fix incorrect cache entry for guest page mapping	2019-08-06 19:06:56 +02:00
hid	HID: Add quirk for HP X1200 PIXART OEM mouse	2019-08-09 17:52:29 +02:00
hsi
hv	Drivers: hv: vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()	2019-05-10 17:54:04 +02:00
hwmon	hwmon: (pmbus/core) Treat parameters as paged if on multiple pages	2019-06-25 11:35:59 +08:00
hwspinlock
hwtracing	intel_th: msu: Fix single mode with disabled IOMMU	2019-07-26 09:14:30 +02:00
i2c	gcc-9: don't warn about uninitialized variable	2019-08-09 17:52:27 +02:00
ide
idle	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
iio	iio: adc: stm32-dfsdm: missing error case during probe	2019-07-31 07:26:56 +02:00
infiniband	IB: directly cast the sockaddr union to aockaddr	2019-08-09 17:52:29 +02:00
input	Input: alps - fix a mismatch between a condition check and its comment	2019-07-26 09:14:22 +02:00
iommu	iommu/vt-d: Don't queue_iova() if there is no flush queue	2019-08-04 09:30:54 +02:00
ipack
irqchip	irqchip/meson-gpio: Add support for Meson-G12A SoC	2019-07-26 09:14:06 +02:00
isdn	ISDN: hfcsusb: checking idx of ep configuration	2019-08-04 09:30:53 +02:00
leds	leds: trigger: netdev: use memcpy in device_name_store	2019-05-04 09:20:22 +02:00
lightnvm	lightnvm: pblk: fix freeing of merged pages	2019-07-26 09:14:09 +02:00
macintosh
mailbox	mailbox: handle failed named mailbox channel request	2019-07-31 07:27:07 +02:00
mcb
md	dm bufio: fix deadlock with loop device	2019-07-26 09:14:31 +02:00
media	media: radio-raremono: change devm_k*alloc to k*alloc	2019-08-04 09:30:54 +02:00
memory	memory: tegra: Fix integer overflow on tick value calculation	2019-05-25 18:23:32 +02:00
memstick	memstick: Fix error cleanup path of memstick_init	2019-07-31 07:26:59 +02:00
message
mfd	mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk	2019-07-31 07:27:03 +02:00
misc	eeprom: at24: make spd world-readable again	2019-08-06 19:06:57 +02:00
mmc	mmc: meson-mx-sdio: Fix misuse of GENMASK macro	2019-08-06 19:06:54 +02:00
mtd	mtd: rawnand: micron: handle on-die "ECC-off" devices correctly	2019-08-06 19:06:54 +02:00
mux
net	mvpp2: fix panic on module removal	2019-08-09 17:52:30 +02:00
nfc	spi: ST ST95HF NFC: declare missing of table	2019-05-16 19:41:25 +02:00
ntb
nubus
nvdimm	libnvdimm/bus: Fix wait_nvdimm_bus_probe_idle() ABBA deadlock	2019-08-09 17:52:28 +02:00
nvme	nvme-pci: set the errno on ctrl state change error	2019-07-26 09:14:09 +02:00
nvmem	nvmem: sunxi_sid: Support SID on A83T and H5	2019-06-15 11:54:07 +02:00
of	of: overlay: set node fields from properties when add new overlay node	2019-06-09 09:17:24 +02:00
opp
oprofile
parisc	parisc: Use implicit space register selection for loading the coherence index of I/O pdirs	2019-06-11 12:20:51 +02:00
parport	parport: Fix mem leak in parport_register_dev_model	2019-06-25 11:35:55 +08:00
pci	PCI: dwc: pci-dra7xx: Fix compilation when !CONFIG_GPIOLIB	2019-07-31 07:27:07 +02:00
pcmcia
perf	drivers/perf: arm_pmu: Fix failure path in PM notifier	2019-08-06 19:06:55 +02:00
phy	phy: renesas: rcar-gen2: Fix memory leak at error paths	2019-07-31 07:27:00 +02:00
pinctrl	pinctrl: rockchip: fix leaked of_node references	2019-07-31 07:26:57 +02:00
platform	platform/mellanox: mlxreg-hotplug: Add devm_free_irq call to remove flow	2019-07-10 09:53:38 +02:00
pnp
power	power: supply: max14656: fix potential use-before-alloc	2019-06-15 11:54:09 +02:00
powercap	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
pps	drivers/pps/pps.c: clear offset flags in PPS_SETPARAMS ioctl	2019-08-04 09:30:56 +02:00
ps3
ptp
pwm	pwm: Fix deadlock warning when removing PWM device	2019-06-15 11:54:10 +02:00
rapidio	drivers/rapidio/devices/rio_mport_cdev.c: NUL terminate some strings	2019-08-06 19:06:52 +02:00
ras	RAS/CEC: Fix pfn insertion	2019-07-26 09:14:05 +02:00
regulator	regulator: s2mps11: Fix buck7 and buck8 wrong voltages	2019-07-26 09:14:22 +02:00
remoteproc
reset	reset: meson-audio-arb: Fix missing .owner setting of reset_controller_dev	2019-05-08 07:21:47 +02:00
rpmsg
rtc	rtc: pcf8523: don't return invalid date when battery is low	2019-06-19 08:18:07 +02:00
s390	s390/dasd: fix endless loop after read unit address configuration	2019-08-06 19:06:55 +02:00
sbus
scsi	scsi: fcoe: Embed fc_rport_priv in fcoe_rport structure	2019-08-09 17:52:27 +02:00
sfi
sh
siox
slimbus	slimbus: fix a potential NULL pointer dereference in of_qcom_slim_ngd_register	2019-05-31 06:46:14 -07:00
sn
soc	soc: bcm: brcmstb: biuctrl: Register writes require a barrier	2019-07-14 08:11:03 +02:00
soundwire	soundwire: intel: set dai min and max channels correctly	2019-07-14 08:11:07 +02:00
spi	spi: bitbang: Fix NULL pointer dereference in spi_unregister_master	2019-07-10 09:53:32 +02:00
spmi
ssb	ssb: Fix possible NULL pointer dereference in ssb_host_pcmcia_exit	2019-05-31 06:46:04 -07:00
staging	staging: vt6656: use meaningful error code during buffer allocation	2019-07-31 07:26:57 +02:00
target	scsi: iscsi: set auth_protocol back to NULL if CHAP_A value is not supported	2019-07-26 09:13:56 +02:00
tc
tee
thermal	drivers: thermal: tsens: Don't print error message on -EPROBE_DEFER	2019-06-15 11:54:02 +02:00
thunderbolt	thunderbolt: property: Fix a NULL pointer dereference	2019-05-31 06:46:31 -07:00
tty	serial: sh-sci: Fix TX DMA buffer flushing and workqueue races	2019-07-31 07:27:04 +02:00
uio
usb	usb: dwc2: Fix disable all EP's on disconnect	2019-08-04 09:30:52 +02:00
uwb
vfio	vfio: Fix WARNING "do not call blocking ops when !TASK_RUNNING"	2019-06-15 11:54:07 +02:00
vhost	vhost: scsi: add weight support	2019-08-04 09:30:55 +02:00
video	video: imsttfb: fix potential NULL pointer dereferences	2019-06-15 11:54:10 +02:00
virt	drivers/virt/fsl_hypervisor.c: prevent integer overflow in ioctl	2019-05-16 19:41:31 +02:00
virtio	virtio_pci: fix a NULL pointer reference in vp_del_vqs	2019-05-10 17:54:08 +02:00
visorbus
vlynq
vme
w1	w1: fix the resume command API	2019-05-31 06:46:14 -07:00
watchdog	watchdog: fix compile time error of pretimeout governors	2019-06-15 11:54:06 +02:00
xen	xen/swiotlb: fix condition for calling xen_destroy_contiguous_region()	2019-08-06 19:06:55 +02:00
zorro
Kconfig
Makefile