linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-05 21:15:53 +02:00

Linux kernel source tree

Go to file

Qiang Ma fed034d23e net: stmmac: ethtool: Fixed calltrace caused by unbalanced disable_irq_wake calls [ Upstream commit `a23aa04042` ] We found the following dmesg calltrace when testing the GMAC NIC notebook: [9.448656] ------------[ cut here ]------------ [9.448658] Unbalanced IRQ 43 wake disable [9.448673] WARNING: CPU: 3 PID: 1083 at kernel/irq/manage.c:688 irq_set_irq_wake+0xe0/0x128 [9.448717] CPU: 3 PID: 1083 Comm: ethtool Tainted: G O 4.19 #1 [9.448773] ... [9.448774] Call Trace: [9.448781] [<9000000000209b5c>] show_stack+0x34/0x140 [9.448788] [<9000000000d52700>] dump_stack+0x98/0xd0 [9.448794] [<9000000000228610>] __warn+0xa8/0x120 [9.448797] [<9000000000d2fb60>] report_bug+0x98/0x130 [9.448800] [<900000000020a418>] do_bp+0x248/0x2f0 [9.448805] [<90000000002035f4>] handle_bp_int+0x4c/0x78 [9.448808] [<900000000029ea40>] irq_set_irq_wake+0xe0/0x128 [9.448813] [<9000000000a96a7c>] stmmac_set_wol+0x134/0x150 [9.448819] [<9000000000be6ed0>] dev_ethtool+0x1368/0x2440 [9.448824] [<9000000000c08350>] dev_ioctl+0x1f8/0x3e0 [9.448827] [<9000000000bb2a34>] sock_ioctl+0x2a4/0x450 [9.448832] [<900000000046f044>] do_vfs_ioctl+0xa4/0x738 [9.448834] [<900000000046f778>] ksys_ioctl+0xa0/0xe8 [9.448837] [<900000000046f7d8>] sys_ioctl+0x18/0x28 [9.448840] [<9000000000211ab4>] syscall_common+0x20/0x34 [9.448842] ---[ end trace 40c18d9aec863c3e ]--- Multiple disable_irq_wake() calls will keep decreasing the IRQ wake_depth, When wake_depth is 0, calling disable_irq_wake() again, will report the above calltrace. Due to the need to appear in pairs, we cannot call disable_irq_wake() without calling enable_irq_wake(). Fix this by making sure there are no unbalanced disable_irq_wake() calls. Fixes: `3172d3afa9` ("stmmac: support wake up irq from external sources (v3)") Signed-off-by: Qiang Ma <maqianga@uniontech.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20240112021249.24598-1-maqianga@uniontech.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-01-25 15:35:58 -08:00
arch	s390/pci: fix max size calculation in zpci_memcpy_toio()	2024-01-25 15:35:56 -08:00
block	block: ensure we hold a queue reference when using queue limits	2024-01-25 15:35:57 -08:00
certs	certs: Reference revocation list for all keyrings	2023-08-17 20:12:41 +00:00
crypto	crypto: scomp - fix req->dst buffer overflow	2024-01-25 15:35:18 -08:00
Documentation	dt-bindings: gpio: xilinx: Fix node address in gpio	2024-01-25 15:35:58 -08:00
drivers	net: stmmac: ethtool: Fixed calltrace caused by unbalanced disable_irq_wake calls	2024-01-25 15:35:58 -08:00
fs	erofs: fix inconsistent per-file compression format	2024-01-25 15:35:57 -08:00
include	net: netdev_queue: netdev_txq_completed_mb(): fix wake condition	2024-01-25 15:35:57 -08:00
init	rootfs: Fix support for rootfstype= when root= is given	2024-01-25 15:35:46 -08:00
io_uring	io_uring: ensure local task_work is run on wait timeout	2024-01-25 15:35:45 -08:00
ipc	Add x86 shadow stack support	2023-08-31 12:20:12 -07:00
kernel	bpf: Fix re-attachment branch in bpf_tracing_prog_attach	2024-01-25 15:35:46 -08:00
lib	kunit: debugfs: Fix unchecked dereference in debugfs_print_results()	2024-01-25 15:35:15 -08:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	mm/memory_hotplug: fix memmap_on_memory sysfs value retrieval	2024-01-20 11:51:49 +01:00
net	net: tls, fix WARNIING in __sk_msg_free	2024-01-25 15:35:58 -08:00
rust	rust: Ignore preserve-most functions	2024-01-25 15:35:41 -08:00
samples	vfio/mtty: Overhaul mtty interrupt handling	2024-01-10 17:16:55 +01:00
scripts	scripts/decode_stacktrace.sh: optionally use LLVM utilities	2024-01-20 11:51:49 +01:00
security	apparmor: avoid crash when parsed profile name is empty	2024-01-25 15:35:54 -08:00
sound	ASoC: SOF: ipc4-loader: remove the CPC check warnings	2024-01-25 15:35:58 -08:00
tools	selftests: bonding: Change script interpreter	2024-01-25 15:35:58 -08:00
usr	initramfs: Encode dependency on KBUILD_BUILD_TIMESTAMP	2023-06-06 17:54:49 +09:00
virt	ARM:	2023-09-07 13:52:20 -07:00
.clang-format	iommu: Add for_each_group_device()	2023-05-23 08:15:51 +02:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: set diff driver for Rust source code files	2023-05-31 17:48:25 +02:00
.gitignore	kbuild: rpm-pkg: rename binkernel.spec to kernel.spec	2023-07-25 00:59:33 +09:00
.mailmap	20 hotfixes. 12 are cc:stable and the remainder address post-6.5 issues	2023-10-24 09:52:16 -10:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	USB: Remove Wireless USB and UWB documentation	2023-08-09 14:17:32 +02:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	Char/Misc driver fixes for 6.6-final	2023-10-28 07:51:27 -10:00
Makefile	Linux 6.6.13	2024-01-20 11:51:49 +01:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.