Hoang Le 4d1d3dddcb tipc: fix NULL deref in tipc_link_xmit() ... [ Upstream commit b774134464 ] The buffer list can have zero skb as following path: tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so we need to check the list before casting an &sk_buff. Fault report: [] tipc: Bulk publication failure [] general protection fault, probably for non-canonical [#1] PREEMPT [...] [] KASAN: null-ptr-deref in range [0x00000000000000c8-0x00000000000000cf] [] CPU: 0 PID: 0 Comm: swapper/0 Kdump: loaded Not tainted 5.10.0-rc4+ #2 [] Hardware name: Bochs ..., BIOS Bochs 01/01/2011 [] RIP: 0010:tipc_link_xmit+0xc1/0x2180 [] Code: 24 b8 00 00 00 00 4d 39 ec 4c 0f 44 e8 e8 d7 0a 10 f9 48 [...] [] RSP: 0018:ffffc90000006ea0 EFLAGS: 00010202 [] RAX: dffffc0000000000 RBX: ffff8880224da000 RCX: 1ffff11003d3cc0d [] RDX: 0000000000000019 RSI: ffffffff886007b9 RDI: 00000000000000c8 [] RBP: ffffc90000007018 R08: 0000000000000001 R09: fffff52000000ded [] R10: 0000000000000003 R11: fffff52000000dec R12: ffffc90000007148 [] R13: 0000000000000000 R14: 0000000000000000 R15: ffffc90000007018 [] FS: 0000000000000000(0000) GS:ffff888037400000(0000) knlGS:000[...] [] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [] CR2: 00007fffd2db5000 CR3: 000000002b08f000 CR4: 00000000000006f0 Fixes: af9b028e27 ("tipc: make media xmit call outside node spinlock context") Acked-by: Jon Maloy <jmaloy@redhat.com> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au> Link: https://lore.kernel.org/r/20210108071337.3598-1-hoang.h.le@dektech.com.au Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-01-23 15:49:56 +01:00
..
addr.c
addr.h
bcast.c	tipc: clean up skb list lock handling on send path	2020-07-29 10:16:47 +02:00
bcast.h
bearer.c
bearer.h
core.c	tipc: fix use-after-free in tipc_bcast_get_mode	2020-11-10 12:35:53 +01:00
core.h
diag.c
discover.c
discover.h
eth_media.c
group.c	tipc: Fix memory leak in tipc_group_create_member()	2020-09-26 18:01:30 +02:00
group.h
ib_media.c
Kconfig
link.c	tipc: fix NULL deref in tipc_link_xmit()	2021-01-23 15:49:56 +01:00
link.h
Makefile
monitor.c	tipc: update mon's self addr when node addr generated	2020-01-27 14:49:52 +01:00
monitor.h	tipc: update mon's self addr when node addr generated	2020-01-27 14:49:52 +01:00
msg.c	tipc: fix memory leak caused by tipc_buf_append()	2020-11-05 11:08:33 +01:00
msg.h
name_distr.c	tipc: eliminate message disordering during binding table update	2020-01-27 14:50:00 +01:00
name_distr.h
name_table.c	tipc: eliminate message disordering during binding table update	2020-01-27 14:50:00 +01:00
name_table.h	tipc: eliminate message disordering during binding table update	2020-01-27 14:50:00 +01:00
net.c	tipc: update mon's self addr when node addr generated	2020-01-27 14:49:52 +01:00
net.h
netlink_compat.c	tipc: fix uninit skb->data in tipc_nl_compat_dumpit()	2020-09-03 11:24:17 +02:00
netlink.c	tipc: add missing attribute validation for MTU property	2020-03-18 07:14:18 +01:00
netlink.h
node.c	tipc: clean up skb list lock handling on send path	2020-07-29 10:16:47 +02:00
node.h
socket.c	tipc: fix shutdown() of connection oriented socket	2020-09-26 18:01:30 +02:00
socket.h
subscr.c
subscr.h
sysctl.c	tipc: set sysctl_tipc_rmem and named_timeout right range	2020-01-27 14:50:39 +01:00
topsrv.c	tipc: fix memory leak in tipc_topsrv_start()	2020-11-18 19:18:51 +01:00
topsrv.h
udp_media.c	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2020-04-29 16:31:17 +02:00
udp_media.h