mirror of
https://github.com/torvalds/linux.git
synced 2026-06-04 04:23:35 +02:00
forwarding.config.sample, net/lib.sh and net/forwarding/lib.sh contain definitions and redefinitions of some of the same variables. The overlap between net/forwarding/lib.sh and forwarding.config.sample is especially large. This duplication is a potential source of confusion and problems. It would be overall less error prone if each variable were defined in one place only. In this patch set, that place is the library itself. Therefore move all comments from forwarding.config.sample to net/forwarding/lib.sh. Move over also a definition of TC_FLAG, which was missing from lib.sh entirely. Additionally, add to lib.sh a default definition of the topology variables. The logic behind this is that forgetting to specify forwarding.config was a frequent source of frustration for the selftest users. But really, most of the time the default veth based topology is just fine. We considered just sourcing forwarding.config.sample instead if forwarding.config is not available, but this is a cleaner solution. That means the syntax of the forwarding.config.sample override has to change to an array assignment, so that the whole variable is overwritten, not just individual keys, which could leave the value of some keys unchanged. Do the same in lib.sh for any cut'n'pasters out there. The config file is then given a sort of carte blanche to redefine whatever variables it sees fit from the libraries. This is described in a comment in the file. Only a handful of variables are left behind, to illustrate the customization. The fact that the variables are now missing from forwarding.config.sample, and therefore would miss from forwarding.config derived from that file as well, should not change anything. This is just the sample file. Users that keep their own forwarding.config would retain it as before. The only observable change is introduction of TC_FLAG to lib.sh, because now the filters would not be attempted to install to HW datapath. For veth pairs this does not change anything. For HW deployments, users presumably have forwarding.config with this value overridden. Signed-off-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Benjamin Poirier <bpoirier@nvidia.com> Link: https://lore.kernel.org/r/b9b8a11a22821a7aa532211ff461a34f596e26bf.1711464583.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| bridge_fdb_learning_limit.sh | ||
| bridge_igmp.sh | ||
| bridge_locked_port.sh | ||
| bridge_mdb_host.sh | ||
| bridge_mdb_max.sh | ||
| bridge_mdb_port_down.sh | ||
| bridge_mdb.sh | ||
| bridge_mld.sh | ||
| bridge_port_isolation.sh | ||
| bridge_sticky_fdb.sh | ||
| bridge_vlan_aware.sh | ||
| bridge_vlan_mcast.sh | ||
| bridge_vlan_unaware.sh | ||
| config | ||
| custom_multipath_hash.sh | ||
| devlink_lib.sh | ||
| dual_vxlan_bridge.sh | ||
| ethtool_extended_state.sh | ||
| ethtool_lib.sh | ||
| ethtool_mm.sh | ||
| ethtool_rmon.sh | ||
| ethtool.sh | ||
| fib_offload_lib.sh | ||
| forwarding.config.sample | ||
| gre_custom_multipath_hash.sh | ||
| gre_inner_v4_multipath.sh | ||
| gre_inner_v6_multipath.sh | ||
| gre_multipath_nh_res.sh | ||
| gre_multipath_nh.sh | ||
| gre_multipath.sh | ||
| hw_stats_l3_gre.sh | ||
| hw_stats_l3.sh | ||
| ip6_forward_instats_vrf.sh | ||
| ip6gre_custom_multipath_hash.sh | ||
| ip6gre_flat_key.sh | ||
| ip6gre_flat_keys.sh | ||
| ip6gre_flat.sh | ||
| ip6gre_hier_key.sh | ||
| ip6gre_hier_keys.sh | ||
| ip6gre_hier.sh | ||
| ip6gre_inner_v4_multipath.sh | ||
| ip6gre_inner_v6_multipath.sh | ||
| ip6gre_lib.sh | ||
| ipip_flat_gre_key.sh | ||
| ipip_flat_gre_keys.sh | ||
| ipip_flat_gre.sh | ||
| ipip_hier_gre_key.sh | ||
| ipip_hier_gre_keys.sh | ||
| ipip_hier_gre.sh | ||
| ipip_lib.sh | ||
| lib.sh | ||
| local_termination.sh | ||
| loopback.sh | ||
| Makefile | ||
| mirror_gre_bound.sh | ||
| mirror_gre_bridge_1d_vlan.sh | ||
| mirror_gre_bridge_1d.sh | ||
| mirror_gre_bridge_1q_lag.sh | ||
| mirror_gre_bridge_1q.sh | ||
| mirror_gre_changes.sh | ||
| mirror_gre_flower.sh | ||
| mirror_gre_lag_lacp.sh | ||
| mirror_gre_lib.sh | ||
| mirror_gre_neigh.sh | ||
| mirror_gre_nh.sh | ||
| mirror_gre_topo_lib.sh | ||
| mirror_gre_vlan_bridge_1q.sh | ||
| mirror_gre_vlan.sh | ||
| mirror_gre.sh | ||
| mirror_lib.sh | ||
| mirror_topo_lib.sh | ||
| mirror_vlan.sh | ||
| no_forwarding.sh | ||
| pedit_dsfield.sh | ||
| pedit_ip.sh | ||
| pedit_l4port.sh | ||
| q_in_vni_ipv6.sh | ||
| q_in_vni.sh | ||
| README | ||
| router_bridge_1d_lag.sh | ||
| router_bridge_1d.sh | ||
| router_bridge_lag.sh | ||
| router_bridge_pvid_vlan_upper.sh | ||
| router_bridge_vlan_upper_pvid.sh | ||
| router_bridge_vlan_upper.sh | ||
| router_bridge_vlan.sh | ||
| router_bridge.sh | ||
| router_broadcast.sh | ||
| router_mpath_nh_lib.sh | ||
| router_mpath_nh_res.sh | ||
| router_mpath_nh.sh | ||
| router_multicast.sh | ||
| router_multipath.sh | ||
| router_nh.sh | ||
| router_vid_1.sh | ||
| router.sh | ||
| sch_ets_core.sh | ||
| sch_ets_tests.sh | ||
| sch_ets.sh | ||
| sch_red.sh | ||
| sch_tbf_core.sh | ||
| sch_tbf_ets.sh | ||
| sch_tbf_etsprio.sh | ||
| sch_tbf_prio.sh | ||
| sch_tbf_root.sh | ||
| settings | ||
| skbedit_priority.sh | ||
| tc_actions.sh | ||
| tc_chains.sh | ||
| tc_common.sh | ||
| tc_flower_cfm.sh | ||
| tc_flower_l2_miss.sh | ||
| tc_flower_port_range.sh | ||
| tc_flower_router.sh | ||
| tc_flower.sh | ||
| tc_mpls_l2vpn.sh | ||
| tc_police.sh | ||
| tc_shblocks.sh | ||
| tc_tunnel_key.sh | ||
| tc_vlan_modify.sh | ||
| tsn_lib.sh | ||
| vxlan_asymmetric_ipv6.sh | ||
| vxlan_asymmetric.sh | ||
| vxlan_bridge_1d_ipv6.sh | ||
| vxlan_bridge_1d_port_8472_ipv6.sh | ||
| vxlan_bridge_1d_port_8472.sh | ||
| vxlan_bridge_1d.sh | ||
| vxlan_bridge_1q_ipv6.sh | ||
| vxlan_bridge_1q_port_8472_ipv6.sh | ||
| vxlan_bridge_1q_port_8472.sh | ||
| vxlan_bridge_1q.sh | ||
| vxlan_symmetric_ipv6.sh | ||
| vxlan_symmetric.sh | ||
Motivation
==========
One of the nice things about network namespaces is that they allow one
to easily create and test complex environments.
Unfortunately, these namespaces can not be used with actual switching
ASICs, as their ports can not be migrated to other network namespaces
(NETIF_F_NETNS_LOCAL) and most of them probably do not support the
L1-separation provided by namespaces.
However, a similar kind of flexibility can be achieved by using VRFs and
by looping the switch ports together. For example:
br0
+
vrf-h1 | vrf-h2
+ +---+----+ +
| | | |
192.0.2.1/24 + + + + 192.0.2.2/24
swp1 swp2 swp3 swp4
+ + + +
| | | |
+--------+ +--------+
The VRFs act as lightweight namespaces representing hosts connected to
the switch.
This approach for testing switch ASICs has several advantages over the
traditional method that requires multiple physical machines, to name a
few:
1. Only the device under test (DUT) is being tested without noise from
other system.
2. Ability to easily provision complex topologies. Testing bridging
between 4-ports LAGs or 8-way ECMP requires many physical links that are
not always available. With the VRF-based approach one merely needs to
loopback more ports.
These tests are written with switch ASICs in mind, but they can be run
on any Linux box using veth pairs to emulate physical loopbacks.
Guidelines for Writing Tests
============================
o Where possible, reuse an existing topology for different tests instead
of recreating the same topology.
o Tests that use anything but the most trivial topologies should include
an ASCII art showing the topology.
o Where possible, IPv6 and IPv4 addresses shall conform to RFC 3849 and
RFC 5737, respectively.
o Where possible, tests shall be written so that they can be reused by
multiple topologies and added to lib.sh.
o Checks shall be added to lib.sh for any external dependencies.
o Code shall be checked using ShellCheck [1] prior to submission.
1. https://www.shellcheck.net/