Vegard Nossum fc9b7c086b net/irda: fix NULL pointer dereference on memory allocation failure ... [ Upstream commit d3e6952cfb ] I ran into this: kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] PREEMPT SMP KASAN CPU: 2 PID: 2012 Comm: trinity-c3 Not tainted 4.7.0-rc7+ #19 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Ubuntu-1.8.2-1ubuntu1 04/01/2014 task: ffff8800b745f2c0 ti: ffff880111740000 task.ti: ffff880111740000 RIP: 0010:[<ffffffff82bbf066>] [<ffffffff82bbf066>] irttp_connect_request+0x36/0x710 RSP: 0018:ffff880111747bb8 EFLAGS: 00010286 RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000069dd8358 RDX: 0000000000000009 RSI: 0000000000000027 RDI: 0000000000000048 RBP: ffff880111747c00 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000069dd8358 R11: 1ffffffff0759723 R12: 0000000000000000 R13: ffff88011a7e4780 R14: 0000000000000027 R15: 0000000000000000 FS: 00007fc738404700(0000) GS:ffff88011af00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fc737fdfb10 CR3: 0000000118087000 CR4: 00000000000006e0 Stack: 0000000000000200 ffff880111747bd8 ffffffff810ee611 ffff880119f1f220 ffff880119f1f4f8 ffff880119f1f4f0 ffff88011a7e4780 ffff880119f1f232 ffff880119f1f220 ffff880111747d58 ffffffff82bca542 0000000000000000 Call Trace: [<ffffffff82bca542>] irda_connect+0x562/0x1190 [<ffffffff825ae582>] SYSC_connect+0x202/0x2a0 [<ffffffff825b4489>] SyS_connect+0x9/0x10 [<ffffffff8100334c>] do_syscall_64+0x19c/0x410 [<ffffffff83295ca5>] entry_SYSCALL64_slow_path+0x25/0x25 Code: 41 89 ca 48 89 e5 41 57 41 56 41 55 41 54 41 89 d7 53 48 89 fb 48 83 c7 48 48 89 fa 41 89 f6 48 c1 ea 03 48 83 ec 20 4c 8b 65 10 <0f> b6 04 02 84 c0 74 08 84 c0 0f 8e 4c 04 00 00 80 7b 48 00 74 RIP [<ffffffff82bbf066>] irttp_connect_request+0x36/0x710 RSP <ffff880111747bb8> ---[ end trace 4cda2588bc055b30 ]--- The problem is that irda_open_tsap() can fail and leave self->tsap = NULL, and then irttp_connect_request() almost immediately dereferences it. Cc: stable@vger.kernel.org Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2016-08-16 09:30:48 +02:00
..
6lowpan	6lowpan: put mcast compression in an own function	2015-10-21 00:49:25 +02:00
9p	IB/cma: Add support for network namespaces	2015-10-28 12:32:48 -04:00
802
8021q	vlan: Do not put vlan headers back on bridge and macvlan ports	2015-11-17 14:38:35 -05:00
appletalk
atm
ax25	AX.25: Close socket connection on session completion	2016-07-11 09:31:12 -07:00
batman-adv	batman-adv: Reduce refcnt of removed router when updating route	2016-05-11 11:21:18 +02:00
bluetooth	Bluetooth: Fix potential buffer overflow with Add Advertising	2016-04-12 09:08:54 -07:00
bridge	Bridge: Fix ipv6 mc snooping if bridge has no ipv6 address	2016-07-11 09:31:11 -07:00
caif	net: rename SOCK_ASYNC_NOSPACE and SOCK_ASYNC_WAITDATA	2015-12-01 15:45:05 -05:00
can	can: avoid using timeval for uapi	2015-10-13 17:42:34 +02:00
ceph	libceph: apply new_state before new_up_client on incrementals	2016-08-10 11:49:29 +02:00
core	net_sched: fix mirrored packets checksum	2016-07-27 09:47:31 -07:00
dcb	net/dcb: make dcbnl.c explicitly non-modular	2015-10-09 07:52:27 -07:00
dccp	tcp/dccp: remove obsolete WARN_ON() in icmp handlers	2016-04-20 15:42:04 +09:00
decnet	decnet: Do not build routes to devices without decnet private data.	2016-05-18 17:06:35 -07:00
dns_resolver	net: dns_resolver: convert time_t to time64_t	2015-11-18 16:27:46 -05:00
dsa	net: dsa: use switchdev obj for VLAN add/del ops	2015-11-01 15:56:11 -05:00
ethernet	net: help compiler generate better code in eth_get_headlen	2015-09-28 22:51:15 -07:00
hsr	net/hsr: fix a warning message	2015-11-23 14:56:15 -05:00
ieee802154	net: fix percpu memory leaks	2015-11-02 22:47:14 -05:00
ipv4	ipv4: reject RTNH_F_DEAD and RTNH_F_LINKDOWN from user space	2016-08-16 09:30:47 +02:00
ipv6	ipv6: Fix mem leak in rt6i_pcpu	2016-07-27 09:47:31 -07:00
ipx
irda	net/irda: fix NULL pointer dereference on memory allocation failure	2016-08-16 09:30:48 +02:00
iucv	af_iucv: Validate socket address length in iucv_sock_bind()	2016-03-03 15:07:03 -08:00
key	af_key: fix two typos	2015-10-23 03:05:19 -07:00
l2tp	l2tp: fix configuration passed to setup_udp_tunnel_sock()	2016-06-24 10:18:17 -07:00
l3mdev	net: Add netif_is_l3_slave	2015-10-07 04:27:43 -07:00
lapb
llc	net: fix infoleak in llc	2016-05-18 17:06:40 -07:00
mac80211	mac80211: Fix mesh estab_plinks counting in STA removal case	2016-07-27 09:47:27 -07:00
mac802154	mac802154: llsec: use kzfree	2015-10-21 00:49:24 +02:00
mpls	mpls: find_outdev: check for err ptr in addition to NULL check	2016-04-20 15:42:07 +09:00
netfilter	netfilter: x_tables: introduce and use xt_copy_counters_from_user	2016-06-24 10:18:24 -07:00
netlabel
netlink	netlink: Fix dump skb leak/double free	2016-06-24 10:18:16 -07:00
netrom
nfc	net: rename SOCK_ASYNC_NOSPACE and SOCK_ASYNC_WAITDATA	2015-12-01 15:45:05 -05:00
openvswitch	vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices	2016-06-24 10:18:18 -07:00
packet	packet: Use symmetric hash for PACKET_FANOUT_HASH.	2016-07-27 09:47:31 -07:00
phonet	phonet: properly unshare skbs in phonet_rcv()	2016-01-31 11:29:00 -08:00
rds	RDS: fix rds_tcp_init() error path	2016-08-10 11:49:29 +02:00
rfkill	rfkill: fix rfkill_fop_read wait_event usage	2016-03-03 15:07:26 -08:00
rose
rxrpc	net: rename SOCK_ASYNC_NOSPACE and SOCK_ASYNC_WAITDATA	2015-12-01 15:45:05 -05:00
sched	net_sched: fix mirrored packets checksum	2016-07-27 09:47:31 -07:00
sctp	sctp: lack the check for ports in sctp_v6_cmp_addr	2016-04-20 15:41:58 +09:00
sunrpc	nfsd4/rpc: move backchannel create logic into rpc code	2016-07-27 09:47:30 -07:00
switchdev	switchdev: pass pointer to fib_info instead of copy	2016-06-24 10:18:16 -07:00
tipc	tipc: fix nametable publication field in nl compat	2016-06-24 10:18:16 -07:00
unix	af_unix: fix hard linked sockets on overlay	2016-07-27 09:47:33 -07:00
vmw_vsock	VSOCK: do not disconnect socket when peer has shutdown SEND only	2016-05-18 17:06:41 -07:00
wimax
wireless	wext: Fix 32 bit iwpriv compatibility issue with 64 bit Kernel	2016-06-24 10:18:20 -07:00
x25	net: fix a kernel infoleak in x25 module	2016-05-18 17:06:43 -07:00
xfrm	xfrm: Fix crash observed during device unregistration and decryption	2016-04-20 15:42:05 +09:00
compat.c
Kconfig	net: Introduce L3 Master device abstraction	2015-09-29 20:40:32 -07:00
Makefile	net: Introduce L3 Master device abstraction	2015-09-29 20:40:32 -07:00
socket.c	net: Fix use after free in the recvmmsg exit path	2016-04-20 15:42:03 +09:00
sysctl_net.c	net: sysctl: fix a kmemleak warning	2015-10-23 06:22:08 -07:00