Taehee Yoo 263ed7e66b netfilter: nf_flow_table: remove flowtable hook flush routine in netns exit routine ... [ Upstream commit b7f1a16d29 ] When device is unregistered, flowtable flush routine is called by notifier_call(nf_tables_flowtable_event). and exit callback of nftables pernet_operation(nf_tables_exit_net) also has flowtable flush routine. but when network namespace is destroyed, both notifier_call and pernet_operation are called. hence flowtable flush routine in pernet_operation is unnecessary. test commands: %ip netns add vm1 %ip netns exec vm1 nft add table ip filter %ip netns exec vm1 nft add flowtable ip filter w \ { hook ingress priority 0\; devices = { lo }\; } %ip netns del vm1 splat looks like: [ 265.187019] WARNING: CPU: 0 PID: 87 at net/netfilter/core.c:309 nf_hook_entry_head+0xc7/0xf0 [ 265.187112] Modules linked in: nf_flow_table_ipv4 nf_flow_table nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink ip_tables x_tables [ 265.187390] CPU: 0 PID: 87 Comm: kworker/u4:2 Not tainted 4.19.0-rc3+ #5 [ 265.187453] Workqueue: netns cleanup_net [ 265.187514] RIP: 0010:nf_hook_entry_head+0xc7/0xf0 [ 265.187546] Code: 8d 81 68 03 00 00 5b c3 89 d0 83 fa 04 48 8d 84 c7 e8 11 00 00 76 81 0f 0b 31 c0 e9 78 ff ff ff 0f 0b 48 83 c4 08 31 c0 5b c3 <0f> 0b 31 c0 e9 65 ff ff ff 0f 0b 31 c0 e9 5c ff ff ff 48 89 0c 24 [ 265.187573] RSP: 0018:ffff88011546f098 EFLAGS: 00010246 [ 265.187624] RAX: ffffffff8d90e135 RBX: 1ffff10022a8de1c RCX: 0000000000000000 [ 265.187645] RDX: 0000000000000000 RSI: 0000000000000005 RDI: ffff880116298040 [ 265.187645] RBP: ffff88010ea4c1a8 R08: 0000000000000000 R09: 0000000000000000 [ 265.187645] R10: ffff88011546f1d8 R11: ffffed0022c532c1 R12: ffff88010ea4c1d0 [ 265.187645] R13: 0000000000000005 R14: dffffc0000000000 R15: ffff88010ea4c1c4 [ 265.187645] FS: 0000000000000000(0000) GS:ffff88011b200000(0000) knlGS:0000000000000000 [ 265.187645] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 265.187645] CR2: 00007fdfb8d00000 CR3: 0000000057a16000 CR4: 00000000001006f0 [ 265.187645] Call Trace: [ 265.187645] __nf_unregister_net_hook+0xca/0x5d0 [ 265.187645] ? nf_hook_entries_free.part.3+0x80/0x80 [ 265.187645] ? save_trace+0x300/0x300 [ 265.187645] nf_unregister_net_hooks+0x2e/0x40 [ 265.187645] nf_tables_exit_net+0x479/0x1340 [nf_tables] [ 265.187645] ? find_held_lock+0x39/0x1c0 [ 265.187645] ? nf_tables_abort+0x30/0x30 [nf_tables] [ 265.187645] ? inet_frag_destroy_rcu+0xd0/0xd0 [ 265.187645] ? trace_hardirqs_on+0x93/0x210 [ 265.187645] ? __bpf_trace_preemptirq_template+0x10/0x10 [ 265.187645] ? inet_frag_destroy_rcu+0xd0/0xd0 [ 265.187645] ? inet_frag_destroy_rcu+0xd0/0xd0 [ 265.187645] ? __mutex_unlock_slowpath+0x17f/0x740 [ 265.187645] ? wait_for_completion+0x710/0x710 [ 265.187645] ? bucket_table_free+0xb2/0x1f0 [ 265.187645] ? nested_table_free+0x130/0x130 [ 265.187645] ? __lock_is_held+0xb4/0x140 [ 265.187645] ops_exit_list.isra.10+0x94/0x140 [ 265.187645] cleanup_net+0x45b/0x900 [ ... ] This WARNING means that hook unregisteration is failed because all flowtables hooks are already unregistered by notifier_call. Network namespace exit routine guarantees that all devices will be unregistered first. then, other exit callbacks of pernet_operations are called. so that removing flowtable flush routine in exit callback of pernet_operation(nf_tables_exit_net) doesn't make flowtable leak. Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-04-20 09:16:02 +02:00
..
6lowpan
9p	9p: do not trust pdu content for stat item size	2019-04-20 09:16:00 +02:00
802
8021q
appletalk
atm	Revert "net: simplify sock_poll_wait"	2018-11-04 14:50:51 +01:00
ax25	ax25: fix possible use-after-free	2019-02-23 09:07:27 +01:00
batman-adv	batman-adv: release station info tidstats	2019-03-13 14:02:34 -07:00
bluetooth	Bluetooth: Fix debugfs NULL pointer dereference	2019-04-20 09:16:01 +02:00
bpf
bpfilter	net: bpfilter: use get_pid_task instead of pid_task	2018-10-17 22:03:40 -07:00
bridge	netfilter: physdev: relax br_netfilter dependency	2019-04-05 22:33:15 +02:00
caif	Revert "net: simplify sock_poll_wait"	2018-11-04 14:50:51 +01:00
can	can: bcm: check timer values before ktime conversion	2019-01-31 08:14:39 +01:00
ceph	libceph: wait for latest osdmap in ceph_monc_blacklist_add()	2019-03-27 14:14:39 +09:00
core	net: core: netif_receive_skb_list: unlist skb before passing to pt->func	2019-04-17 08:38:43 +02:00
dcb
dccp	dccp: do not use ipv6 header for ipv4 flow	2019-04-03 06:26:15 +02:00
decnet	decnet: fix using plain integer as NULL warning	2018-08-09 14:11:24 -07:00
dns_resolver
dsa	net: dsa: slave: Don't propagate flag changes on down slave interfaces	2019-02-12 19:47:22 +01:00
ethernet
hsr	net/hsr: fix possible crash in add_timer()	2019-03-19 13:12:38 +01:00
ieee802154	ieee802154: lowpan_header_create check must check daddr	2019-01-09 17:38:31 +01:00
ife
ipv4	net: ip_gre: fix possible use-after-free in erspan_rcv	2019-04-17 08:38:43 +02:00
ipv6	net: ip6_gre: fix possible use-after-free in ip6erspan_rcv	2019-04-17 08:38:43 +02:00
iucv	Revert "net: simplify sock_poll_wait"	2018-11-04 14:50:51 +01:00
kcm	kcm: switch order of device registration to fix a crash	2019-04-17 08:38:40 +02:00
key	af_key: unconditionally clone on broadcast	2019-03-23 20:09:48 +01:00
l2tp	l2tp: fix infoleak in l2tp_ip6_recvmsg()	2019-03-19 13:12:38 +01:00
l3mdev
lapb
llc	llc: do not use sk_eat_skb()	2018-12-01 09:37:27 +01:00
mac80211	mac80211: Fix Tx aggregation session tear down with ITXQs	2019-03-23 20:09:45 +01:00
mac802154
mpls	mpls: Return error for RTA_GATEWAY attribute	2019-03-10 07:17:19 +01:00
ncsi	net/ncsi: Fixup .dumpit message flags and ID check in Netlink handler	2018-08-22 21:39:08 -07:00
netfilter	netfilter: nf_flow_table: remove flowtable hook flush routine in netns exit routine	2019-04-20 09:16:02 +02:00
netlabel	netlabel: fix out-of-bounds memory accesses	2019-03-10 07:17:18 +01:00
netlink	genetlink: Fix a memory leak on error path	2019-04-03 06:26:15 +02:00
netrom	netrom: switch to sock timer API	2019-02-06 17:30:07 +01:00
nfc	net: nfc: Fix NULL dereference on nfc_llcp_build_tlv fails	2019-03-10 07:17:18 +01:00
nsh
openvswitch	openvswitch: fix flow actions reallocation	2019-04-17 08:38:41 +02:00
packet	packets: Always register packet sk in the same order	2019-04-03 06:26:17 +02:00
phonet	phonet: fix building with clang	2019-03-23 20:09:51 +01:00
psample
qrtr
rds	net: rds: force to destroy connection if t_sock is NULL in rds_tcp_kill_sock().	2019-04-17 08:38:41 +02:00
rfkill	Here are quite a large number of fixes, notably:	2018-09-03 22:12:02 -07:00
rose	net: rose: fix a possible stack overflow	2019-04-03 06:26:17 +02:00
rxrpc	rxrpc: Fix client call queueing, waiting for channel	2019-03-19 13:12:39 +01:00
sched	net/sched: fix ->get helper of the matchall cls	2019-04-17 08:38:41 +02:00
sctp	sctp: initialize _pad of sockaddr_in before copying to user memory	2019-04-17 08:38:41 +02:00
smc	net/smc: fix smc_poll in SMC_INIT state	2019-03-19 13:12:41 +01:00
strparser
sunrpc	svcrpc: fix UDP on servers with lots of threads	2019-03-23 20:10:10 +01:00
switchdev
tipc	tipc: fix cancellation of topology subscriptions	2019-04-03 06:26:18 +02:00
tls	net/tls: Init routines in create_ctx	2019-01-13 09:51:00 +01:00
unix	missing barriers in some of unix_sock ->addr and ->path accesses	2019-03-19 13:12:41 +01:00
vmw_vsock	vsock/virtio: reset connected sockets on device removal	2019-03-13 14:02:36 -07:00
wimax
wireless	cfg80211: extend range deviation for DMG	2019-03-05 17:58:52 +01:00
x25	net/x25: fix a race in x25_bind()	2019-03-19 13:12:40 +01:00
xdp	xsk: do not call synchronize_net() under RCU read lock	2018-10-11 10:19:01 +02:00
xfrm	xfrm: Fix inbound traffic via XFRM interfaces across network namespaces	2019-03-23 20:09:49 +01:00
compat.c	sock: Make sock->sk_stamp thread-safe	2019-01-09 17:38:33 +01:00
Kconfig
Makefile
socket.c	net: socket: set sock->sk to NULL after calling proto_ops::release()	2019-03-10 07:17:18 +01:00
sysctl_net.c