Jerry Snitselaar fb4ff6c732 iommu/vt-d: clean up pr_irq if request_threaded_irq fails ... [ Upstream commit 72d5481138 ] It is unlikely request_threaded_irq will fail, but if it does for some reason we should clear iommu->pr_irq in the error path. Also intel_svm_finish_prq shouldn't try to clean up the page request interrupt if pr_irq is 0. Without these, if request_threaded_irq were to fail the following occurs: fail with no fixes: [ 0.683147] ------------[ cut here ]------------ [ 0.683148] NULL pointer, cannot free irq [ 0.683158] WARNING: CPU: 1 PID: 1 at kernel/irq/irqdomain.c:1632 irq_domain_free_irqs+0x126/0x140 [ 0.683160] Modules linked in: [ 0.683163] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.15.0-rc2 #3 [ 0.683165] Hardware name: /NUC7i3BNB, BIOS BNKBL357.86A.0036.2017.0105.1112 01/05/2017 [ 0.683168] RIP: 0010:irq_domain_free_irqs+0x126/0x140 [ 0.683169] RSP: 0000:ffffc90000037ce8 EFLAGS: 00010292 [ 0.683171] RAX: 000000000000001d RBX: ffff880276283c00 RCX: ffffffff81c5e5e8 [ 0.683172] RDX: 0000000000000001 RSI: 0000000000000096 RDI: 0000000000000246 [ 0.683174] RBP: ffff880276283c00 R08: 0000000000000000 R09: 000000000000023c [ 0.683175] R10: 0000000000000007 R11: 0000000000000000 R12: 000000000000007a [ 0.683176] R13: 0000000000000001 R14: 0000000000000000 R15: 0000010010000000 [ 0.683178] FS: 0000000000000000(0000) GS:ffff88027ec80000(0000) knlGS:0000000000000000 [ 0.683180] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.683181] CR2: 0000000000000000 CR3: 0000000001c09001 CR4: 00000000003606e0 [ 0.683182] Call Trace: [ 0.683189] intel_svm_finish_prq+0x3c/0x60 [ 0.683191] free_dmar_iommu+0x1ac/0x1b0 [ 0.683195] init_dmars+0xaaa/0xaea [ 0.683200] ? klist_next+0x19/0xc0 [ 0.683203] ? pci_do_find_bus+0x50/0x50 [ 0.683205] ? pci_get_dev_by_id+0x52/0x70 [ 0.683208] intel_iommu_init+0x498/0x5c7 [ 0.683211] pci_iommu_init+0x13/0x3c [ 0.683214] ? e820__memblock_setup+0x61/0x61 [ 0.683217] do_one_initcall+0x4d/0x1a0 [ 0.683220] kernel_init_freeable+0x186/0x20e [ 0.683222] ? set_debug_rodata+0x11/0x11 [ 0.683225] ? rest_init+0xb0/0xb0 [ 0.683226] kernel_init+0xa/0xff [ 0.683229] ret_from_fork+0x1f/0x30 [ 0.683259] Code: 89 ee 44 89 e7 e8 3b e8 ff ff 5b 5d 44 89 e7 44 89 ee 41 5c 41 5d 41 5e e9 a8 84 ff ff 48 c7 c7 a8 71 a7 81 31 c0 e8 6a d3 f9 ff <0f> ff 5b 5d 41 5c 41 5d 41 5 e c3 0f 1f 44 00 00 66 2e 0f 1f 84 [ 0.683285] ---[ end trace f7650e42792627ca ]--- with iommu->pr_irq = 0, but no check in intel_svm_finish_prq: [ 0.669561] ------------[ cut here ]------------ [ 0.669563] Trying to free already-free IRQ 0 [ 0.669573] WARNING: CPU: 3 PID: 1 at kernel/irq/manage.c:1546 __free_irq+0xa4/0x2c0 [ 0.669574] Modules linked in: [ 0.669577] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 4.15.0-rc2 #4 [ 0.669579] Hardware name: /NUC7i3BNB, BIOS BNKBL357.86A.0036.2017.0105.1112 01/05/2017 [ 0.669581] RIP: 0010:__free_irq+0xa4/0x2c0 [ 0.669582] RSP: 0000:ffffc90000037cc0 EFLAGS: 00010082 [ 0.669584] RAX: 0000000000000021 RBX: 0000000000000000 RCX: ffffffff81c5e5e8 [ 0.669585] RDX: 0000000000000001 RSI: 0000000000000086 RDI: 0000000000000046 [ 0.669587] RBP: 0000000000000000 R08: 0000000000000000 R09: 000000000000023c [ 0.669588] R10: 0000000000000007 R11: 0000000000000000 R12: ffff880276253960 [ 0.669589] R13: ffff8802762538a4 R14: ffff880276253800 R15: ffff880276283600 [ 0.669593] FS: 0000000000000000(0000) GS:ffff88027ed80000(0000) knlGS:0000000000000000 [ 0.669594] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.669596] CR2: 0000000000000000 CR3: 0000000001c09001 CR4: 00000000003606e0 [ 0.669602] Call Trace: [ 0.669616] free_irq+0x30/0x60 [ 0.669620] intel_svm_finish_prq+0x34/0x60 [ 0.669623] free_dmar_iommu+0x1ac/0x1b0 [ 0.669627] init_dmars+0xaaa/0xaea [ 0.669631] ? klist_next+0x19/0xc0 [ 0.669634] ? pci_do_find_bus+0x50/0x50 [ 0.669637] ? pci_get_dev_by_id+0x52/0x70 [ 0.669639] intel_iommu_init+0x498/0x5c7 [ 0.669642] pci_iommu_init+0x13/0x3c [ 0.669645] ? e820__memblock_setup+0x61/0x61 [ 0.669648] do_one_initcall+0x4d/0x1a0 [ 0.669651] kernel_init_freeable+0x186/0x20e [ 0.669653] ? set_debug_rodata+0x11/0x11 [ 0.669656] ? rest_init+0xb0/0xb0 [ 0.669658] kernel_init+0xa/0xff [ 0.669661] ret_from_fork+0x1f/0x30 [ 0.669662] Code: 7a 08 75 0e e9 c3 01 00 00 4c 39 7b 08 74 57 48 89 da 48 8b 5a 18 48 85 db 75 ee 89 ee 48 c7 c7 78 67 a7 81 31 c0 e8 4c 37 fa ff <0f> ff 48 8b 34 24 4c 89 ef e 8 0e 4c 68 00 49 8b 46 40 48 8b 80 [ 0.669688] ---[ end trace 58a470248700f2fc ]--- Cc: Alex Williamson <alex.williamson@redhat.com> Cc: Joerg Roedel <joro@8bytes.org> Cc: Ashok Raj <ashok.raj@intel.com> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> Reviewed-by: Ashok Raj <ashok.raj@intel.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-03-24 10:58:48 +01:00
..
accessibility
acpi	ACPI / PMIC: xpower: Fix power_table addresses	2018-03-24 10:58:45 +01:00
amba
android	binder: add missing binder_unlock()	2018-02-28 10:17:23 +01:00
ata	ahci: Add Intel Cannon Lake PCH-H PCI ID	2018-02-16 20:09:42 +01:00
atm	atm: horizon: Fix irq release error	2017-12-16 10:33:55 +01:00
auxdisplay
base	drivers: base: cacheinfo: fix boot error message when acpi is enabled	2018-01-31 12:06:08 +01:00
bcma
block	mtip32xx: use runtime tag to initialize command header	2018-03-24 10:58:44 +01:00
bluetooth	Bluetooth: hci_qca: Avoid setup failure on missing rampatch	2018-03-24 10:58:46 +01:00
bus	sunxi-rsb: Include OF based modalias in device uevent	2018-01-10 09:27:09 +01:00
cdrom
char	ipmi/watchdog: fix wdog hang on panic waiting for ipmi response	2018-03-24 10:58:45 +01:00
clk	clk: ns2: Correct SDIO bits	2018-03-24 10:58:41 +01:00
clocksource	clockevents/drivers/cs5535: Improve resilience to spurious interrupts	2017-10-27 10:23:17 +02:00
connector
cpufreq	cpufreq/sh: Replace racy task affinity logic	2018-03-24 10:58:41 +01:00
cpuidle	cpuidle: fix broadcast control when broadcast can not be entered	2017-12-25 14:22:15 +01:00
crypto	crypto: s5p-sss - Fix kernel Oops in AES-ECB mode	2018-02-25 11:03:55 +01:00
dca
devfreq	PM / devfreq: Propagate error from devfreq_add_device()	2018-02-22 15:44:58 +01:00
dio
dma	dmaengine: imx-sdma: add 1ms delay to ensure SDMA channel is stopped	2018-03-22 09:23:22 +01:00
dma-buf
edac	EDAC, octeon: Fix an uninitialized variable warning	2018-02-16 20:09:47 +01:00
eisa
extcon	extcon: palmas: Check the parent instance to prevent the NULL	2017-11-21 09:21:18 +01:00
firewire
firmware	efi/esrt: Cleanup bad memory map log messages	2017-12-20 10:04:56 +01:00
fmc
fpga
gpio	gpio: xgene: mark PM functions as __maybe_unused	2018-02-25 11:03:50 +01:00
gpu	drm/omap: DMM: Check for DMM readiness after successful transaction commit	2018-03-24 10:58:48 +01:00
hid	HID: elo: clear BTN_LEFT mapping	2018-03-22 09:23:27 +01:00
hsi	HSI: ssi_protocol: double free in ssip_pn_xmit()	2018-03-24 10:58:42 +01:00
hv	Drivers: hv: vmbus: fix build warning	2018-02-25 11:03:46 +01:00
hwmon	driver: (adm1275) set the m,b and R coefficients correctly for power	2018-03-22 09:23:22 +01:00
hwspinlock
hwtracing	coresight: Fix disabling of CoreSight TPIU	2018-03-24 10:58:48 +01:00
i2c	i2c: i2c-scmi: add a MS HID	2018-03-24 10:58:41 +01:00
ide
idle	idle: i7300: add PCI dependency	2018-02-25 11:03:51 +01:00
iio	iio: st_pressure: st_accel: Initialise sensor platform data properly	2018-03-24 10:58:44 +01:00
infiniband	IB/umem: Fix use of npages/nmap fields	2018-03-24 10:58:47 +01:00
input	Input: twl4030-pwrbutton - use correct device for irq request	2018-03-24 10:58:45 +01:00
iommu	iommu/vt-d: clean up pr_irq if request_threaded_irq fails	2018-03-24 10:58:48 +01:00
ipack
irqchip	irqchip/gic-v3-its: Ensure nr_ites >= nr_lpis	2018-03-22 09:23:31 +01:00
isdn	isdn: sc: work around type mismatch warning	2018-02-25 11:03:51 +01:00
leds	Revert "led: core: Fix brightness setting when setting delay_off=0"	2018-03-11 16:19:45 +01:00
lguest
lightnvm
macintosh
mailbox	mailbox: handle empty message in tx_tick	2017-08-06 19:19:41 -07:00
mcb
md	md/raid10: skip spare disk as 'first' disk	2018-03-24 10:58:45 +01:00
media	media: [RESEND] media: dvb-frontends: Add delay to Si2168 restart	2018-03-24 10:58:47 +01:00
memory	ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure	2017-12-16 10:33:51 +01:00
memstick
message	mptfusion: hide unused seq_mpt_print_ioc_summary function	2018-02-25 11:03:45 +01:00
mfd	mfd: palmas: Reset the POWERHOLD mux during power off	2018-03-24 10:58:44 +01:00
misc	scsi: ses: don't get power status of SES device slot on probe	2018-03-22 09:23:24 +01:00
mmc	mmc: avoid removing non-removable hosts during suspend	2018-03-24 10:58:47 +01:00
mtd	mtd: nand: fix interpretation of NAND_CMD_NONE in nand_command[_lp]()	2018-03-22 09:23:28 +01:00
net	rtlwifi: rtl_pci: Fix the bug when inactiveps is enabled.	2018-03-24 10:58:47 +01:00
nfc	NFC: nfcmrvl: double free on error path	2018-03-22 09:23:23 +01:00
ntb	ntb_transport: fix bug calculating num_qps_mw	2017-08-30 10:19:29 +02:00
nubus
nvdimm	libnvdimm, namespace: make 'resource' attribute only readable by root	2017-11-30 08:37:23 +00:00
nvme	nvme: Fix managing degraded controllers	2018-02-16 20:09:47 +01:00
nvmem	nvmem: imx-ocotp: Fix wrong register size	2017-08-06 19:19:46 -07:00
of	of: fix of_device_get_modalias returned length when truncating buffers	2018-03-22 09:23:21 +01:00
oprofile
parisc	parisc: Hide Diva-built-in serial aux and graphics card	2018-01-02 20:33:20 +01:00
parport	parisc, parport_gsc: Fixes for printk continuation lines	2017-06-17 06:39:37 +02:00
pci	PCI/MSI: Stop disabling MSI/MSI-X in pci_device_shutdown()	2018-03-22 09:23:19 +01:00
pcmcia
perf	drivers/perf: arm_pmu: handle no platform_device	2018-03-22 09:23:26 +01:00
phy	phy: work around 'phys' references to usb-nop-xceiv devices	2018-01-23 19:50:16 +01:00
pinctrl	pinctrl: Really force states during suspend/resume	2018-03-24 10:58:48 +01:00
platform	platform/chrome: Use proper protocol transfer function	2018-03-24 10:58:47 +01:00
pnp
power	power: supply: pda_power: move from timer to delayed_work	2018-03-24 10:58:45 +01:00
powercap
pps
ps3
ptp	time: Change posix clocks ops interfaces to use timespec64	2018-03-24 10:58:40 +01:00
pwm	pwm: tegra: Increase precision in PWM rate calculation	2018-03-22 09:23:27 +01:00
rapidio
ras
regulator	regulator: anatop: set default voltage selector for pcie	2018-03-24 10:58:40 +01:00
remoteproc
reset
rpmsg
rtc	rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL	2018-03-24 10:58:46 +01:00
s390	s390/qeth: fix IPA command submission race	2018-03-11 16:19:47 +01:00
sbus
scsi	scsi: mac_esp: Replace bogus memory barrier with spinlock	2018-03-24 10:58:43 +01:00
sfi
sh
sn
soc
spi	spi: dw: Disable clock after unregistering the host	2018-03-24 10:58:41 +01:00
spmi	spmi: Include OF based modalias in device uevent	2017-07-27 15:06:10 -07:00
ssb	ssb: mark ssb_bus_register as __maybe_unused	2018-02-25 11:03:44 +01:00
staging	staging: wilc1000: fix unchecked return value	2018-03-24 10:58:44 +01:00
target	tcm_fileio: Prevent information leak for short reads	2018-03-24 10:58:45 +01:00
tc
thermal	thermal: spear: use __maybe_unused for PM functions	2018-02-25 11:03:44 +01:00
thunderbolt
tty	pty: cancel pty slave port buf's work in tty_release	2018-03-24 10:58:48 +01:00
uio
usb	usb: gadget: bdc: 64-bit pointer capability check	2018-03-22 09:23:32 +01:00
uwb	uwb: ensure that endpoint is interrupt	2017-10-12 11:27:35 +02:00
vfio	vfio-pci: Handle error from pci_iomap	2017-08-06 19:19:46 -07:00
vhost	vhost_net: stop device during reset owner	2018-02-16 20:09:38 +01:00
video	vgacon: Set VGA struct resource types	2018-03-24 10:58:48 +01:00
virt
virtio	virtio_balloon: prevent uninitialized variable use	2018-02-25 11:03:42 +01:00
vlynq
vme
w1
watchdog	watchdog: hpwdt: fix unused variable warning	2018-03-18 11:17:50 +01:00
xen	xen/gntdev: Fix partial gntdev_mmap() cleanup	2018-03-03 10:19:45 +01:00
zorro
Kconfig
Makefile	usb: build drivers/usb/common/ when USB_SUPPORT is set	2018-02-25 11:03:38 +01:00