Oleg Nesterov 0f008dc311 uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned ... commit 013b2deba9 upstream. uprobe_write_opcode() must not cross page boundary; prepare_uprobe() relies on arch_uprobe_analyze_insn() which should validate "vaddr" but some architectures (csky, s390, and sparc) don't do this. We can remove the BUG_ON() check in prepare_uprobe() and validate the offset early in __uprobe_register(). The new IS_ALIGNED() check matches the alignment check in arch_prepare_kprobe() on supported architectures, so I think that all insns must be aligned to UPROBE_SWBP_INSN_SIZE. Another problem is __update_ref_ctr() which was wrong from the very beginning, it can read/write outside of kmap'ed page unless "vaddr" is aligned to sizeof(short), __uprobe_register() should check this too. Reported-by: Linus Torvalds <torvalds@linux-foundation.org> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Tested-by: Sven Schnelle <svens@linux.ibm.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: stable@vger.kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> [ check for ref_ctr_offset removed for backport - gregkh ] Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-06-10 21:35:01 +02:00
..
callchain.c	treewide: convert ISO_8859-1 text comments to utf-8	2018-08-23 18:48:43 -07:00
core.c	perf/core: fix parent pid/tid in task exit events	2020-05-02 17:25:53 +02:00
hw_breakpoint.c	perf/hw_breakpoint: Fix arch_hw_breakpoint use-before-initialization	2019-10-17 13:45:44 -07:00
internal.h	perf: Make perf_callchain function static	2018-01-08 12:33:01 -03:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ring_buffer.c	perf/ring-buffer: Always use {READ,WRITE}_ONCE() for rb->user_page data	2019-06-22 08:15:16 +02:00
uprobes.c	uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned	2020-06-10 21:35:01 +02:00