Marcelo Ricardo Leitner 7bf24986e3 sctp: fix ASCONF list handling ... commit 2d45a02d01 upstream. ->auto_asconf_splist is per namespace and mangled by functions like sctp_setsockopt_auto_asconf() which doesn't guarantee any serialization. Also, the call to inet_sk_copy_descendant() was backuping ->auto_asconf_list through the copy but was not honoring ->do_auto_asconf, which could lead to list corruption if it was different between both sockets. This commit thus fixes the list handling by using ->addr_wq_lock spinlock to protect the list. A special handling is done upon socket creation and destruction for that. Error handlig on sctp_init_sock() will never return an error after having initialized asconf, so sctp_destroy_sock() can be called without addrq_wq_lock. The lock now will be take on sctp_close_sock(), before locking the socket, so we don't do it in inverse order compared to sctp_addr_wq_timeout_handler(). Instead of taking the lock on sctp_sock_migrate() for copying and restoring the list values, it's preferred to avoid rewritting it by implementing sctp_copy_descendant(). Issue was found with a test application that kept flipping sysctl default_auto_asconf on and off, but one could trigger it by issuing simultaneous setsockopt() calls on multiple sockets or by creating/destroying sockets fast enough. This is only triggerable locally. Fixes: 9f7d653b67 ("sctp: Add Auto-ASCONF support (core).") Reported-by: Ji Jianwen <jiji@redhat.com> Suggested-by: Neil Horman <nhorman@tuxdriver.com> Suggested-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> [wangkai: backport to 3.10: adjust context] Signed-off-by: Wang Kai <morgan.wang@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2015-10-01 12:07:34 +02:00
..
acpi	ACPICA: Tables: Fix an issue that FACS initialization is performed twice	2015-08-03 09:29:46 -07:00
asm-generic	nosave: consolidate __nosave_{begin,end} in <asm/sections.h>	2015-05-06 21:56:28 +02:00
clocksource	clocksource: arch_timer: use virtual counters	2014-01-09 12:24:26 -08:00
crypto	crypto: scatterwalk - Use sg_chain_ptr on chain entries	2013-12-11 22:36:29 -08:00
drm	drm/radeon: add new OLAND pci id	2015-09-13 09:07:59 -07:00
dt-bindings
keys
linux	iio: Add inverse unit conversion macros	2015-09-21 10:00:07 -07:00
math-emu
media	media: vb2: fix VBI/poll regression	2014-10-09 12:18:42 -07:00
memory
misc
net	sctp: fix ASCONF list handling	2015-10-01 12:07:34 +02:00
pcmcia
ras
rdma
rxrpc
scsi	scsi: fix our current target reap infrastructure	2014-05-30 21:52:11 -07:00
sound	ALSA: emu10k1: Emu10k2 32 bit DMA mode	2015-05-13 05:15:41 -07:00
target	target: Report correct response length for some commands	2014-06-30 20:09:45 -07:00
trace	tracing: Fix syscall_*regfunc() vs copy_process() race	2014-07-06 18:54:16 -07:00
uapi	USB: usbfs: allow URBs to be reaped after disconnection	2015-08-03 09:29:47 -07:00
video	Merge branch 'fbdev-3.10-fixes' of git://gitorious.org/linux-omap-dss2/linux into linux-fbdev/for-3.10-fixes	2013-05-29 17:00:34 +08:00
xen	xenbus: delay xenbus frontend resume if xenstored is not running	2013-05-29 09:04:19 -04:00
Kbuild