Florian Westphal c5ee4cbd0f netfilter: ctnetlink: disable helper autoassign ... [ Upstream commit d1ca60efc5 ] When userspace, e.g. conntrackd, inserts an entry with a specified helper, its possible that the helper is lost immediately after its added: ctnetlink_create_conntrack -> nf_ct_helper_ext_add + assign helper -> ctnetlink_setup_nat -> ctnetlink_parse_nat_setup -> parse_nat_setup -> nfnetlink_parse_nat_setup -> nf_nat_setup_info -> nf_conntrack_alter_reply -> __nf_ct_try_assign_helper ... and __nf_ct_try_assign_helper will zero the helper again. Set IPS_HELPER bit to bypass auto-assign logic, its unwanted, just like when helper is assigned via ruleset. Dropped old 'not strictly necessary' comment, it referred to use of rcu_assign_pointer() before it got replaced by RCU_INIT_POINTER(). NB: Fixes tag intentionally incorrect, this extends the referenced commit, but this change won't build without IPS_HELPER introduced there. Fixes: 6714cf5465 ("netfilter: nf_conntrack: fix explicit helper attachment and NAT") Reported-by: Pham Thanh Tuyen <phamtyn@gmail.com> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-02-16 12:56:25 +01:00
..
ipset	netfilter: ipset: Fix oversized kvmalloc() calls	2021-09-14 00:50:01 +02:00
ipvs	netfilter: ipvs: Fix reuse connection if RS weight is 0	2021-12-01 09:04:45 +01:00
core.c
Kconfig	netfilter: Kconfig: use 'default y' instead of 'm' for bool config option	2021-10-07 19:37:25 +02:00
Makefile	netfilter: add netfilter hooks to SRv6 data plane	2021-08-30 01:51:36 +02:00
nf_conncount.c
nf_conntrack_acct.c
nf_conntrack_amanda.c
nf_conntrack_broadcast.c
nf_conntrack_core.c	netfilter: conntrack: don't increment invalid counter on NF_REPEAT	2022-02-01 17:27:09 +01:00
nf_conntrack_ecache.c	netfilter: ecache: remove nf_exp_event_notifier structure	2021-08-25 12:50:38 +02:00
nf_conntrack_expect.c	netfilter: conntrack: switch to siphash	2021-08-30 11:49:55 +02:00
nf_conntrack_extend.c
nf_conntrack_ftp.c	netfilter: remove BUG_ON() after skb_header_pointer()	2021-05-05 23:45:48 +02:00
nf_conntrack_h323_asn1.c
nf_conntrack_h323_main.c	netfilter: fix clang-12 fmt string warnings	2021-06-01 23:53:51 +02:00
nf_conntrack_h323_types.c
nf_conntrack_helper.c	netfilter: nftables: add nf_ct_pernet() helper function	2021-06-07 12:23:37 +02:00
nf_conntrack_irc.c	netfilter: remove BUG_ON() after skb_header_pointer()	2021-05-05 23:45:48 +02:00
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c	netfilter: ctnetlink: disable helper autoassign	2022-02-16 12:56:25 +01:00
nf_conntrack_pptp.c	netfilter: remove BUG_ON() after skb_header_pointer()	2021-05-05 23:45:48 +02:00
nf_conntrack_proto_dccp.c	netfilter: conntrack: pass hook state to log functions	2021-06-18 14:47:43 +02:00
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c	netfilter: conntrack: nf_ct_gre_keymap_flush() removal	2021-07-02 02:07:01 +02:00
nf_conntrack_proto_icmp.c	netfilter: conntrack: pass hook state to log functions	2021-06-18 14:47:43 +02:00
nf_conntrack_proto_icmpv6.c	netfilter: conntrack: pass hook state to log functions	2021-06-18 14:47:43 +02:00
nf_conntrack_proto_sctp.c	netfilter: conntrack: pass hook state to log functions	2021-06-18 14:47:43 +02:00
nf_conntrack_proto_tcp.c	netfilter: conntrack: remove offload_pickup sysctl again	2021-08-06 17:07:41 +02:00
nf_conntrack_proto_udp.c	netfilter: conntrack: set on IPS_ASSURED if flows enters internal stream state	2021-11-18 19:16:21 +01:00
nf_conntrack_proto.c	netfilter: conntrack: nf_ct_gre_keymap_flush() removal	2021-07-02 02:07:01 +02:00
nf_conntrack_sane.c	netfilter: remove BUG_ON() after skb_header_pointer()	2021-05-05 23:45:48 +02:00
nf_conntrack_seqadj.c
nf_conntrack_sip.c
nf_conntrack_snmp.c
nf_conntrack_standalone.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2021-09-03 16:20:37 -07:00
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c
nf_dup_netdev.c
nf_flow_table_core.c	netfilter: conntrack: annotate data-races around ct->timeout	2021-12-14 10:57:10 +01:00
nf_flow_table_inet.c
nf_flow_table_ip.c
nf_flow_table_offload.c	netfilter: flowtable: fix IPv6 tunnel addr match	2021-12-01 09:04:45 +01:00
nf_hooks_lwtunnel.c	netfilter: add netfilter hooks to SRv6 data plane	2021-08-30 01:51:36 +02:00
nf_internals.h
nf_log_syslog.c
nf_log.c
nf_nat_amanda.c
nf_nat_core.c	netfilter: nat: include zone id in nat table hash again	2021-09-21 03:46:55 +02:00
nf_nat_ftp.c
nf_nat_helper.c
nf_nat_irc.c
nf_nat_masquerade.c	netfilter: nf_nat_masquerade: defer conntrack walk to work queue	2021-09-21 03:46:56 +02:00
nf_nat_proto.c
nf_nat_redirect.c
nf_nat_sip.c
nf_nat_tftp.c
nf_queue.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2021-08-11 10:22:26 +01:00
nf_sockopt.c
nf_synproxy_core.c	netfilter: synproxy: Fix out of bounds when parsing TCP options	2021-06-10 14:26:18 -07:00
nf_tables_api.c	netfilter: nf_tables: fix use-after-free in nft_set_catchall_destroy()	2021-12-29 12:28:40 +01:00
nf_tables_core.c	netfilter: nf_tables: add last expression	2021-06-17 03:23:00 +02:00
nf_tables_offload.c	net: Fix offloading indirect devices dependency on qdisc order creation	2021-08-19 13:19:30 +01:00
nf_tables_trace.c	netfilter: nf_tables: add and use nft_thoff helper	2021-05-29 01:04:54 +02:00
nfnetlink_acct.c	netfilter: use nfnetlink_unicast()	2021-05-29 01:04:53 +02:00
nfnetlink_cthelper.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net	2021-06-07 13:01:52 -07:00
nfnetlink_cttimeout.c	netfilter: use nfnetlink_unicast()	2021-05-29 01:04:53 +02:00
nfnetlink_hook.c	netfilter: nfnetlink_hook: translate inet ingress to netdev	2021-08-06 17:07:41 +02:00
nfnetlink_log.c	netfilter: fix regression in looped (broad|multi)cast's MAC handling	2021-12-29 12:28:40 +01:00
nfnetlink_osf.c	netfilter: nfnetlink_osf: Fix a missing skb_header_pointer() NULL check	2021-05-05 22:26:09 +02:00
nfnetlink_queue.c	netfilter: fix regression in looped (broad|multi)cast's MAC handling	2021-12-29 12:28:40 +01:00
nfnetlink.c	netfilter: add new hook nfnl subsystem	2021-06-07 12:41:10 +02:00
nft_bitwise.c
nft_byteorder.c
nft_chain_filter.c	netfilter: nf_tables: skip netdev events generated on netns removal	2021-10-07 19:37:38 +02:00
nft_chain_nat.c	netfilter: nf_tables: remove unused arg in nft_set_pktinfo_unspec()	2021-05-29 01:04:54 +02:00
nft_chain_route.c	netfilter: nf_tables: remove unused arg in nft_set_pktinfo_unspec()	2021-05-29 01:04:54 +02:00
nft_cmp.c
nft_compat.c	netfilter: log: work around missing softdep backend module	2021-09-21 03:46:56 +02:00
nft_connlimit.c
nft_counter.c
nft_ct.c	netfilter: nft_ct: protect nft_ct_pcpu_template_refcnt with mutex	2021-08-11 11:22:19 +02:00
nft_dup_netdev.c
nft_dynset.c	netfilter: nft_dynset: relax superfluous check on set updates	2021-11-18 19:16:30 +01:00
nft_exthdr.c	netfilter: nft_exthdr: break evaluation if setting TCP option fails	2021-12-14 10:57:10 +01:00
nft_fib_inet.c
nft_fib_netdev.c
nft_fib.c
nft_flow_offload.c	netfilter: nf_tables: add and use nft_thoff helper	2021-05-29 01:04:54 +02:00
nft_fwd_netdev.c
nft_hash.c
nft_immediate.c
nft_last.c	netfilter: nft_last: avoid possible false sharing	2021-07-23 14:18:02 +02:00
nft_limit.c
nft_log.c
nft_lookup.c	netfilter: nf_tables: prefer direct calls for set lookups	2021-05-29 01:04:27 +02:00
nft_masq.c
nft_meta.c
nft_nat.c	netfilter: nft_nat: allow to specify layer 4 protocol NAT only	2021-07-23 14:18:03 +02:00
nft_numgen.c
nft_objref.c	netfilter: add and use nft_set_do_lookup helper	2021-05-28 21:11:41 +02:00
nft_osf.c	netfilter: nft_osf: check for TCP packet before further processing	2021-06-16 20:51:50 +02:00
nft_payload.c	netfilter: nft_payload: do not update layer 4 checksum when mangling fragments	2022-01-27 11:03:51 +01:00
nft_queue.c
nft_quota.c	netfilter: nf_tables: honor NLM_F_CREATE and NLM_F_EXCL in event notification	2021-10-02 12:00:17 +02:00
nft_range.c
nft_redir.c
nft_reject_inet.c	netfilter: nf_tables: add and use nft_sk helper	2021-05-29 01:04:53 +02:00
nft_reject_netdev.c
nft_reject.c
nft_rt.c
nft_set_bitmap.c	netfilter: nf_tables: prefer direct calls for set lookups	2021-05-29 01:04:27 +02:00
nft_set_hash.c	netfilter: nf_tables: prefer direct calls for set lookups	2021-05-29 01:04:27 +02:00
nft_set_pipapo_avx2.c	nft_set_pipapo: Fix bucket load in AVX2 lookup routine for six 8-bit groups	2021-12-14 10:57:06 +01:00
nft_set_pipapo_avx2.h	netfilter: nf_tables: prefer direct calls for set lookups	2021-05-29 01:04:27 +02:00
nft_set_pipapo.c	netfilter: nft_set_pipapo: allocate pcpu scratch maps on clone	2022-01-27 11:03:51 +01:00
nft_set_pipapo.h	netfilter: nf_tables: prefer direct calls for set lookups	2021-05-29 01:04:27 +02:00
nft_set_rbtree.c	netfilter: nf_tables: prefer direct calls for set lookups	2021-05-29 01:04:27 +02:00
nft_socket.c
nft_synproxy.c	netfilter: nf_tables: add and use nft_thoff helper	2021-05-29 01:04:54 +02:00
nft_tproxy.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-06-29 15:45:27 -07:00
nft_tunnel.c
nft_xfrm.c
utils.c
x_tables.c	netfilter: x_tables: never register tables by default	2021-08-09 10:22:01 +02:00
xt_addrtype.c
xt_AUDIT.c	netfilter: fix clang-12 fmt string warnings	2021-06-01 23:53:51 +02:00
xt_bpf.c	bpf: Refactor BPF_PROG_RUN into a function	2021-08-17 00:45:07 +02:00
xt_cgroup.c
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c
xt_comment.c
xt_connbytes.c
xt_connlabel.c
xt_connlimit.c
xt_connmark.c
xt_CONNSECMARK.c
xt_conntrack.c
xt_cpu.c
xt_CT.c	netfilter: remove xt pernet data	2021-08-01 12:00:51 +02:00
xt_dccp.c
xt_devgroup.c
xt_dscp.c
xt_DSCP.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c
xt_helper.c
xt_hl.c
xt_HL.c
xt_HMARK.c
xt_IDLETIMER.c	netfilter: xt_IDLETIMER: fix panic that occurs when timer_type has garbage value	2021-10-07 19:35:57 +02:00
xt_ipcomp.c
xt_iprange.c
xt_ipvs.c
xt_l2tp.c
xt_LED.c
xt_length.c
xt_limit.c	netfilter: x_tables: improve limit_mt scalability	2021-05-29 01:04:52 +02:00
xt_LOG.c	netfilter: log: work around missing softdep backend module	2021-09-21 03:46:56 +02:00
xt_mac.c
xt_mark.c
xt_MASQUERADE.c
xt_multiport.c
xt_nat.c
xt_NETMAP.c
xt_nfacct.c
xt_NFLOG.c	netfilter: log: work around missing softdep backend module	2021-09-21 03:46:56 +02:00
xt_NFQUEUE.c
xt_osf.c
xt_owner.c
xt_physdev.c
xt_pkttype.c
xt_policy.c
xt_quota.c
xt_rateest.c
xt_RATEEST.c
xt_realm.c
xt_recent.c
xt_REDIRECT.c
xt_repldata.h
xt_sctp.c
xt_SECMARK.c	netfilter: xt_SECMARK: add new revision to fix structure layout	2021-05-03 23:02:44 +02:00
xt_set.c
xt_socket.c
xt_state.c
xt_statistic.c
xt_string.c
xt_tcpmss.c
xt_TCPMSS.c
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c
xt_time.c
xt_TPROXY.c
xt_TRACE.c
xt_u32.c