mirror of
https://github.com/torvalds/linux.git
synced 2026-10-08 19:46:02 +02:00
f53167e29b
Some clone SFP modules return EEPROM reads where the vendor PN field contains non-printable garbage past the trailing legitimate characters instead of the SFF-8472 mandated space padding. The current sfp_match() requires an exact full-field length match: sfp_strlen() returns 16 (no trailing spaces or NULs to strip), but strlen() of the quirk string is shorter, so the length comparison rejects the entry before strncmp() is even called and the quirk silently never applies. Add a part_prefix_match flag to struct sfp_quirk and a SFP_QUIRK_F_PREFIX macro. When set, sfp_match() compares only strlen() leading bytes of the quirk part string, ignoring trailing field bytes. The vendor name comparison always stays exact. Existing exact-match quirks are unaffected (part_prefix_match defaults to false via zero-init in the existing SFP_QUIRK macros). This patch only adds the mechanism; the first user is added by the following patch. Signed-off-by: Martino Dell'Ambrogio <tillo@tillo.ch> Link: https://patch.msgid.link/20260812154708.2201266-2-tillo@tillo.ch Signed-off-by: Jakub Kicinski <kuba@kernel.org>
46 lines
1.4 KiB
C
46 lines
1.4 KiB
C
#ifndef SFP_H
|
|
#define SFP_H
|
|
|
|
#include <linux/ethtool.h>
|
|
#include <linux/sfp.h>
|
|
|
|
struct sfp;
|
|
|
|
struct sfp_quirk {
|
|
const char *vendor;
|
|
const char *part;
|
|
void (*support)(const struct sfp_eeprom_id *id,
|
|
struct sfp_module_caps *caps);
|
|
void (*fixup)(struct sfp *sfp);
|
|
bool part_prefix_match;
|
|
};
|
|
|
|
struct sfp_socket_ops {
|
|
void (*attach)(struct sfp *sfp);
|
|
void (*detach)(struct sfp *sfp);
|
|
void (*start)(struct sfp *sfp);
|
|
void (*stop)(struct sfp *sfp);
|
|
void (*set_signal_rate)(struct sfp *sfp, unsigned int rate_kbd);
|
|
int (*module_info)(struct sfp *sfp, struct ethtool_modinfo *modinfo);
|
|
int (*module_eeprom)(struct sfp *sfp, struct ethtool_eeprom *ee,
|
|
u8 *data);
|
|
int (*module_eeprom_by_page)(struct sfp *sfp,
|
|
const struct ethtool_module_eeprom *page,
|
|
struct netlink_ext_ack *extack);
|
|
};
|
|
|
|
int sfp_add_phy(struct sfp_bus *bus, struct phy_device *phydev);
|
|
void sfp_remove_phy(struct sfp_bus *bus);
|
|
void sfp_link_up(struct sfp_bus *bus);
|
|
void sfp_link_down(struct sfp_bus *bus);
|
|
int sfp_module_insert(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
|
|
const struct sfp_quirk *quirk);
|
|
void sfp_module_remove(struct sfp_bus *bus);
|
|
int sfp_module_start(struct sfp_bus *bus);
|
|
void sfp_module_stop(struct sfp_bus *bus);
|
|
struct sfp_bus *sfp_register_socket(struct device *dev, struct sfp *sfp,
|
|
const struct sfp_socket_ops *ops);
|
|
void sfp_unregister_socket(struct sfp_bus *bus);
|
|
|
|
#endif
|