mirror of
https://github.com/torvalds/linux.git
synced 2026-10-07 11:06:03 +02:00
f32977deb1
do_entInt() opens with local_irq_disable(), which with
CONFIG_TRACE_IRQFLAGS only calls trace_hardirqs_off() if interrupts were
not already off:
#define local_irq_disable() \
do { \
bool was_disabled = raw_irqs_disabled();\
raw_local_irq_disable(); \
if (!was_disabled) \
trace_hardirqs_off(); \
} while (0)
On alpha raw_irqs_disabled() is (rdps() & 7) == IPL_MAX, i.e. IPL 7.
PALcode raises PS.IPL to the level of the interrupt before entInt runs,
so for an IPL 7 entry - a processor machine check (vector 0x660) or a
system event (vector 0x680), both IPL_MCHECK == IPL_MAX - the gate is
already true and the annotation is skipped. lockdep keeps whatever
hardirq state the interrupted context had. If that context had
interrupts enabled, lockdep believes they are still enabled for the
duration of the handler, and every lockdep_assert_irqs_disabled() in the
interrupt path fires:
WARNING: kernel/context_tracking.c:346 at ct_irq_enter+0xc4/0xd0, CPU#0: swapper/0/0
[...]
[<fffffc0001ef74d4>] ct_irq_enter+0xc4/0xd0
[<fffffc000105ebd0>] irq_enter+0x20/0x50
[<fffffc000103707c>] do_entInt+0x1dc/0x2e0
[<fffffc0001031d60>] ret_from_exception+0x0/0x10
irq event stamp: 735356346
hardirqs last enabled at (735356346): trace_hardirqs_on+0x68/0x220
hardirqs last disabled at (735356345): do_idle+0xf0/0x270
The stamps show the problem directly: the most recent event is the
enable from the interrupted idle loop, and do_entInt() recorded no
disable at all. ct_irq_exit() warns the same way on the way out.
Ordinary device interrupts arrive at IPL 3-5 and IPIs and performance
counter interrupts at IPL 6, so was_disabled is false for them and the
annotation happens normally. Only the two IPL 7 vectors are affected,
which is why this needs an environmental event to show up.
Take the hardware IPL out of the decision and drive the annotation from
lockdep's own state instead.
This corrects the annotation only. An IPL 7 event can also interrupt a
region that has legitimately disabled interrupts, where irq_enter() and
irq_exit() are not the right primitives and NMI semantics are needed;
that is a larger change and is left alone here.
Tested on an AlphaServer ES47 (Marvel/EV7) by injecting system events
through the system management path: fifteen injections, idle and under
load, with no splat. The same injection on a freshly booted kernel
without this change reproduces both warnings.
Signed-off-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Magnus Lindholm <linmag7@gmail.com>
Tested-by: Magnus Lindholm <linmag7@gmail.com>
Link: https://lore.kernel.org/r/20260810202835.3592833-2-mattst88@gmail.com
Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
|
||
|---|---|---|
| .. | ||
| syscalls | ||
| .gitignore | ||
| asm-offsets.c | ||
| audit.c | ||
| bugs.c | ||
| console.c | ||
| core_cia.c | ||
| core_irongate.c | ||
| core_marvel.c | ||
| core_mcpcia.c | ||
| core_polaris.c | ||
| core_t2.c | ||
| core_titan.c | ||
| core_tsunami.c | ||
| core_wildfire.c | ||
| entry.S | ||
| err_common.c | ||
| err_ev6.c | ||
| err_ev7.c | ||
| err_impl.h | ||
| err_marvel.c | ||
| err_titan.c | ||
| es1888.c | ||
| gct.c | ||
| head.S | ||
| io.c | ||
| irq_alpha.c | ||
| irq_i8259.c | ||
| irq_impl.h | ||
| irq_pyxis.c | ||
| irq_srm.c | ||
| irq.c | ||
| machvec_impl.h | ||
| Makefile | ||
| module.c | ||
| osf_sys.c | ||
| pc873xx.c | ||
| pc873xx.h | ||
| pci_impl.h | ||
| pci_iommu.c | ||
| pci-sysfs.c | ||
| pci.c | ||
| perf_event.c | ||
| process.c | ||
| proto.h | ||
| ptrace.c | ||
| rtc.c | ||
| setup.c | ||
| signal.c | ||
| smc37c93x.c | ||
| smc37c669.c | ||
| smp.c | ||
| srm_env.c | ||
| srmcons.c | ||
| stacktrace.c | ||
| sys_alcor.c | ||
| sys_cabriolet.c | ||
| sys_dp264.c | ||
| sys_eiger.c | ||
| sys_marvel.c | ||
| sys_miata.c | ||
| sys_mikasa.c | ||
| sys_nautilus.c | ||
| sys_noritake.c | ||
| sys_rawhide.c | ||
| sys_ruffian.c | ||
| sys_rx164.c | ||
| sys_sable.c | ||
| sys_sx164.c | ||
| sys_takara.c | ||
| sys_titan.c | ||
| sys_wildfire.c | ||
| systbls.S | ||
| termios.c | ||
| time.c | ||
| traps.c | ||
| vmlinux.lds.S | ||