Taehee Yoo 6546e1150c netfilter: ipt_CLUSTERIP: fix sleep-in-atomic bug in clusterip_config_entry_put() ... commit 2a61d8b883 upstream. A proc_remove() can sleep. so that it can't be inside of spin_lock. Hence proc_remove() is moved to outside of spin_lock. and it also adds mutex to sync create and remove of proc entry(config->pde). test commands: SHELL#1 %while :; do iptables -A INPUT -p udp -i enp2s0 -d 192.168.1.100 \ --dport 9000 -j CLUSTERIP --new --hashmode sourceip \ --clustermac 01:00:5e:00:00:21 --total-nodes 3 --local-node 3; \ iptables -F; done SHELL#2 %while :; do echo +1 > /proc/net/ipt_CLUSTERIP/192.168.1.100; \ echo -1 > /proc/net/ipt_CLUSTERIP/192.168.1.100; done [ 2949.569864] BUG: sleeping function called from invalid context at kernel/sched/completion.c:99 [ 2949.579944] in_atomic(): 1, irqs_disabled(): 0, pid: 5472, name: iptables [ 2949.587920] 1 lock held by iptables/5472: [ 2949.592711] #0: 000000008f0ebcf2 (&(&cn->lock)->rlock){+...}, at: refcount_dec_and_lock+0x24/0x50 [ 2949.603307] CPU: 1 PID: 5472 Comm: iptables Tainted: G W 4.19.0-rc5+ #16 [ 2949.604212] Hardware name: To be filled by O.E.M. To be filled by O.E.M./Aptio CRB, BIOS 5.6.5 07/08/2015 [ 2949.604212] Call Trace: [ 2949.604212] dump_stack+0xc9/0x16b [ 2949.604212] ? show_regs_print_info+0x5/0x5 [ 2949.604212] ___might_sleep+0x2eb/0x420 [ 2949.604212] ? set_rq_offline.part.87+0x140/0x140 [ 2949.604212] ? _rcu_barrier_trace+0x400/0x400 [ 2949.604212] wait_for_completion+0x94/0x710 [ 2949.604212] ? wait_for_completion_interruptible+0x780/0x780 [ 2949.604212] ? __kernel_text_address+0xe/0x30 [ 2949.604212] ? __lockdep_init_map+0x10e/0x5c0 [ 2949.604212] ? __lockdep_init_map+0x10e/0x5c0 [ 2949.604212] ? __init_waitqueue_head+0x86/0x130 [ 2949.604212] ? init_wait_entry+0x1a0/0x1a0 [ 2949.604212] proc_entry_rundown+0x208/0x270 [ 2949.604212] ? proc_reg_get_unmapped_area+0x370/0x370 [ 2949.604212] ? __lock_acquire+0x4500/0x4500 [ 2949.604212] ? complete+0x18/0x70 [ 2949.604212] remove_proc_subtree+0x143/0x2a0 [ 2949.708655] ? remove_proc_entry+0x390/0x390 [ 2949.708655] clusterip_tg_destroy+0x27a/0x630 [ipt_CLUSTERIP] [ ... ] Fixes: b3e456fce9 ("netfilter: ipt_CLUSTERIP: fix a race condition of proc file creation") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-02-27 10:09:03 +01:00
..
bpfilter	bpfilter: remove trailing newline	2018-07-24 14:10:42 -07:00
netfilter	netfilter: ipt_CLUSTERIP: fix sleep-in-atomic bug in clusterip_config_entry_put()	2019-02-27 10:09:03 +01:00
af_inet.c	gso_segment: Reset skb->mac_len after modifying network header	2018-09-13 12:09:32 -07:00
ah4.c
arp.c
cipso_ipv4.c	net/ipv4: defensive cipso option parsing	2018-11-13 11:08:41 -08:00
datagram.c
devinet.c	route: add support for directed broadcast forwarding	2018-07-29 12:37:06 -07:00
esp4_offload.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2018-07-27 09:33:37 -07:00
esp4.c
fib_frontend.c	net: ipv4: Fix memory leak in network namespace dismantle	2019-01-31 08:14:32 +01:00
fib_lookup.h
fib_notifier.c
fib_rules.c
fib_semantics.c	net: ipv4: update fnhe_pmtu when first hop's MTU changes	2018-10-10 22:44:46 -07:00
fib_trie.c	net: ipv4: Fix memory leak in network namespace dismantle	2019-01-31 08:14:32 +01:00
fou.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net	2018-07-03 10:29:26 +09:00
gre_demux.c	net: ip_gre: use erspan key field for tunnel lookup	2019-02-06 17:30:06 +01:00
gre_offload.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net	2018-07-03 10:29:26 +09:00
icmp.c	ipv4: ipcm_cookie initializers	2018-07-07 10:58:49 +09:00
igmp.c	igmp: fix incorrect unsolicit report count after link down and up	2018-09-02 13:39:37 -07:00
inet_connection_sock.c	inet: make sure to grab rcu_read_lock before using ireq->ireq_opt	2018-10-02 15:52:12 -07:00
inet_diag.c	inet_diag: fix reporting cgroup classid and fallback to priority	2019-02-27 10:08:58 +01:00
inet_fragment.c	inet: frags: better deal with smp races	2018-11-23 08:17:05 +01:00
inet_hashtables.c	bpf: Enable BPF_PROG_TYPE_SK_REUSEPORT bpf prog in reuseport selection	2018-08-11 01:58:46 +02:00
inet_timewait_sock.c
inetpeer.c	net: ipv4: use a dedicated counter for icmp_v4 redirect packets	2019-02-23 09:07:24 +01:00
ip_forward.c	net: clear skb->tstamp in forwarding paths	2019-01-09 17:38:31 +01:00
ip_fragment.c	Fix "net: ipv4: do not handle duplicate fragments as overlapping"	2019-02-06 17:30:05 +01:00
ip_gre.c	net: ip_gre: use erspan key field for tunnel lookup	2019-02-06 17:30:06 +01:00
ip_input.c	net: Fix usage of pskb_trim_rcsum	2019-01-31 08:14:31 +01:00
ip_options.c
ip_output.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net	2018-07-24 19:21:58 -07:00
ip_sockglue.c	ip: on queued skb use skb_header_pointer instead of pskb_may_pull	2019-01-22 21:40:31 +01:00
ip_tunnel_core.c	ip_tunnel: don't force DF when MTU is locked	2018-11-23 08:17:02 +01:00
ip_tunnel.c	ip: validate header length on virtual device xmit	2019-01-09 17:38:31 +01:00
ip_vti.c	ip: validate header length on virtual device xmit	2019-01-09 17:38:31 +01:00
ipcomp.c
ipconfig.c
ipip.c
ipmr_base.c	net: ipmr: fix unresolved entry dumps	2018-10-17 22:35:42 -07:00
ipmr.c	ipv4: Fix potential Spectre v1 vulnerability	2019-01-09 17:38:31 +01:00
Kconfig	net: remove blank lines at end of file	2018-07-24 14:10:43 -07:00
Makefile	net: remove blank lines at end of file	2018-07-24 14:10:43 -07:00
metrics.c
netfilter.c	netfilter: utils: move nf_ip_checksum* from ipv4 to utils	2018-07-16 17:51:48 +02:00
netlink.c
ping.c	net: add helpers checking if socket can be bound to nonlocal address	2018-08-01 09:50:04 -07:00
proc.c	ip: discard IPv4 datagrams with overlapping segments.	2018-08-05 17:16:46 -07:00
protocol.c
raw_diag.c
raw.c	ip: remove tx_flags from ipcm_cookie and use same logic for v4 and v6	2018-07-07 10:58:49 +09:00
route.c	net: ipv4: use a dedicated counter for icmp_v4 redirect packets	2019-02-23 09:07:24 +01:00
syncookies.c
sysctl_net_ipv4.c	net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int	2018-09-26 20:33:21 -07:00
tcp_bbr.c	tcp_bbr: apply PROBE_RTT cwnd cap even if acked==0	2018-08-22 21:45:32 -07:00
tcp_bic.c
tcp_cdg.c
tcp_cong.c
tcp_cubic.c
tcp_dctcp.c	tcp: avoid resetting ACK timer in DCTCP	2018-08-11 11:31:35 -07:00
tcp_diag.c
tcp_fastopen.c
tcp_highspeed.c
tcp_htcp.c
tcp_hybla.c
tcp_illinois.c
tcp_input.c	tcp: defer SACK compression after DupThresh	2018-12-05 19:32:00 +01:00
tcp_ipv4.c	tcp: tcp_v4_err() should be more careful	2019-02-23 09:07:26 +01:00
tcp_lp.c
tcp_metrics.c
tcp_minisocks.c	tcp: do not restart timewait timer on rst reception	2018-08-31 23:10:35 -07:00
tcp_nv.c
tcp_offload.c	tcp: Don't coalesce decrypted and encrypted SKBs	2018-07-16 00:12:09 -07:00
tcp_output.c	tcp: lack of available data can also cause TSO defer	2018-12-17 09:24:42 +01:00
tcp_rate.c	tcp: expose both send and receive intervals for rate sample	2018-07-11 23:01:56 -07:00
tcp_recovery.c	tcp: add stat of data packet reordering events	2018-08-01 09:56:10 -07:00
tcp_scalable.c
tcp_timer.c	tcp: change txhash on SYN-data timeout	2019-01-22 21:40:30 +01:00
tcp_ulp.c	tcp, ulp: fix leftover icsk_ulp_ops preventing sock from reattach	2018-08-16 14:58:08 -07:00
tcp_vegas.c
tcp_vegas.h
tcp_veno.c
tcp_westwood.c
tcp_yeah.c
tcp.c	tcp: clear icsk_backoff in tcp_write_queue_purge()	2019-02-23 09:07:26 +01:00
tunnel4.c
udp_diag.c
udp_impl.h
udp_offload.c	Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net	2018-07-03 10:29:26 +09:00
udp_tunnel.c
udp.c	udp: with udp_segment release on error path	2019-01-31 08:14:33 +01:00
udplite.c
xfrm4_input.c	xfrm: reset transport header back to network header after all input transforms ahave been applied	2018-09-04 10:26:30 +02:00
xfrm4_mode_beet.c
xfrm4_mode_transport.c	xfrm: reset transport header back to network header after all input transforms ahave been applied	2018-09-04 10:26:30 +02:00
xfrm4_mode_tunnel.c
xfrm4_output.c
xfrm4_policy.c
xfrm4_protocol.c
xfrm4_state.c
xfrm4_tunnel.c