Eric Dumazet 9bb363ba01 net_sched: add __rcu annotation to netdev->qdisc ... commit 5891cd5ec4 upstream. syzbot found a data-race [1] which lead me to add __rcu annotations to netdev->qdisc, and proper accessors to get LOCKDEP support. [1] BUG: KCSAN: data-race in dev_activate / qdisc_lookup_rcu write to 0xffff888168ad6410 of 8 bytes by task 13559 on cpu 1: attach_default_qdiscs net/sched/sch_generic.c:1167 [inline] dev_activate+0x2ed/0x8f0 net/sched/sch_generic.c:1221 __dev_open+0x2e9/0x3a0 net/core/dev.c:1416 __dev_change_flags+0x167/0x3f0 net/core/dev.c:8139 rtnl_configure_link+0xc2/0x150 net/core/rtnetlink.c:3150 __rtnl_newlink net/core/rtnetlink.c:3489 [inline] rtnl_newlink+0xf4d/0x13e0 net/core/rtnetlink.c:3529 rtnetlink_rcv_msg+0x745/0x7e0 net/core/rtnetlink.c:5594 netlink_rcv_skb+0x14e/0x250 net/netlink/af_netlink.c:2494 rtnetlink_rcv+0x18/0x20 net/core/rtnetlink.c:5612 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline] netlink_unicast+0x602/0x6d0 net/netlink/af_netlink.c:1343 netlink_sendmsg+0x728/0x850 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg net/socket.c:725 [inline] ____sys_sendmsg+0x39a/0x510 net/socket.c:2413 ___sys_sendmsg net/socket.c:2467 [inline] __sys_sendmsg+0x195/0x230 net/socket.c:2496 __do_sys_sendmsg net/socket.c:2505 [inline] __se_sys_sendmsg net/socket.c:2503 [inline] __x64_sys_sendmsg+0x42/0x50 net/socket.c:2503 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae read to 0xffff888168ad6410 of 8 bytes by task 13560 on cpu 0: qdisc_lookup_rcu+0x30/0x2e0 net/sched/sch_api.c:323 __tcf_qdisc_find+0x74/0x3a0 net/sched/cls_api.c:1050 tc_del_tfilter+0x1c7/0x1350 net/sched/cls_api.c:2211 rtnetlink_rcv_msg+0x5ba/0x7e0 net/core/rtnetlink.c:5585 netlink_rcv_skb+0x14e/0x250 net/netlink/af_netlink.c:2494 rtnetlink_rcv+0x18/0x20 net/core/rtnetlink.c:5612 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline] netlink_unicast+0x602/0x6d0 net/netlink/af_netlink.c:1343 netlink_sendmsg+0x728/0x850 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg net/socket.c:725 [inline] ____sys_sendmsg+0x39a/0x510 net/socket.c:2413 ___sys_sendmsg net/socket.c:2467 [inline] __sys_sendmsg+0x195/0x230 net/socket.c:2496 __do_sys_sendmsg net/socket.c:2505 [inline] __se_sys_sendmsg net/socket.c:2503 [inline] __x64_sys_sendmsg+0x42/0x50 net/socket.c:2503 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x44/0xd0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae value changed: 0xffffffff85dee080 -> 0xffff88815d96ec00 Reported by Kernel Concurrency Sanitizer on: CPU: 0 PID: 13560 Comm: syz-executor.2 Not tainted 5.17.0-rc3-syzkaller-00116-gf1baf68e1383-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Fixes: 470502de5b ("net: sched: unlock rules update API") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Vlad Buslov <vladbu@mellanox.com> Reported-by: syzbot <syzkaller@googlegroups.com> Cc: Jamal Hadi Salim <jhs@mojatatu.com> Cc: Cong Wang <xiyou.wangcong@gmail.com> Cc: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-02-23 12:03:12 +01:00
..
bpf_sk_storage.c	net: in_irq() cleanup	2021-08-13 14:09:19 -07:00
datagram.c	udp: fix skb_copy_and_csum_datagram with odd segment sizes	2021-02-04 18:56:56 -08:00
datagram.h
dev_addr_lists.c	net: dev_addr_list: handle first address in __hw_addr_add_ex	2021-09-30 13:29:09 +01:00
dev_ioctl.c	net: core: don't call SIOCBRADD/DELIF for non-bridge devices	2021-08-05 11:36:59 +01:00
dev.c	xdp: check prog type before updating BPF link	2022-01-27 11:05:26 +01:00
devlink.c	devlink: Remove misleading internal_flags from health reporter dump	2022-01-27 11:05:39 +01:00
drop_monitor.c	drop_monitor: fix data-race in dropmon_net_event / trace_napi_poll_hit	2022-02-23 12:03:12 +01:00
dst_cache.c	wireguard: device: reset peer src endpoint when netns exits	2021-12-08 09:04:46 +01:00
dst.c	net: Remove redundant if statements	2021-08-05 13:27:50 +01:00
failover.c
fib_notifier.c
fib_rules.c	ipv6: fix memory leak in fib6_rule_suppress	2021-12-08 09:04:43 +01:00
filter.c	bpf: Do not WARN in bpf_warn_invalid_xdp_action()	2022-01-27 11:04:41 +01:00
flow_dissector.c	net/sched: flow_dissector: Fix matching on zone id for invalid conns	2022-01-27 11:04:02 +01:00
flow_offload.c	net: Fix offloading indirect devices dependency on qdisc order creation	2021-08-19 13:19:30 +01:00
gen_estimator.c	net_sched: gen_estimator: support large ewma log	2021-01-15 18:11:06 -08:00
gen_stats.c
gro_cells.c
hwbm.c
link_watch.c	net: linkwatch: fix failure to restore device state across suspend/resume	2021-08-11 14:43:16 -07:00
lwt_bpf.c
lwtunnel.c	lwtunnel: Validate RTA_ENCAP_TYPE attribute length	2022-01-11 15:35:14 +01:00
Makefile	sock_map: Relax config dependency to CONFIG_NET	2021-07-15 18:17:49 -07:00
neighbour.c	net, neigh: clear whole pneigh_entry at alloc time	2021-12-14 10:57:19 +01:00
net_namespace.c	netns: add schedule point in ops_exit_list()	2022-01-27 11:05:35 +01:00
net-procfs.c	net-procfs: show net devices bound packet types	2022-02-01 17:27:08 +01:00
net-sysfs.c	net-sysfs: update the queue counts in the unregistration path	2022-01-27 11:04:38 +01:00
net-sysfs.h
net-traces.c	tcp: add tracepoint for checksum errors	2021-05-14 15:26:03 -07:00
netclassid_cgroup.c	bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode	2021-09-13 16:35:58 -07:00
netevent.c	net: core: Correct function name netevent_unregister_notifier() in the kerneldoc	2021-03-28 17:56:56 -07:00
netpoll.c	asm-generic/unaligned: Unify asm/unaligned.h around struct helper	2021-07-02 12:43:40 -07:00
netprio_cgroup.c	bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode	2021-09-13 16:35:58 -07:00
page_pool.c	page_pool: use relaxed atomic for release side accounting	2021-08-24 10:46:31 +01:00
pktgen.c	pktgen: remove unused variable	2021-09-03 11:48:28 +01:00
ptp_classifier.c	bpf: Refactor BPF_PROG_RUN into a function	2021-08-17 00:45:07 +02:00
request_sock.c
rtnetlink.c	net_sched: add __rcu annotation to netdev->qdisc	2022-02-23 12:03:12 +01:00
scm.c	memcg: enable accounting for scm_fp_list objects	2021-07-20 06:00:38 -07:00
secure_seq.c
selftests.c	net: selftests: add MTU test	2021-07-22 00:52:04 -07:00
skbuff.c	net: Fix double 0x prefix print in SKB dump	2021-12-22 09:32:44 +01:00
skmsg.c	bpf, sockmap: Re-evaluate proto ops when psock is removed from sockmap	2021-12-14 10:57:18 +01:00
sock_destructor.h	skb_expand_head() adjust skb->truesize incorrectly	2021-10-22 12:35:51 -07:00
sock_diag.c
sock_map.c	bpf, sockmap: Fix double bpf_prog_put on error case in map_link	2022-01-27 11:03:50 +01:00
sock_reuseport.c	tcp: Add stats for socket migration.	2021-06-23 12:56:08 -07:00
sock.c	net: fix sock_timestamping_bind_phc() to release device	2022-01-27 11:05:39 +01:00
stream.c	net: stream: don't purge sk_error_queue in sk_stream_kill_queues()	2021-11-18 19:16:34 +01:00
sysctl_net_core.c	bpf: Prevent increasing bpf_jit_limit above max	2021-10-22 17:23:53 -07:00
timestamping.c
tso.c
utils.c
xdp.c	xdp: Move the rxq_info.mem clearing to unreg_mem_model()	2021-06-28 23:07:59 +02:00