Xin Long 3067bc61fc tipc: re-fetch skb cb after tipc_msg_validate ... As the call trace shows, the original skb was freed in tipc_msg_validate(), and dereferencing the old skb cb would cause an use-after-free crash. BUG: KASAN: use-after-free in tipc_crypto_rcv_complete+0x1835/0x2240 [tipc] Call Trace: <IRQ> tipc_crypto_rcv_complete+0x1835/0x2240 [tipc] tipc_crypto_rcv+0xd32/0x1ec0 [tipc] tipc_rcv+0x744/0x1150 [tipc] ... Allocated by task 47078: kmem_cache_alloc_node+0x158/0x4d0 __alloc_skb+0x1c1/0x270 tipc_buf_acquire+0x1e/0xe0 [tipc] tipc_msg_create+0x33/0x1c0 [tipc] tipc_link_build_proto_msg+0x38a/0x2100 [tipc] tipc_link_timeout+0x8b8/0xef0 [tipc] tipc_node_timeout+0x2a1/0x960 [tipc] call_timer_fn+0x2d/0x1c0 ... Freed by task 47078: tipc_msg_validate+0x7b/0x440 [tipc] tipc_crypto_rcv_complete+0x4b5/0x2240 [tipc] tipc_crypto_rcv+0xd32/0x1ec0 [tipc] tipc_rcv+0x744/0x1150 [tipc] This patch fixes it by re-fetching the skb cb from the new allocated skb after calling tipc_msg_validate(). Fixes: fc1b6d6de2 ("tipc: introduce TIPC encryption & authentication") Reported-by: Shuang Li <shuali@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Link: https://lore.kernel.org/r/1b1cdba762915325bd8ef9a98d0276eb673df2a5.1669398403.git.lucien.xin@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2022-11-28 18:07:31 -08:00
..
addr.c
addr.h
bcast.c
bcast.h
bearer.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
bearer.h
core.c	tipc: fix use-after-free Read in tipc_named_reinit	2022-06-17 11:39:10 +01:00
core.h
crypto.c	tipc: re-fetch skb cb after tipc_msg_validate	2022-11-28 18:07:31 -08:00
crypto.h
diag.c
discover.c	tipc: check skb_linearize() return value in tipc_disc_rcv()	2022-11-21 20:50:24 -08:00
discover.h
eth_media.c
group.c
group.h
ib_media.c
Kconfig
link.c	tipc: fix incorrect order of state message data sanity check	2022-03-08 22:18:42 -08:00
link.h
Makefile
monitor.c	tipc: fix shift wrapping bug in map_get()	2022-09-02 12:26:29 +01:00
monitor.h
msg.c
msg.h
name_distr.c	net/tipc: Remove unused struct distr_queue_item	2022-09-29 18:48:32 -07:00
name_distr.h
name_table.c	tipc: cleanup unused function	2022-06-17 11:43:57 +01:00
name_table.h	tipc: cleanup unused function	2022-06-17 11:43:57 +01:00
net.c
net.h
netlink_compat.c	tipc: fix the msg->req tlv len check in tipc_nl_compat_name_table_dump_header	2022-11-07 19:53:40 -08:00
netlink.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
netlink.h
node.c	tipc: move bc link creation back to tipc_node_create	2022-06-27 11:51:56 +01:00
node.h
socket.c	treewide: use prandom_u32_max() when possible, part 1	2022-10-11 17:42:55 -06:00
socket.h
subscr.c
subscr.h
sysctl.c
topsrv.c	tipc: add an extra conn_get in tipc_conn_alloc	2022-11-21 20:45:24 -08:00
topsrv.h
trace.c
trace.h
udp_media.c
udp_media.h