Dmitry Safonov e689a87696 selftests/net/tcp-ao: Use LDLIBS instead of LDFLAGS ... The rules to link selftests are: > $(OUTPUT)/%_ipv4: %.c > $(LINK.c) $^ $(LDLIBS) -o $@ > > $(OUTPUT)/%_ipv6: %.c > $(LINK.c) -DIPV6_TEST $^ $(LDLIBS) -o $@ The intel test robot uses only selftest's Makefile, not the top linux Makefile: > make W=1 O=/tmp/kselftest -C tools/testing/selftests So, $(LINK.c) is determined by environment, rather than by kernel Makefiles. On my machine (as well as other people that ran tcp-ao selftests) GNU/Make implicit definition does use $(LDFLAGS): > [dima@Mindolluin ~]$ make -p -f/dev/null | grep '^LINK.c\>' > make: *** No targets. Stop. > LINK.c = $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_ARCH) But, according to build robot report, it's not the case for them. While I could just avoid using pre-defined $(LINK.c), it's also used by selftests/lib.mk by default. Anyways, according to GNU/Make documentation [1], I should have used $(LDLIBS) instead of $(LDFLAGS) in the first place, so let's just do it: > LDFLAGS > Extra flags to give to compilers when they are supposed to invoke > the linker, ‘ld’, such as -L. Libraries (-lfoo) should be added > to the LDLIBS variable instead. > LDLIBS > Library flags or names given to compilers when they are supposed > to invoke the linker, ‘ld’. LOADLIBES is a deprecated (but still > supported) alternative to LDLIBS. Non-library linker flags, such > as -L, should go in the LDFLAGS variable. [1]: https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html Fixes: cfbab37b3d ("selftests/net: Add TCP-AO library") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401011151.veyYTJzq-lkp@intel.com/ Signed-off-by: Dmitry Safonov <dima@arista.com> Acked-by: Paolo Abeni <pabeni@redhat.com> Link: https://lore.kernel.org/r/20240110-tcp_ao-selftests-makefile-v1-1-aa07d043f052@arista.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-01-11 16:31:04 -08:00
..
accounting
arch	- Add synthetic X86_FEATURE flags for the different AMD Zen generations	2024-01-08 15:45:31 -08:00
bootconfig
bpf	bpfilter: remove bpfilter	2024-01-04 10:23:10 -08:00
build
certs
cgroup	samples: introduce new samples subdir for cgroup	2023-12-10 16:51:54 -08:00
counter
crypto	crypto: tcrypt - add script tcrypt_speed_compare.py	2023-12-29 11:25:55 +08:00
debugging
edid
firewire
firmware
gpio
hv	hv/hv_kvp_daemon: Some small fixes for handling NM keyfiles	2023-11-10 23:27:46 +00:00
iio
include	Networking changes for 6.8.	2024-01-11 10:07:29 -08:00
kvm/kvm_stat
laptop
leds
lib	libbpf: implement __arg_ctx fallback logic	2024-01-03 21:22:49 -08:00
memory-model
mm
net/ynl	tools/net/ynl-gen-rst: Remove extra indentation from generated docs	2023-12-18 14:39:44 -08:00
objtool	Address a GCC-14 warning: there's no real bug, but indeed the calloc order doesn't match	2024-01-08 18:31:27 -08:00
pci
pcmcia
perf	lsm/stable-6.8 PR 20240105	2024-01-09 12:57:46 -08:00
power	PM: tools: Fix sleepgraph syntax error	2023-11-20 17:59:58 +01:00
rcu
scripts
spi
testing	selftests/net/tcp-ao: Use LDLIBS instead of LDFLAGS	2024-01-11 16:31:04 -08:00
thermal	tools/thermal/tmon: Fix compilation warning for wrong format	2024-01-02 09:33:19 +01:00
time
tracing
usb
verification
virtio
wmi
workqueue
Makefile