github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-10 23:53:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph
ea56536c35
linux/sound/soc/sof/intel
History
Ammar Faizi 0c307349fe ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM 
commit b7fb0ae090 upstream.

Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns
-ENOMEM because it leads to a NULL pointer dereference bug.

The dmesg says:

  [ T1387] sof-audio-pci-intel-tgl 0000:00:1f.3: error: memory alloc failed: -12
  [ T1387] BUG: kernel NULL pointer dereference, address: 0000000000000000
  [ T1387] #PF: supervisor read access in kernel mode
  [ T1387] #PF: error_code(0x0000) - not-present page
  [ T1387] PGD 0 P4D 0
  [ T1387] Oops: 0000 [#1] PREEMPT SMP NOPTI
  [ T1387] CPU: 6 PID: 1387 Comm: alsa-sink-HDA A Tainted: G        W         5.17.0-rc4-superb-owl-00055-g80d47f5de5e3
  [ T1387] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.15 09/15/2021
  [ T1387] RIP: 0010:dma_free_noncontiguous+0x37/0x80
  [ T1387] Code: [... snip ...]
  [ T1387] RSP: 0000:ffffc90002b87770 EFLAGS: 00010246
  [ T1387] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
  [ T1387] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff888101db30d0
  [ T1387] RBP: 00000000fffffff4 R08: 0000000000000000 R09: 0000000000000000
  [ T1387] R10: 0000000000000000 R11: ffffc90002b874d0 R12: 0000000000000001
  [ T1387] R13: 0000000000058000 R14: ffff888105260c68 R15: ffff888105260828
  [ T1387] FS:  00007f42e2ffd640(0000) GS:ffff888466b80000(0000) knlGS:0000000000000000
  [ T1387] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  [ T1387] CR2: 0000000000000000 CR3: 000000014acf0003 CR4: 0000000000770ee0
  [ T1387] PKRU: 55555554
  [ T1387] Call Trace:
  [ T1387]  <TASK>
  [ T1387]  cl_stream_prepare+0x10a/0x120 [snd_sof_intel_hda_common 146addf995b9279ae7f509621078cccbe4f875e1]
  [... snip ...]
  [ T1387]  </TASK>

Cc: Daniel Baluta <daniel.baluta@nxp.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Keyon Jie <yang.jie@linux.intel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Rander Wang <rander.wang@intel.com>
Cc: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: sound-open-firmware@alsa-project.org
Cc: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v5.2+
Fixes: d16046ffa6 ("ASoC: SOF: Intel: Add Intel specific HDA firmware loader")
Link: https://lore.kernel.org/lkml/20220224145124.15985-1-ammarfaizi2@gnuweeb.org/ # v1
Link: https://lore.kernel.org/lkml/20220224180850.34592-1-ammarfaizi2@gnuweeb.org/ # v2
Link: https://lore.kernel.org/lkml/20220224182818.40301-1-ammarfaizi2@gnuweeb.org/ # v3
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Link: https://lore.kernel.org/r/20220224185836.44907-1-ammarfaizi2@gnuweeb.org
Signed-off-by: Mark Brown <broonie@kernel.org>
[ammarfaizi2: Backport to Linux 5.10 LTS]
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-08 14:40:39 +02:00
..
apl.c ASoC: SOF: Intel: remove the HDA_DSP_CORE_MASK() macro 2020-09-11 15:29:31 +01:00
bdw.c ASoC: SOF: rename cores_mask to host_managed_cores_mask 2020-09-11 15:29:29 +01:00
byt.c ASoC: SOF: rename cores_mask to host_managed_cores_mask 2020-09-11 15:29:29 +01:00
cnl.c ASoC: SOF: Intel: remove the HDA_DSP_CORE_MASK() macro 2020-09-11 15:29:31 +01:00
hda-bus.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda-codec.c ASoC: SOF: Intel: hda: Resume codec to do jack detection 2021-02-07 15:37:14 +01:00
hda-compress.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda-ctrl.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda-dai.c ASoC: SOF: Intel: hda-dai: fix potential locking issue 2021-11-26 10:39:09 +01:00
hda-dsp.c ASoC: SOF: Intel: HDA: fix core status verification 2021-04-14 08:42:06 +02:00
hda-ipc.c ASoC: SOF: Intel: hda-ipc: fix reply size checking 2021-08-18 08:59:08 +02:00
hda-ipc.h ASoC: SOF: Intel: hda: Add sof_tgl_ops for TGL platforms 2020-08-27 14:22:23 +01:00
hda-loader.c ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM 2022-04-08 14:40:39 +02:00
hda-pcm.c ASoC: sof: use asoc_substream_to_rtd() 2020-07-23 19:07:24 +01:00
hda-stream.c ASoC: SOF: Intel: hda: Add helper function to program ICCMAX stream 2020-08-27 14:22:19 +01:00
hda-trace.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda.c ASoC: SOF: Intel: unregister DMIC device on probe error 2021-03-25 09:04:06 +01:00
hda.h Merge series "ASoC: SOF: small fixes for 5.10" from Kai Vehmanen <kai.vehmanen@linux.intel.com>: 2020-09-17 17:40:15 +01:00
intel-ipc.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
Kconfig ASoC: SOF: Intel: broadwell: fix mutual exclusion with catpt driver 2021-03-11 14:17:21 +01:00
Makefile ASoC: SOF: Intel: hda: Add sof_tgl_ops for TGL platforms 2020-08-27 14:22:23 +01:00
shim.h ASoC: SOF: rename cores_mask to host_managed_cores_mask 2020-09-11 15:29:29 +01:00
tgl.c ASoC: SOF: Intel: Add support for tgl-h 2020-09-17 17:40:09 +01:00