mirror of
https://github.com/torvalds/linux.git
synced 2026-08-02 05:12:01 +02:00
Linux kernel source tree
e876a0367c
Magnus Karlsson says:
====================
This patch set facilitates adding new tests as well as describing
existing ones in the xsk selftests suite and adds 3 new test suites at
the end. The idea is to isolate the run-time that executes the test
from the actual implementation of the test. Today, implementing a test
amounts to adding test specific if-statements all around the run-time,
which is not scalable or amenable for reuse. This patch set instead
introduces a test specification that is the only thing that a test
fills in. The run-time then gets this specification and acts upon it
completely unaware of what test it is executing. This way, we can get
rid of all test specific if-statements from the run-time and the
implementation of the test can be contained in a single function. This
hopefully makes it easier to add tests and for users to understand
what the test accomplishes.
As a recap of what the run-time does: each test is based on the
run-time launching two threads and connecting a veth link between the
two threads. Each thread opens an AF_XDP socket on that veth interface
and one of them sends traffic that the other one receives and
validates. Each thread has its own umem. Note that this behavior is
not changed by this patch set.
A test specification consists of several items. Most importantly:
* Two packet streams. One for Tx thread that specifies what traffic to
send and one for the Rx thread that specifies what that thread
should receive. If it receives exactly what is specified, the test
passes, otherwise it fails. A packet stream can also specify what
buffers in the umem that should be used by the Rx and Tx threads.
* What kind of AF_XDP sockets it should create and bind to what
interfaces
* How many times it should repeat the socket creation and destruction
* The name of the test
The interface for the test spec is the following:
void test_spec_init(struct test_spec *test, struct ifobject *ifobj_tx,
struct ifobject *ifobj_rx, enum test_mode mode);
/* Reset everything but the interface specifications and the mode */
void test_spec_reset(struct test_spec *test);
void test_spec_set_name(struct test_spec *test, const char *name);
Packet streams have the following interfaces:
struct pkt *pkt_stream_get_pkt(struct pkt_stream *pkt_stream, u32 pkt_nb)
struct pkt *pkt_stream_get_next_rx_pkt(struct pkt_stream *pkt_stream)
struct pkt_stream *pkt_stream_generate(struct xsk_umem_info *umem,
u32 nb_pkts, u32 pkt_len);
void pkt_stream_delete(struct pkt_stream *pkt_stream);
struct pkt_stream *pkt_stream_clone(struct xsk_umem_info *umem,
struct pkt_stream *pkt_stream);
/* Replaces all packets in the stream*/
void pkt_stream_replace(struct test_spec *test, u32 nb_pkts, u32 pkt_len);
/* Replaces every other packet in the stream */
void pkt_stream_replace_half(struct test_spec *test, u32 pkt_len, u32 offset);
/* For creating custom made packet streams */
void pkt_stream_generate_custom(struct test_spec *test, struct pkt *pkts,
u32 nb_pkts);
/* Restores the default packet stream */
void pkt_stream_restore_default(struct test_spec *test);
A test can then then in the most basic case described like this
(provided the test specification has been created before calling the
function):
static bool testapp_aligned(struct test_spec *test)
{
test_spec_set_name(test, "RUN_TO_COMPLETION");
testapp_validate_traffic(test);
}
Running the same test in unaligned mode would then look like this:
static bool testapp_unaligned(struct test_spec *test)
{
if (!hugepages_present(test->ifobj_tx)) {
ksft_test_result_skip("No 2M huge pages present.\n");
return false;
}
test_spec_set_name(test, "UNALIGNED_MODE");
test->ifobj_tx->umem->unaligned_mode = true;
test->ifobj_rx->umem->unaligned_mode = true;
/* Let half of the packets straddle a buffer boundrary */
pkt_stream_replace_half(test, PKT_SIZE,
XSK_UMEM__DEFAULT_FRAME_SIZE - 32);
/* Populate fill ring with addresses in the packet stream */
test->ifobj_rx->pkt_stream->use_addr_for_fill = true;
testapp_validate_traffic(test);
pkt_stream_restore_default(test);
return true;
}
3 of the last 4 patches in the set add 3 new test suites, one for
unaligned mode, one for testing the rejection of tricky invalid
descriptors plus the acceptance of some valid ones in the Tx ring, and
one for testing 2K frame sizes (the default is 4K).
What is left to do for follow-up patches:
* Convert the statistics tests to the new framework.
* Implement a way of registering new tests without having the enum
test_type. Once this has been done (together with the previous
bullet), all the test types can be dropped from the header
file. This means that we should be able to add tests by just writing
a single function with a new test specification, which is one of the
goals.
* Introduce functions for manipulating parts of the test or interface
spec instead of direct manipulations such as
test->ifobj_rx->pkt_stream->use_addr_for_fill = true; which is kind
of awkward.
* Move the run-time and its interface to its own .c and .h files. Then
we can have all the tests in a separate file.
* Better error reporting if a test fails. Today it does not state what
test fails and might not continue execute the rest of the tests due
to this failure. Failures are not propagated upwards through the
functions so a failed test will also be a passed test, which messes
up the stats counting. This needs to be changed.
* Add option to run specific test instead of all of them
* Introduce pacing of sent packets so that they are never dropped
by the receiver even if it is stalled for some reason. If you run
the current tests on a heavily loaded system, they might fail in SKB
mode due to packets being dropped by the driver on Tx. Though I have
never seen it, it might happen.
v1 -> v2:
* Fixed a number of spelling errors [Maciej]
* Fixed use after free bug in pkt_stream_replace() [Maciej]
* pkt_stream_set -> pkt_stream_generate_custom [Maciej]
* Fixed formatting problem in testapp_invalid_desc() [Maciej]
====================
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
|
||
|---|---|---|
| arch | ||
| block | ||
| certs | ||
| crypto | ||
| Documentation | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| LICENSES | ||
| mm | ||
| net | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| tools | ||
| usr | ||
| virt | ||
| .clang-format | ||
| .cocciconfig | ||
| .get_maintainer.ignore | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| COPYING | ||
| CREDITS | ||
| Kbuild | ||
| Kconfig | ||
| MAINTAINERS | ||
| Makefile | ||
| README | ||
Linux kernel
============
There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.
In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``. The formatted documentation can also be read online at:
https://www.kernel.org/doc/html/latest/
There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.