mirror of
https://github.com/torvalds/linux.git
synced 2026-05-31 18:43:33 +02:00
e81a492d12
smu7_hwmgr_backend_init() is responsible for initializing the SMU7 power
management backend. It allocates and sets up the backend structure,
initializes voltage tables, configures dependency tables, and prepares
platform-specific power and clock parameters.
The function follows a typical pattern where each initialization step
returns a status in "result", and failures are handled via a common
"goto fail" path that performs cleanup.
Commit 2c21648bb814 ("drm/amd/pm/smu7: Remove non-functional SMU7
voltage dependency on DAL") removed a function call in this
initialization sequence, but left behind the corresponding error check.
As a result, "result" is checked twice without being updated in between:
result = smu7_init_voltage_dependency_on_display_clock_table(hwmgr);
if (result)
goto fail;
...
if (result)
goto fail;
The second check is redundant and unreachable for any new failure, since
no operation modifies "result" between the two checks. This triggers a
Smatch warning about a duplicate zero check and reduces code clarity.
Remove the stale error check to keep the control flow correct and
readable.
Fixes:
|
||
|---|---|---|
| .. | ||
| inc | ||
| legacy-dpm | ||
| powerplay | ||
| swsmu | ||
| amdgpu_dpm_internal.c | ||
| amdgpu_dpm.c | ||
| amdgpu_pm.c | ||
| Makefile | ||