Sui Jingfeng 36672dda2e drm/loongson: Remove a useless check in cursor_plane_atomic_async_check() ... Because smatch warnings: drivers/gpu/drm/loongson/lsdc_plane.c:199 lsdc_cursor_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 180) vim +/state +199 drivers/gpu/drm/loongson/lsdc_plane.c 174 static int lsdc_cursor_plane_atomic_async_check(struct drm_plane *plane, 175 struct drm_atomic_state *state) 176 { 177 struct drm_plane_state *new_state; 178 struct drm_crtc_state *crtc_state; 179 180 new_state = drm_atomic_get_new_plane_state(state, plane); ^^^^^ state is dereferenced inside this function 181 182 if (!plane->state || !plane->state->fb) { 183 drm_dbg(plane->dev, "%s: state is NULL\n", plane->name); 184 return -EINVAL; 185 } 186 187 if (new_state->crtc_w != new_state->crtc_h) { 188 drm_dbg(plane->dev, "unsupported cursor size: %ux%u\n", 189 new_state->crtc_w, new_state->crtc_h); 190 return -EINVAL; 191 } 192 193 if (new_state->crtc_w != 64 && new_state->crtc_w != 32) { 194 drm_dbg(plane->dev, "unsupported cursor size: %ux%u\n", 195 new_state->crtc_w, new_state->crtc_h); 196 return -EINVAL; 197 } 198 199 if (state) { ^^^^^ Checked too late! Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202307100423.rV7D05Uq-lkp@intel.com/ Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> Link: https://patchwork.freedesktop.org/patch/msgid/20230710102411.257970-1-suijingfeng@loongson.cn		2023-07-13 01:24:42 +08:00
..
Kconfig
loongson_device.c
loongson_module.c
loongson_module.h
lsdc_benchmark.c
lsdc_benchmark.h
lsdc_crtc.c
lsdc_debugfs.c
lsdc_drv.c
lsdc_drv.h
lsdc_gem.c
lsdc_gem.h
lsdc_gfxpll.c
lsdc_gfxpll.h
lsdc_i2c.c
lsdc_i2c.h
lsdc_irq.c
lsdc_irq.h
lsdc_output_7a1000.c
lsdc_output_7a2000.c
lsdc_output.h
lsdc_pixpll.c
lsdc_pixpll.h
lsdc_plane.c
lsdc_probe.c
lsdc_probe.h
lsdc_regs.h
lsdc_ttm.c
lsdc_ttm.h
Makefile