mirror of
https://github.com/torvalds/linux.git
synced 2026-06-29 09:35:47 +02:00
b282b6f8a8
Compiling the kernel with CONFIG_HOTPLUG = y and CONFIG_HOTPLUG_CPU = n with CONFIG_RELOCATABLE = y generates the following modpost warnings WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between '_cpu_up' (at offset 0xc0141b7d) and 'cpu_up' WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between '_cpu_up' (at offset 0xc0141b9c) and 'cpu_up' WARNING: vmlinux - Section mismatch: reference to .init.text:__cpu_up from .text between '_cpu_up' (at offset 0xc0141bd8) and 'cpu_up' WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between '_cpu_up' (at offset 0xc0141c05) and 'cpu_up' WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between '_cpu_up' (at offset 0xc0141c26) and 'cpu_up' WARNING: vmlinux - Section mismatch: reference to .init.data: from .text between '_cpu_up' (at offset 0xc0141c37) and 'cpu_up' This is because cpu_up, _cpu_up and __cpu_up (in some architectures) are defined as __devinit AND __cpu_up calls some __cpuinit functions. Since __cpuinit would map to __init with this kind of a configuration, we get a .text refering .init.data warning. This patch solves the problem by converting all of __cpu_up, _cpu_up and cpu_up from __devinit to __cpuinit. The approach is justified since the callers of cpu_up are either dependent on CONFIG_HOTPLUG_CPU or are of __init type. Thus when CONFIG_HOTPLUG_CPU=y, all these cpu up functions would land up in .text section, and when CONFIG_HOTPLUG_CPU=n, all these functions would land up in .init section. Tested on a i386 SMP machine running linux-2.6.20-rc3-mm1. Signed-off-by: Gautham R Shenoy <ego@in.ibm.com> Cc: Vivek Goyal <vgoyal@in.ibm.com> Cc: Mikael Starvik <starvik@axis.com> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Kyle McMartin <kyle@mcmartin.ca> Cc: Paul Mackerras <paulus@samba.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: "David S. Miller" <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> |
||
|---|---|---|
| .. | ||
| apm.c | ||
| asm-offsets.c | ||
| binfmt_elfn32.c | ||
| binfmt_elfo32.c | ||
| branch.c | ||
| cpu-bugs64.c | ||
| cpu-probe.c | ||
| entry.S | ||
| gdb-low.S | ||
| gdb-stub.c | ||
| genex.S | ||
| head.S | ||
| i8253.c | ||
| i8259.c | ||
| init_task.c | ||
| irix5sys.S | ||
| irixelf.c | ||
| irixinv.c | ||
| irixioctl.c | ||
| irixsig.c | ||
| irq_cpu.c | ||
| irq-msc01.c | ||
| irq-mv6434x.c | ||
| irq-rm7000.c | ||
| irq-rm9000.c | ||
| irq.c | ||
| kspd.c | ||
| linux32.c | ||
| machine_kexec.c | ||
| Makefile | ||
| mips_ksyms.c | ||
| mips-mt.c | ||
| module.c | ||
| proc.c | ||
| process.c | ||
| ptrace.c | ||
| ptrace32.c | ||
| r4k_fpu.S | ||
| r4k_switch.S | ||
| r2300_fpu.S | ||
| r2300_switch.S | ||
| r6000_fpu.S | ||
| relocate_kernel.S | ||
| reset.c | ||
| rtlx.c | ||
| scall32-o32.S | ||
| scall64-64.S | ||
| scall64-n32.S | ||
| scall64-o32.S | ||
| semaphore.c | ||
| setup.c | ||
| signal_n32.c | ||
| signal-common.h | ||
| signal.c | ||
| signal32.c | ||
| smp-mt.c | ||
| smp.c | ||
| smtc-asm.S | ||
| smtc-proc.c | ||
| smtc.c | ||
| stacktrace.c | ||
| syscall.c | ||
| sysirix.c | ||
| time.c | ||
| topology.c | ||
| traps.c | ||
| unaligned.c | ||
| vmlinux.lds.S | ||
| vpe.c | ||