linux

mirror of https://github.com/torvalds/linux.git synced 2026-07-28 01:55:51 +02:00

Linux kernel source tree

Go to file

Hans de Goede e4efa515d5 wifi: brcmfmac: Fix SDIO suspend/resume regression After commit `92cadedd9d` ("brcmfmac: Avoid keeping power to SDIO card unless WOWL is used"), the wifi adapter by default is turned off on suspend and then re-probed on resume. In at least 2 model x86/acpi tablets with brcmfmac43430a1 wifi adapters, the newly added re-probe on resume fails like this: brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout ieee80211 phy1: brcmf_bus_started: failed: -110 ieee80211 phy1: brcmf_attach: dongle is not responding: err=-110 brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed It seems this specific brcmfmac model does not like being reprobed without it actually being turned off first. And the adapter is not being turned off during suspend because of commit `f0992ace68` ("brcmfmac: prohibit ACPI power management for brcmfmac driver"). Now that the driver is being reprobed on resume, the disabling of ACPI pm is no longer necessary, except when WOWL is used (in which case there is no-reprobe). Move the dis-/en-abling of ACPI pm to brcmf_sdio_wowl_config(), this fixes the brcmfmac43430a1 suspend/resume regression and should help save some power when suspended. This change means that the code now also may re-enable ACPI pm when WOWL gets disabled. ACPI pm should only be re-enabled if it was enabled by the ACPI core originally. Add a brcmf_sdiod_acpi_save_power_manageable() to save the original state for this. This has been tested on the following devices: Asus T100TA brcmfmac43241b4-sdio Acer Iconia One 7 B1-750 brcmfmac43340-sdio Chuwi Hi8 brcmfmac43430a0-sdio Chuwi Hi8 brcmfmac43430a1-sdio (the Asus T100TA is the device for which the prohibiting of ACPI pm was originally added) Fixes: `92cadedd9d` ("brcmfmac: Avoid keeping power to SDIO card unless WOWL is used") Cc: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20230320122252.240070-1-hdegoede@redhat.com		2023-03-31 18:00:34 +03:00
arch	Networking fixes for 6.3-rc2, including fixes from netfilter, bpf	2023-03-09 10:56:58 -08:00
block	block-6.3-2023-03-03	2023-03-03 10:21:39 -08:00
certs	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
crypto	Networking changes for 6.3.	2023-02-21 18:24:12 -08:00
Documentation	Networking fixes for 6.3-rc2, including fixes from netfilter, bpf	2023-03-09 10:56:58 -08:00
drivers	wifi: brcmfmac: Fix SDIO suspend/resume regression	2023-03-31 18:00:34 +03:00
fs	udf: Warn if block mapping is done for in-ICB files	2023-03-06 16:38:25 +01:00
include	Networking fixes for 6.3-rc2, including fixes from netfilter, bpf	2023-03-09 10:56:58 -08:00
init	Kbuild updates for v6.3	2023-02-26 11:53:25 -08:00
io_uring	io_uring-6.3-2023-03-03	2023-03-03 10:25:29 -08:00
ipc	Merge branch 'work.namespace' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2023-02-24 19:20:07 -08:00
kernel	Networking fixes for 6.3-rc2, including fixes from netfilter, bpf	2023-03-09 10:56:58 -08:00
lib	cpumask: re-introduce constant-sized cpumask optimizations	2023-03-05 14:30:34 -08:00
LICENSES	LICENSES: Add the copyleft-next-0.3.1 license	2022-11-08 15:44:01 +01:00
mm	mm: avoid gcc complaint about pointer casting	2023-03-04 14:03:27 -08:00
net	wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for non-uploaded sta	2023-03-30 11:19:53 +02:00
rust	Rust fixes for 6.3-rc1	2023-03-03 14:51:15 -08:00
samples	LoongArch changes for v6.3	2023-03-01 09:27:00 -08:00
scripts	Remove Intel compiler support	2023-03-05 10:49:37 -08:00
security	capability: just use a 'u64' instead of a 'u32[2]' array	2023-03-01 10:01:22 -08:00
sound	sound fixes for 6.3-rc1	2023-03-04 10:53:59 -08:00
tools	Networking fixes for 6.3-rc2, including fixes from netfilter, bpf	2023-03-09 10:56:58 -08:00
usr	usr/gen_init_cpio.c: remove unnecessary -1 values from int file	2022-10-03 14:21:44 -07:00
virt	KVM/riscv changes for 6.3	2023-02-15 12:33:28 -05:00
.clang-format	cpumask: re-introduce constant-sized cpumask optimizations	2023-03-05 14:30:34 -08:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.get_maintainer.ignore	get_maintainer: add Alan to .get_maintainer.ignore	2022-08-20 15:17:44 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for *.dtso files	2023-02-26 15:28:23 +09:00
.gitignore	.gitignore: ignore .cover and .mbx	2023-02-05 18:51:22 +09:00
.mailmap	Networking fixes for 6.3-rc2, including fixes from netfilter, bpf	2023-03-09 10:56:58 -08:00
.rustfmt.toml	rust: add `.rustfmt.toml`	2022-09-28 09:02:20 +02:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	There is no particular theme here - mainly quick hits all over the tree.	2023-02-23 17:55:40 -08:00
Kbuild	Kbuild updates for v6.1	2022-10-10 12:00:45 -07:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	Adding Christian Brauner as VFS co-maintainer.	2023-03-05 11:11:52 -08:00
Makefile	Linux 6.3-rc1	2023-03-05 14:52:03 -08:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.