Niels Dossche 51454ea42c ipv6: fix locking issues with loops over idev->addr_list ... idev->addr_list needs to be protected by idev->lock. However, it is not always possible to do so while iterating and performing actions on inet6_ifaddr instances. For example, multiple functions (like addrconf_{join,leave}_anycast) eventually call down to other functions that acquire the idev->lock. The current code temporarily unlocked the idev->lock during the loops, which can cause race conditions. Moving the locks up is also not an appropriate solution as the ordering of lock acquisition will be inconsistent with for example mc_lock. This solution adds an additional field to inet6_ifaddr that is used to temporarily add the instances to a temporary list while holding idev->lock. The temporary list can then be traversed without holding idev->lock. This change was done in two places. In addrconf_ifdown, the list_for_each_entry_safe variant of the list loop is also no longer necessary as there is no deletion within that specific loop. Suggested-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Niels Dossche <dossche.niels@gmail.com> Acked-by: Paolo Abeni <pabeni@redhat.com> Link: https://lore.kernel.org/r/20220403231523.45843-1-dossche.niels@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2022-04-06 22:09:39 -07:00
..
ila	net: ipv6: check return value of rhashtable_init	2021-09-28 12:59:24 +01:00
netfilter	netfilter: nft_fib: add reduce support	2022-03-20 00:29:47 +01:00
addrconf_core.c	ipv6: add net device refcount tracker to struct inet6_dev	2021-12-06 16:05:11 -08:00
addrconf.c	ipv6: fix locking issues with loops over idev->addr_list	2022-04-06 22:09:39 -07:00
addrlabel.c	ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init	2020-11-25 11:20:16 -08:00
af_inet6.c	ipv6: annotate some data-races around sk->sk_prot	2022-02-18 11:53:28 +00:00
ah6.c	ipv6: ah6: use swap() to make code cleaner	2021-11-18 12:00:15 +00:00
anycast.c
calipso.c	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-04 15:26:57 -08:00
datagram.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2020-11-23 18:36:21 -05:00
esp6_offload.c	net: Fix esp GSO on inter address family tunnels.	2022-03-07 13:14:04 +01:00
esp6.c	esp6: fix check on ipv6_skip_exthdr's return value	2022-03-14 11:42:27 +01:00
exthdrs_core.c
exthdrs_offload.c
exthdrs.c	ipv6: partially inline ipv6_fixup_options	2022-01-27 19:46:11 -08:00
fib6_notifier.c
fib6_rules.c	ipv6: change fib6_rules_net_exit() to batch mode	2022-02-08 20:41:34 -08:00
fou6.c
icmp.c	ipv6: do not use per netns icmp sockets	2022-01-25 11:25:21 +00:00
inet6_connection_sock.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2020-11-23 18:36:21 -05:00
inet6_hashtables.c	tcp: Don't acquire inet_listen_hashbucket::lock with disabled BH.	2022-02-09 21:28:36 -08:00
ioam6_iptunnel.c	ipv6: ioam: Insertion frequency in lwtunnel output	2022-02-04 20:24:45 -08:00
ioam6.c	net: ipv6: Get rcv timestamp if needed when handling hop-by-hop IOAM option	2022-03-03 14:38:48 +00:00
ip6_checksum.c
ip6_fib.c	ipv6: annotate accesses to fn->fn_sernum	2022-01-20 20:18:37 -08:00
ip6_flowlabel.c	ipv6: per-netns exclusive flowlabel checks	2022-02-16 20:37:47 -08:00
ip6_gre.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-01-09 17:00:17 -08:00
ip6_icmp.c	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-02-23 11:29:52 -08:00
ip6_input.c	net: Postpone skb_clear_delivery_time() until knowing the skb is delivered locally	2022-03-03 14:38:48 +00:00
ip6_offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-02-24 17:54:25 -08:00
ip6_offload.h
ip6_output.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-03-17 13:56:58 -07:00
ip6_tunnel.c	ip6_tunnel: Remove duplicate assignments	2022-04-06 15:31:15 +01:00
ip6_udp_tunnel.c
ip6_vti.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2021-12-30 12:12:12 -08:00
ip6mr.c	net: ip6mr: add support for passing full packet on wrong mif	2022-02-19 16:05:54 +00:00
ipcomp6.c	xfrm: remove hdr_offset indirection	2021-06-11 14:48:50 +02:00
ipv6_sockglue.c	ipv6: annotate some data-races around sk->sk_prot	2022-02-18 11:53:28 +00:00
Kconfig	ipv6: ioam: Add support for the ip6ip6 encapsulation	2021-10-04 12:53:35 +01:00
Makefile	net: ipv6: use ipv6-y directly instead of ipv6-objs	2021-09-28 13:13:40 +01:00
mcast_snoop.c	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-04-27 14:02:06 -07:00
mcast.c	ipv6: fix skb drops in igmp6_event_query() and igmp6_event_report()	2022-03-03 09:47:06 -08:00
mip6.c	xfrm: ipv6: move mip6_rthdr_offset into xfrm core	2021-06-11 14:48:50 +02:00
ndisc.c	ipv6: separate ndisc_ns_create() from ndisc_send_ns()	2022-02-21 12:13:45 +00:00
netfilter.c	net: Add skb->mono_delivery_time to distinguish mono delivery_time from (rcv) timestamp	2022-03-03 14:38:48 +00:00
output_core.c	ipv6: use prandom_u32() for ID generation	2021-05-31 22:12:08 -07:00
ping.c	net: ping6: support setting basic SOL_IPV6 options via cmsg	2022-02-17 14:22:09 +00:00
proc.c	net: udp: introduce UDP_MIB_MEMERRORS for udp_mem	2020-11-09 15:34:44 -08:00
protocol.c
raw.c	net: remove noblock parameter from skb_recv_datagram()	2022-04-06 13:45:26 +01:00
reassembly.c	net: ipv6: Handle delivery_time in ipv6 defrag	2022-03-03 14:38:48 +00:00
route.c	net: Add l3mdev index to flow struct and avoid oif reset for port devices	2022-03-15 20:20:02 -07:00
rpl_iptunnel.c	net: ipv6: rpl_iptunnel: simplify the return expression of rpl_do_srh()	2020-12-08 16:22:54 -08:00
rpl.c	net: ipv6: rpl*: Fix strange kerneldoc warnings due to bad header	2020-10-30 12:12:52 -07:00
seg6_hmac.c	net: ipv6: check return value of rhashtable_init	2021-09-28 12:59:24 +01:00
seg6_iptunnel.c	seg6: fix the iif in the IPv6 socket control block	2021-12-09 07:55:42 -08:00
seg6_local.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-01-05 14:36:10 -08:00
seg6.c	icmp: ICMPV6: Examine invoking packet for Segment Route Headers.	2022-01-04 12:17:35 +00:00
sit.c	sit: allow encapsulated IPv6 traffic to be delivered locally	2022-01-12 13:56:07 -08:00
syncookies.c	net: align static siphash keys	2021-11-16 19:07:54 -08:00
sysctl_net_ipv6.c	ipv6: ioam: Data plane support for Pre-allocated Trace	2021-07-21 08:14:33 -07:00
tcp_ipv6.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcpv6_offload.c	net: move gro definitions to include/net/gro.h	2021-11-16 13:16:54 +00:00
tunnel6.c
udp_impl.h
udp_offload.c	gro: remove rcu_read_lock/rcu_read_unlock from gro_receive handlers	2021-11-24 17:21:42 -08:00
udp.c	ipv6: Add reasons for skb drops to __udp6_lib_rcv	2022-02-14 11:24:39 +00:00
udplite.c
xfrm6_input.c
xfrm6_output.c	xfrm: fix tunnel model fragmentation behavior	2022-03-01 12:08:40 +01:00
xfrm6_policy.c	net: Add l3mdev index to flow struct and avoid oif reset for port devices	2022-03-15 20:20:02 -07:00
xfrm6_protocol.c
xfrm6_state.c
xfrm6_tunnel.c	xfrm: remove description from xfrm_type struct	2021-06-09 09:38:52 +02:00