github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 14:04:54 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph
e3ffe7387c
linux/drivers/nfc
History
Duoming Zhou d015f6f694 NFC: hci: fix sleep in atomic context bugs in nfc_hci_hcp_message_tx 
[ Upstream commit b413b0cb00 ]

There are sleep in atomic context bugs when the request to secure
element of st21nfca is timeout. The root cause is that kzalloc and
alloc_skb with GFP_KERNEL parameter and mutex_lock are called in
st21nfca_se_wt_timeout which is a timer handler. The call tree shows
the execution paths that could lead to bugs:

   (Interrupt context)
st21nfca_se_wt_timeout
  nfc_hci_send_event
    nfc_hci_hcp_message_tx
      kzalloc(..., GFP_KERNEL) //may sleep
      alloc_skb(..., GFP_KERNEL) //may sleep
      mutex_lock() //may sleep

This patch moves the operations that may sleep into a work item.
The work item will run in another kernel thread which is in
process context to execute the bottom half of the interrupt.
So it could prevent atomic context from sleeping.

Fixes: 2130fb97fe ("NFC: st21nfca: Adding support for secure element")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220518115733.62111-1-duoming@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-06-09 10:21:11 +02:00
..
fdp treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
microread treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
nfcmrvl nfc: nfcmrvl: main: reorder destructive operations in nfcmrvl_nci_unregister_dev to avoid bugs 2022-05-12 12:25:36 +02:00
nxp-nci treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
pn533 nfc: pn533: Fix buggy cleanup order 2022-06-06 08:42:40 +02:00
pn544 treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
s3fwrn5 nfc: s3fwrn5: Release the nfc firmware 2020-12-30 11:53:53 +01:00
st-nci nfc: st-nci: Remove unnecessary cast 2020-08-20 16:17:45 -07:00
st21nfca NFC: hci: fix sleep in atomic context bugs in nfc_hci_hcp_message_tx 2022-06-09 10:21:11 +02:00
st95hf NFC: st95hf: Fix memleak in st95hf_in_send_cmd 2020-08-24 17:34:25 -07:00
Kconfig
Makefile
mei_phy.c
mei_phy.h
nfcsim.c nfc: nfcsim: fix use after free during module unload 2021-08-04 12:46:41 +02:00
port100.c NFC: port100: fix use-after-free in port100_send_complete 2022-03-16 14:15:59 +01:00
trf7970a.c nfc: remove unneeded break 2020-10-20 10:36:41 -07:00