Eric Dumazet 9653359eb6 tcp/dccp: fix another race at listener dismantle ... [ Upstream commit 7716682cc5 ] Ilya reported following lockdep splat: kernel: ========================= kernel: [ BUG: held lock freed! ] kernel: 4.5.0-rc1-ceph-00026-g5e0a311 #1 Not tainted kernel: ------------------------- kernel: swapper/5/0 is freeing memory ffff880035c9d200-ffff880035c9dbff, with a lock still held there! kernel: (&(&queue->rskq_lock)->rlock){+.-...}, at: [<ffffffff816f6a88>] inet_csk_reqsk_queue_add+0x28/0xa0 kernel: 4 locks held by swapper/5/0: kernel: #0: (rcu_read_lock){......}, at: [<ffffffff8169ef6b>] netif_receive_skb_internal+0x4b/0x1f0 kernel: #1: (rcu_read_lock){......}, at: [<ffffffff816e977f>] ip_local_deliver_finish+0x3f/0x380 kernel: #2: (slock-AF_INET){+.-...}, at: [<ffffffff81685ffb>] sk_clone_lock+0x19b/0x440 kernel: #3: (&(&queue->rskq_lock)->rlock){+.-...}, at: [<ffffffff816f6a88>] inet_csk_reqsk_queue_add+0x28/0xa0 To properly fix this issue, inet_csk_reqsk_queue_add() needs to return to its callers if the child as been queued into accept queue. We also need to make sure listener is still there before calling sk->sk_data_ready(), by holding a reference on it, since the reference carried by the child can disappear as soon as the child is put on accept queue. Reported-by: Ilya Dryomov <idryomov@gmail.com> Fixes: ebb516af60 ("tcp/dccp: fix race at listener dismantle phase") Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2016-03-03 15:07:07 -08:00
..
9p
bluetooth	Bluetooth: L2CAP: Fix returning correct LE CoC response codes	2015-11-05 04:04:00 +01:00
caif
irda
iucv
netfilter	netfilter: nf_tables: add clone interface to expression operations	2015-11-10 23:47:32 +01:00
netns	Revert "ipv4/icmp: redirect messages can use the ingress daddr as source"	2015-10-14 06:01:07 -07:00
nfc	NFC: nci: non-static functions can not be inline	2015-10-28 06:44:45 +01:00
phonet
sctp	sctp: start t5 timer only when peer rwnd is 0 and local state is SHUTDOWN_PENDING	2015-12-06 22:31:51 -05:00
tc_act
6lowpan.h	6lowpan: remove lowpan_is_addr_broadcast	2015-10-21 00:49:25 +02:00
act_api.h
addrconf.h	ipv6: remove unused neigh parameter from ndisc functions	2015-09-24 12:26:08 -07:00
af_ieee802154.h
af_rxrpc.h
af_unix.h	unix: correctly track in-flight fds in sending process user_struct	2016-03-03 15:07:05 -08:00
af_vsock.h	VSOCK: define VSOCK_SS_LISTEN once only	2015-11-01 12:14:47 -05:00
ah.h
arp.h
atmclip.h
ax25.h
ax88796.h
bond_3ad.h	bonding: simplify / unify event handling code for 3ad mode.	2015-11-02 22:52:24 -05:00
bond_alb.h
bond_options.h
bonding.h
busy_poll.h
cfg80211-wext.h
cfg80211.h	cfg80211/mac80211: clarify RSSI CQM reporting requirements	2015-11-03 10:54:58 +01:00
cfg802154.h	nl802154: add support for security layer	2015-09-30 13:16:44 +02:00
checksum.h
cipso_ipv4.h
cls_cgroup.h
codel.h
compat.h
datalink.h
dcbevent.h
dcbnl.h
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h
dn.h
dsa.h	net: dsa: use switchdev obj for VLAN add/del ops	2015-11-01 15:56:11 -05:00
dsfield.h
dst_metadata.h	gro: Make GRO aware of lightweight tunnels.	2016-03-03 15:07:04 -08:00
dst_ops.h	ipv4, ipv6: Pass net into __ip_local_out and __ip6_local_out	2015-10-08 04:27:02 -07:00
dst.h	net: fix IP early demux races	2015-12-14 23:52:00 -05:00
esp.h
ethoc.h	net/ethoc: support big-endian register layout	2015-09-23 15:33:15 -07:00
fib_rules.h
firewire.h
flow_dissector.h
flow.h	net: Rename FLOWI_FLAG_VRFSRC to FLOWI_FLAG_L3MDEV_SRC	2015-10-07 04:27:42 -07:00
flowcache.h
fou.h
garp.h
gen_stats.h
genetlink.h	genetlink: simplify genl_notify	2015-09-24 12:25:23 -07:00
geneve.h
gre.h
gro_cells.h
gue.h
icmp.h
ieee80211_radiotap.h
ieee802154_netdev.h	nl802154: add support for security layer	2015-09-30 13:16:44 +02:00
if_inet6.h
inet_common.h	net: avoid NULL deref in inet_ctl_sock_destroy()	2015-11-02 22:46:09 -05:00
inet_connection_sock.h	tcp/dccp: fix another race at listener dismantle	2016-03-03 15:07:07 -08:00
inet_ecn.h	ipv6: update skb->csum when CE mark is propagated	2016-01-31 11:29:01 -08:00
inet_frag.h	net: fix percpu memory leaks	2015-11-02 22:47:14 -05:00
inet_hashtables.h	tcp/dccp: fix hashdance race for passive sessions	2015-10-23 05:42:21 -07:00
inet_sock.h	xfrm: take care of request sockets	2015-12-07 17:07:33 -05:00
inet_timewait_sock.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-10-20 06:08:27 -07:00
inet6_connection_sock.h	ipv6: remove obsolete inet6 functions	2015-10-03 04:32:42 -07:00
inet6_hashtables.h
inetpeer.h	inet: tcp: fix inetpeer_set_addr_v4()	2015-12-16 00:14:12 -05:00
ip_fib.h	route: check and remove route cache when we get route	2016-03-03 15:07:07 -08:00
ip_tunnels.h	ip_tunnel: disable preemption when updating per-cpu tstats	2015-11-16 14:14:32 -05:00
ip_vs.h	ipvs: Remove skb_sknet	2015-09-24 09:34:43 +09:00
ip.h	ipv4: Pass struct net into ip_defrag and ip_check_defrag	2015-10-12 19:44:16 -07:00
ip6_checksum.h
ip6_fib.h	ipv6: Check rt->dst.from for the DST_NOCACHE route	2015-11-15 17:12:37 -05:00
ip6_route.h	ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()	2016-03-03 15:07:05 -08:00
ip6_tunnel.h	ip_tunnel: disable preemption when updating per-cpu tstats	2015-11-16 14:14:32 -05:00
ipcomp.h
ipconfig.h
ipv6.h	ipv6: add complete rcu protection around np->opt	2015-12-02 23:37:16 -05:00
ipx.h
iw_handler.h
l3mdev.h	net: Propagate lookup failure in l3mdev_get_saddr to caller	2016-01-04 22:58:30 -05:00
lapb.h
lib80211.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h
lwtunnel.h	dst: Pass net into dst->output	2015-10-08 04:27:03 -07:00
mac80211.h	mac80211: always set the buf_size in AddBA req to 64	2015-11-20 11:39:40 +01:00
mac802154.h	6lowpan: cleanup lowpan_header_decompress	2015-10-21 00:49:24 +02:00
mip6.h
mld.h
mpls_iptunnel.h	mpls: multipath route support	2015-10-23 06:26:42 -07:00
mpls.h
mrp.h
ndisc.h	Revert "ipv6: ndisc: inherit metadata dst when creating ndisc requests"	2015-12-01 15:07:59 -05:00
neighbour.h
net_namespace.h
net_ratelimit.h
netevent.h
netlabel.h
netlink.h	netlink: add nla_get for le32 and le64	2015-09-30 13:16:44 +02:00
netprio_cgroup.h
netrom.h
nexthop.h
nl802154.h	nl802154: add support for security layer	2015-09-30 13:16:44 +02:00
p8022.h
ping.h
pkt_cls.h
pkt_sched.h
protocol.h
psnap.h
raw.h
rawv6.h
red.h
regulatory.h
request_sock.h	tcp/dccp: fix race at listener dismantle phase	2015-10-16 00:52:19 -07:00
rose.h
route.h	net: Propagate lookup failure in l3mdev_get_saddr to caller	2016-01-04 22:58:30 -05:00
rtnetlink.h	netlink: Rightsize IFLA_AF_SPEC size calculation	2015-10-21 19:15:20 -07:00
sch_generic.h	net_sched: fix qdisc_tree_decrease_qlen() races	2015-12-03 14:59:05 -05:00
scm.h	unix: correctly track in-flight fds in sending process user_struct	2016-03-03 15:07:05 -08:00
secure_seq.h
slhc_vj.h
snmp.h
sock.h	net: fix warnings in 'make htmldocs' by moving macro definition out of field declaration	2015-12-16 11:44:17 -05:00
Space.h
stp.h
switchdev.h	net: switchdev: fix return code of fdb_dump stub	2015-11-16 15:24:37 -05:00
tcp_memcontrol.h
tcp_states.h
tcp.h	tcp: do not drop syn_recv on all icmp reports	2016-03-03 15:07:05 -08:00
timewait_sock.h
transp_v6.h
tso.h	net: tso: add support for IPv6	2015-10-26 22:24:22 -07:00
udp_tunnel.h
udp.h
udplite.h
vsock_addr.h
vxlan.h	vxlan: fix incorrect RCO bit in VXLAN header	2015-12-05 18:15:29 -05:00
wext.h
wimax.h
x25.h
x25device.h
xfrm.h	xfrm: add rcu protection to sk->sk_policy[]	2015-12-11 19:22:06 -05:00