Linus Torvalds e23cfb3fdc ida: don't use BUG_ON() for debugging ... commit fc82bbf4de upstream. This is another old BUG_ON() that just shouldn't exist (see also commit a382f8fee42c: "signal handling: don't use BUG_ON() for debugging"). In fact, as Matthew Wilcox points out, this condition shouldn't really even result in a warning, since a negative id allocation result is just a normal allocation failure: "I wonder if we should even warn here -- sure, the caller is trying to free something that wasn't allocated, but we don't warn for kfree(NULL)" and goes on to point out how that current error check is only causing people to unnecessarily do their own index range checking before freeing it. This was noted by Itay Iellin, because the bluetooth HCI socket cookie code does *not* do that range checking, and ends up just freeing the error case too, triggering the BUG_ON(). The HCI code requires CAP_NET_RAW, and seems to just result in an ugly splat, but there really is no reason to BUG_ON() here, and we have generally striven for allocation models where it's always ok to just do free(alloc()); even if the allocation were to fail for some random reason (usually obviously that "random" reason being some resource limit). Fixes: 88eca0207c ("ida: simplified functions for id allocation") Reported-by: Itay Iellin <ieitayie@gmail.com> Suggested-by: Matthew Wilcox <willy@infradead.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-07-12 16:32:23 +02:00
..
842
crypto	crypto: memneq - move into lib/	2022-06-22 14:13:18 +02:00
dim	dim: initialize all struct fields	2022-05-18 10:23:44 +02:00
fonts
kunit	kunit: make kunit_test_timeout compatible with comment	2022-04-08 14:40:04 +02:00
livepatch
lz4	lz4: fix LZ4_decompress_safe_partial read out of bound	2022-04-13 21:01:08 +02:00
lzo
math	lib/math/rational.c: fix divide by zero	2021-07-14 16:56:51 +02:00
mpi	lib/mpi: Add the return value check of kcalloc()	2022-01-27 10:54:02 +01:00
pldmfw
raid6	lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3	2022-04-08 14:40:31 +02:00
reed_solomon
vdso
xz	lib/xz: Validate the value before assigning it to an enum variable	2021-11-18 14:03:58 +01:00
zlib_deflate
zlib_dfltcc
zlib_inflate
zstd
.gitignore
argv_split.c
ashldi3.c
ashrdi3.c
asn1_decoder.c
assoc_array.c	assoc_array: Fix BUG_ON during garbage collect	2022-06-06 08:42:41 +02:00
atomic64_test.c
atomic64.c
audit.c
bcd.c
bch.c
bitfield_kunit.c
bitmap.c
bitrev.c
bootconfig.c
bsearch.c
btree.c
bucket_locks.c
bug.c
build_OID_registry
bust_spinlocks.c
check_signature.c
checksum.c
clz_ctz.c
clz_tab.c
cmdline.c
cmpdi2.c
compat_audit.c
cpu_rmap.c
cpumask.c
crc-ccitt.c
crc-itu-t.c
crc-t10dif.c
crc4.c
crc7.c
crc8.c
crc16.c
crc32.c
crc32defs.h
crc32test.c
crc64.c
ctype.c
debug_info.c
debug_locks.c	locking/lockdep: Improve noinstr vs errors	2021-06-30 08:47:18 -04:00
debugobjects.c
dec_and_lock.c
decompress_bunzip2.c
decompress_inflate.c
decompress_unlz4.c	lib/decompress_unlz4.c: correctly handle zero-padding around initrds.	2021-07-20 16:05:46 +02:00
decompress_unlzma.c
decompress_unlzo.c
decompress_unxz.c	lib/xz: Avoid overlapping memcpy() with invalid input with in-place decompression	2021-11-18 14:03:58 +01:00
decompress_unzstd.c
decompress.c
devres.c
digsig.c
dump_stack.c
dynamic_debug.c
dynamic_queue_limits.c
earlycpio.c
errname.c
error-inject.c
errseq.c
extable.c
fault-inject-usercopy.c
fault-inject.c
fdt_addresses.c
fdt_empty_tree.c
fdt_ro.c
fdt_rw.c
fdt_strerror.c
fdt_sw.c
fdt_wip.c
fdt.c
find_bit_benchmark.c
find_bit.c
flex_proportions.c
gen_crc32table.c
gen_crc64table.c
genalloc.c
generic-radix-tree.c
glob.c
globtest.c
hexdump.c	hex2bin: fix access beyond string end	2022-05-09 09:04:59 +02:00
hweight.c
idr.c	ida: don't use BUG_ON() for debugging	2022-07-12 16:32:23 +02:00
inflate.c
interval_tree_test.c
interval_tree.c
iomap_copy.c
iomap.c
iommu-helper.c
iov_iter.c	lib/iov_iter: initialize "flags" in new pipe_buffer	2022-02-23 12:01:06 +01:00
irq_poll.c
irq_regs.c
is_single_threaded.c
kasprintf.c
Kconfig	crypto: memneq - move into lib/	2022-06-22 14:13:18 +02:00
Kconfig.debug	random: remove ratelimiting for in-kernel unseeded randomness	2022-05-30 09:33:44 +02:00
Kconfig.kasan
Kconfig.kcsan
Kconfig.kgdb
Kconfig.ubsan
kfifo.c
klist.c
kobject_uevent.c	kobject_uevent: remove warning in init_uevent_argv()	2021-05-19 10:13:18 +02:00
kobject.c
kstrtox.c	lib: vsprintf: Fix handling of number field widths in vsscanf	2021-07-14 16:55:57 +02:00
kstrtox.h	lib: vsprintf: Fix handling of number field widths in vsscanf	2021-07-14 16:55:57 +02:00
libcrc32c.c
linear_ranges.c
list_debug.c
list_sort.c	treewide: Change list_sort to use const pointers	2021-09-30 10:11:04 +02:00
list-test.c
llist.c
locking-selftest-hardirq.h
locking-selftest-mutex.h
locking-selftest-rlock-hardirq.h
locking-selftest-rlock-softirq.h
locking-selftest-rlock.h
locking-selftest-rsem.h
locking-selftest-rtmutex.h
locking-selftest-softirq.h
locking-selftest-spin-hardirq.h
locking-selftest-spin-softirq.h
locking-selftest-spin.h
locking-selftest-wlock-hardirq.h
locking-selftest-wlock-softirq.h
locking-selftest-wlock.h
locking-selftest-wsem.h
locking-selftest.c	lockdep/selftests: Fix selftests vs PROVE_RAW_LOCK_NESTING	2021-07-14 16:56:10 +02:00
lockref.c
logic_pio.c
lru_cache.c
lshrdi3.c
Makefile	crypto: memneq - move into lib/	2022-06-22 14:13:18 +02:00
memcat_p.c
memneq.c	crypto: memneq - move into lib/	2022-06-22 14:13:18 +02:00
memory-notifier-error-inject.c
memregion.c
memweight.c
muldi3.c
net_utils.c
netdev-notifier-error-inject.c
nlattr.c
nmi_backtrace.c
nodemask.c	nodemask: Fix return values to be unsigned	2022-06-14 18:32:45 +02:00
notifier-error-inject.c
notifier-error-inject.h
objagg.c
of-reconfig-notifier-error-inject.c
oid_registry.c
once.c	once: Fix panic when module unload	2021-09-03 10:09:21 +02:00
packing.c
parman.c
parser.c
pci_iomap.c
percpu_counter.c
percpu_test.c
percpu-refcount.c	percpu_ref_init(): clean ->percpu_count_ref on failure	2022-06-06 08:42:40 +02:00
plist.c
pm-notifier-error-inject.c
radix-tree.c
random32.c	random: replace custom notifier chain with standard one	2022-05-30 09:33:38 +02:00
ratelimit.c
rbtree_test.c
rbtree.c
refcount.c
rhashtable.c
sbitmap.c
scatterlist.c
seq_buf.c	seq_buf: Fix overflow in seq_buf_putmem_hex()	2021-07-19 09:45:00 +02:00
sg_pool.c
sg_split.c
sha1.c	lib/crypto: sha1: re-roll loops to reduce code size	2022-05-30 09:33:26 +02:00
show_mem.c
siphash.c	siphash: use one source of truth for siphash permutations	2022-05-30 09:33:43 +02:00
smp_processor_id.c
sort.c
stackdepot.c	lib: stackdepot: turn depot_lock spinlock to raw_spinlock	2021-05-22 11:40:55 +02:00
stmp_device.c
string_helpers.c
string.c
strncpy_from_user.c
strnlen_user.c
syscall.c
test_bitmap.c
test_bitops.c
test_bits.c
test_blackhole_dev.c
test_bpf.c	bpf/tests: Do not PASS tests without actually testing the result	2021-09-18 13:40:21 +02:00
test_debug_virtual.c
test_firmware.c
test_fpu.c
test_free_pages.c
test_hash.c
test_hexdump.c
test_hmm_uapi.h
test_hmm.c	mm/hmm.c: allow VM_MIXEDMAP to work with hmm_range_fault	2022-01-27 10:54:36 +01:00
test_ida.c
test_kasan_module.c
test_kasan.c	kasan: fix unit tests with CONFIG_UBSAN_LOCAL_BOUNDS enabled	2021-05-19 10:13:11 +02:00
test_kmod.c	lib/test: use after free in register_test_dev_kmod()	2022-04-08 14:40:30 +02:00
test_linear_ranges.c
test_list_sort.c	treewide: Change list_sort to use const pointers	2021-09-30 10:11:04 +02:00
test_lockup.c	lib/test_lockup: fix kernel pointer check for separate address spaces	2022-04-08 14:40:35 +02:00
test_memcat_p.c
test_meminit.c	lib/test_meminit: destroy cache in kmem_cache_alloc_bulk() test	2022-01-27 10:54:36 +01:00
test_min_heap.c
test_module.c
test_objagg.c
test_overflow.c
test_parman.c
test_printf.c
test_rhashtable.c
test_siphash.c
test_sort.c
test_stackinit.c	lib/test_stackinit: Fix static initializer test	2021-09-18 13:40:37 +02:00
test_static_key_base.c
test_static_keys.c
test_string.c
test_strscpy.c
test_sysctl.c
test_ubsan.c	ubsan: remove CONFIG_UBSAN_OBJECT_SIZE	2022-04-13 21:01:10 +02:00
test_user_copy.c
test_uuid.c
test_vmalloc.c
test_xarray.c	XArray: Fix xas_create_range() when multi-order entry present	2022-04-08 14:40:40 +02:00
test-kstrtox.c
test-string_helpers.c
textsearch.c
timerqueue.c
ts_bm.c
ts_fsm.c
ts_kmp.c
ubsan.c
ubsan.h
ucmpdi2.c
ucs2_string.c
usercopy.c
uuid.c
vsprintf.c	random: replace custom notifier chain with standard one	2022-05-30 09:33:38 +02:00
win_minmax.c
xarray.c	XArray: Update the LRU list in xas_split()	2022-04-08 14:40:40 +02:00
xxhash.c