Weilong Chen ddb5bba463 rtnetlink: Fix memory(net_device) leak when ->newlink fails ... [ Upstream commit cebb69754f ] When vlan_newlink call register_vlan_dev fails, it might return error with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should free the memory. But currently rtnl_newlink only free the memory which state is NETREG_UNINITIALIZED. BUG: memory leak unreferenced object 0xffff8881051de000 (size 4096): comm "syz-executor139", pid 560, jiffies 4294745346 (age 32.445s) hex dump (first 32 bytes): 76 6c 61 6e 32 00 00 00 00 00 00 00 00 00 00 00 vlan2........... 00 45 28 03 81 88 ff ff 00 00 00 00 00 00 00 00 .E(............. backtrace: [<0000000047527e31>] kmalloc_node include/linux/slab.h:578 [inline] [<0000000047527e31>] kvmalloc_node+0x33/0xd0 mm/util.c:574 [<000000002b59e3bc>] kvmalloc include/linux/mm.h:753 [inline] [<000000002b59e3bc>] kvzalloc include/linux/mm.h:761 [inline] [<000000002b59e3bc>] alloc_netdev_mqs+0x83/0xd90 net/core/dev.c:9929 [<000000006076752a>] rtnl_create_link+0x2c0/0xa20 net/core/rtnetlink.c:3067 [<00000000572b3be5>] __rtnl_newlink+0xc9c/0x1330 net/core/rtnetlink.c:3329 [<00000000e84ea553>] rtnl_newlink+0x66/0x90 net/core/rtnetlink.c:3397 [<0000000052c7c0a9>] rtnetlink_rcv_msg+0x540/0x990 net/core/rtnetlink.c:5460 [<000000004b5cb379>] netlink_rcv_skb+0x12b/0x3a0 net/netlink/af_netlink.c:2469 [<00000000c71c20d3>] netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline] [<00000000c71c20d3>] netlink_unicast+0x4c6/0x690 net/netlink/af_netlink.c:1329 [<00000000cca72fa9>] netlink_sendmsg+0x735/0xcc0 net/netlink/af_netlink.c:1918 [<000000009221ebf7>] sock_sendmsg_nosec net/socket.c:652 [inline] [<000000009221ebf7>] sock_sendmsg+0x109/0x140 net/socket.c:672 [<000000001c30ffe4>] ____sys_sendmsg+0x5f5/0x780 net/socket.c:2352 [<00000000b71ca6f3>] ___sys_sendmsg+0x11d/0x1a0 net/socket.c:2406 [<0000000007297384>] __sys_sendmsg+0xeb/0x1b0 net/socket.c:2439 [<000000000eb29b11>] do_syscall_64+0x56/0xa0 arch/x86/entry/common.c:359 [<000000006839b4d0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: cb626bf566 ("net-sysfs: Fix reference count leak") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Weilong Chen <chenweilong@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-07-31 18:37:49 +02:00
..
6lowpan	6lowpan: Off by one handling ->nexthdr	2020-01-27 14:50:41 +01:00
9p	9p: Transport error uninitialized	2019-10-11 18:21:12 +02:00
802
8021q	vlan: vlan_changelink() should propagate errors	2020-01-12 12:17:28 +01:00
appletalk	appletalk: Set error code if register_snap_client failed	2019-12-13 08:52:59 +01:00
atm	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
ax25	AX.25: Prevent integer overflows in connect and sendmsg	2020-07-31 18:37:48 +02:00
batman-adv	batman-adv: Revert "disable ethtool link speed detection when auto negotiation off"	2020-06-22 09:05:12 +02:00
bluetooth	Bluetooth: Add SCO fallback for invalid LMP parameters error	2020-06-22 09:05:11 +02:00
bpf
bpfilter	signal/bpfilter: Fix bpfilter_kernl to use send_sig not force_sig	2020-01-27 14:50:51 +01:00
bridge	net: bridge: enfore alignment for ethernet address	2020-06-30 23:17:03 -04:00
caif	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
can	can: gw: Fix error path of cgw_module_init	2019-08-29 08:28:30 +02:00
ceph	libceph: don't omit recovery_deletes in target_copy()	2020-07-22 09:32:13 +02:00
core	rtnetlink: Fix memory(net_device) leak when ->newlink fails	2020-07-31 18:37:49 +02:00
dcb
dccp	net: ipv6: add net argument to ip6_dst_lookup_flow	2020-04-29 16:31:16 +02:00
decnet	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:13:37 +01:00
dns_resolver	KEYS: Don't write out to userspace while holding key semaphore	2020-04-23 10:30:24 +02:00
dsa	net: dsa: mt7530: fix roaming from DSA user ports	2020-06-03 08:19:03 +02:00
ethernet	net: add annotations on hh->hh_len lockless accesses	2020-01-09 10:19:09 +01:00
hsr	hsr: check protocol version in hsr_newlink()	2020-04-21 09:03:03 +02:00
ieee802154	nl802154: add missing attribute validation for dev_type	2020-03-18 07:14:15 +01:00
ife
ipv4	udp: Improve load balancing for SO_REUSEPORT.	2020-07-31 18:37:49 +02:00
ipv6	udp: Improve load balancing for SO_REUSEPORT.	2020-07-31 18:37:49 +02:00
iucv	net/af_iucv: always register net_device notifier	2020-01-27 14:50:56 +01:00
kcm	kcm: switch order of device registration to fix a crash	2019-04-17 08:38:40 +02:00
key	af_key: fix leaks in key_pol_get_resp and dump_sp.	2019-07-26 09:14:01 +02:00
l2tp	l2tp: remove skb_dst_set() from l2tp_xmit_skb()	2020-07-22 09:31:59 +02:00
l3mdev
lapb	lapb: fixed leak of control-blocks.	2019-06-22 08:15:13 +02:00
llc	llc: make sure applications use ARPHRD_ETHER	2020-07-22 09:31:59 +02:00
mac80211	mac80211: allow rx of mesh eapol frames with default rx key	2020-07-29 10:16:44 +02:00
mac802154
mpls	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2020-04-29 16:31:17 +02:00
ncsi
netfilter	ipvs: fix the connection sync failed in some cases	2020-07-29 10:16:50 +02:00
netlabel	netlabel: cope with NULL catmap	2020-05-20 08:18:35 +02:00
netlink	genetlink: remove genl_bind	2020-07-22 09:31:58 +02:00
netrom	net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node	2020-04-29 16:31:21 +02:00
nfc	nfc: add missing attribute validation for vendor subcommand	2020-03-18 07:14:17 +01:00
nsh
openvswitch	openvswitch: support asymmetric conntrack	2019-12-21 10:57:14 +01:00
packet	net/packet: tpacket_rcv: avoid a producer race condition	2020-04-02 15:28:11 +02:00
phonet	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
psample	net: psample: fix skb_over_panic	2019-12-05 09:21:30 +01:00
qrtr	qrtr: orphan socket in qrtr_release()	2020-07-31 18:37:48 +02:00
rds	net/rds: Fix 'ib_evt_handler_call' element in 'rds_ib_stat_names'	2020-01-27 14:51:13 +01:00
rfkill	rfkill: Fix incorrect check to avoid NULL pointer dereference	2020-01-12 12:17:17 +01:00
rose	net/rose: fix unbound loop in rose_loopback_timer()	2019-05-02 09:59:00 +02:00
rxrpc	rxrpc: Fix sendmsg() returning EPIPE due to recvmsg() returning ENODATA	2020-07-31 18:37:48 +02:00
sched	sched: consistently handle layer3 header accesses in the presence of VLANs	2020-07-22 09:32:00 +02:00
sctp	sctp: shrink stream outq when fails to do addstream reconf	2020-07-31 18:37:48 +02:00
smc	net/smc: cancel event worker during device removal	2020-03-18 07:14:25 +01:00
strparser	net: strparser: partially revert "strparser: Call skb_unclone conditionally"	2019-05-16 19:41:27 +02:00
sunrpc	SUNRPC: Properly set the @subbuf parameter of xdr_buf_subsegment()	2020-06-30 23:17:18 -04:00
switchdev
tipc	tipc: clean up skb list lock handling on send path	2020-07-29 10:16:47 +02:00
tls	net/tls: Fix to avoid gettig invalid tls record	2020-03-05 16:42:17 +01:00
unix	af_unix: add compat_ioctl support	2020-01-17 19:47:07 +01:00
vmw_vsock	vsock: fix timeout in vsock_accept()	2020-06-10 21:34:59 +02:00
wimax
wireless	nl80211: fix NL80211_ATTR_CHANNEL_WIDTH attribute type	2020-04-02 15:28:17 +02:00
x25	net/x25: Fix x25_neigh refcnt leak when receiving frame	2020-04-29 16:31:21 +02:00
xdp	xdp: Fix xsk_generic_xmit errno	2020-06-25 15:33:05 +02:00
xfrm	xfrm: Fix double ESP trailer insertion in IPsec crypto offload.	2020-06-30 23:17:10 -04:00
compat.c
Kconfig
Makefile
socket.c	compat_ioctl: handle SIOCOUTQNSD	2020-01-17 19:47:07 +01:00
sysctl_net.c