Dmitry Monakhov 30d8c83528 ext4: prevent bugon on race between write/fcntl ... commit a41537e69b upstream. O_DIRECT flags can be toggeled via fcntl(F_SETFL). But this value checked twice inside ext4_file_write_iter() and __generic_file_write() which result in BUG_ON inside ext4_direct_IO. Let's initialize iocb->private unconditionally. TESTCASE: xfstest:generic/036 https://patchwork.ozlabs.org/patch/402445/ #TYPICAL STACK TRACE: kernel BUG at fs/ext4/inode.c:2960! invalid opcode: 0000 [#1] SMP Modules linked in: brd iTCO_wdt lpc_ich mfd_core igb ptp dm_mirror dm_region_hash dm_log dm_mod CPU: 6 PID: 5505 Comm: aio-dio-fcntl-r Not tainted 3.17.0-rc2-00176-gff5c017 #161 Hardware name: Intel Corporation W2600CR/W2600CR, BIOS SE5C600.86B.99.99.x028.061320111235 06/13/2011 task: ffff88080e95a7c0 ti: ffff88080f908000 task.ti: ffff88080f908000 RIP: 0010:[<ffffffff811fabf2>] [<ffffffff811fabf2>] ext4_direct_IO+0x162/0x3d0 RSP: 0018:ffff88080f90bb58 EFLAGS: 00010246 RAX: 0000000000000400 RBX: ffff88080fdb2a28 RCX: 00000000a802c818 RDX: 0000040000080000 RSI: ffff88080d8aeb80 RDI: 0000000000000001 RBP: ffff88080f90bbc8 R08: 0000000000000000 R09: 0000000000001581 R10: 0000000000000000 R11: 0000000000000000 R12: ffff88080d8aeb80 R13: ffff88080f90bbf8 R14: ffff88080fdb28c8 R15: ffff88080fdb2a28 FS: 00007f23b2055700(0000) GS:ffff880818400000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f23b2045000 CR3: 000000080cedf000 CR4: 00000000000407e0 Stack: ffff88080f90bb98 0000000000000000 7ffffffffffffffe ffff88080fdb2c30 0000000000000200 0000000000000200 0000000000000001 0000000000000200 ffff88080f90bbc8 ffff88080fdb2c30 ffff88080f90be08 0000000000000200 Call Trace: [<ffffffff8112ca9d>] generic_file_direct_write+0xed/0x180 [<ffffffff8112f2b2>] __generic_file_write_iter+0x222/0x370 [<ffffffff811f495b>] ext4_file_write_iter+0x34b/0x400 [<ffffffff811bd709>] ? aio_run_iocb+0x239/0x410 [<ffffffff811bd709>] ? aio_run_iocb+0x239/0x410 [<ffffffff810990e5>] ? local_clock+0x25/0x30 [<ffffffff810abd94>] ? __lock_acquire+0x274/0x700 [<ffffffff811f4610>] ? ext4_unwritten_wait+0xb0/0xb0 [<ffffffff811bd756>] aio_run_iocb+0x286/0x410 [<ffffffff810990e5>] ? local_clock+0x25/0x30 [<ffffffff810ac359>] ? lock_release_holdtime+0x29/0x190 [<ffffffff811bc05b>] ? lookup_ioctx+0x4b/0xf0 [<ffffffff811bde3b>] do_io_submit+0x55b/0x740 [<ffffffff811bdcaa>] ? do_io_submit+0x3ca/0x740 [<ffffffff811be030>] SyS_io_submit+0x10/0x20 [<ffffffff815ce192>] system_call_fastpath+0x16/0x1b Code: 01 48 8b 80 f0 01 00 00 48 8b 18 49 8b 45 10 0f 85 f1 01 00 00 48 03 45 c8 48 3b 43 48 0f 8f e3 01 00 00 49 83 7c 24 18 00 75 04 <0f> 0b eb fe f0 ff 83 ec 01 00 00 49 8b 44 24 18 8b 00 85 c0 89 RIP [<ffffffff811fabf2>] ext4_direct_IO+0x162/0x3d0 RSP <ffff88080f90bb58> Reported-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> [hujianyang: Backported to 3.10 - Move initialization of iocb->private to ext4_file_write() as we don't have ext4_file_write_iter(), which is introduced by commit 9b884164. - Adjust context to make 'overwrite' changes apply to ext4_file_dio_write() as ext4_file_dio_write() is not move into ext4_file_write()] Signed-off-by: hujianyang <hujianyang@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2015-02-11 14:48:17 +08:00
..
acl.c	ext4: fix the number of credits needed for acl ops with inline data	2013-02-09 15:23:03 -05:00
acl.h	fs: take the ACL checks to common code	2011-07-25 14:30:23 -04:00
balloc.c	ext4: fix ext4_get_group_number()	2013-07-21 18:21:33 -07:00
bitmap.c	ext4: Checksum the block bitmap properly with bigalloc enabled	2012-10-22 00:34:32 -04:00
block_validity.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
dir.c	ext4: fix readdir error in the case of inline_data+dir_index	2013-04-19 17:53:09 -04:00
ext4_extents.h	ext4: mext_insert_extents should update extent block checksum	2013-04-19 14:04:12 -04:00
ext4_jbd2.c	ext4: call ext4_error_inode() if jbd2_journal_dirty_metadata() fails	2014-01-09 12:24:21 -08:00
ext4_jbd2.h	ext4: improve credit estimate for EXT4_SINGLEDATA_TRANS_BLOCKS	2013-04-09 12:39:26 -04:00
ext4.h	ext4: fix warning in ext4_da_update_reserve_space()	2015-01-29 17:40:57 -08:00
extents_status.c	ext4: fix fio regression	2013-05-03 02:15:52 -04:00
extents_status.h	ext4: fix fio regression	2013-05-03 02:15:52 -04:00
extents.c	ext4: fix warning in ext4_da_update_reserve_space()	2015-01-29 17:40:57 -08:00
file.c	ext4: prevent bugon on race between write/fcntl	2015-02-11 14:48:17 +08:00
fsync.c	ext4/jbd2: don't wait (forever) for stale tid caused by wraparound	2013-04-03 22:02:52 -04:00
hash.c	ext4: reduce one "if" comparison in ext4_dirhash()	2013-02-01 22:33:21 -05:00
ialloc.c	ext4: fix oops when loading block bitmap failed	2014-11-14 08:47:58 -08:00
indirect.c	ext4: Fix hole punching for files with indirect blocks	2014-07-09 11:14:01 -07:00
inline.c	ext4: avoid clearing beyond i_blocks when truncating an inline data file	2014-02-06 11:08:16 -08:00
inode.c	ext4: fix reservation overflow in ext4_da_write_begin	2014-11-14 08:47:57 -08:00
ioctl.c	ext4: grab missed write_count for EXT4_IOC_SWAP_BOOT	2014-11-14 08:47:57 -08:00
Kconfig	ext4: fix Kconfig documentation for CONFIG_EXT4_DEBUG	2013-04-21 20:32:03 -04:00
Makefile	ext4: Remove CONFIG_EXT4_FS_XATTR	2012-12-10 16:30:43 -05:00
mballoc.c	ext4: fix warning in ext4_da_update_reserve_space()	2015-01-29 17:40:57 -08:00
mballoc.h	ext4: use module parameters instead of debugfs for mballoc_debug	2013-02-09 16:28:20 -05:00
migrate.c	ext4: do not convert to indirect with bigalloc enabled	2013-04-11 10:54:46 -04:00
mmp.c	ext4: mark all metadata I/O with REQ_META	2013-04-20 15:46:17 -04:00
move_extent.c	ext4: mext_insert_extents should update extent block checksum	2013-04-19 14:04:12 -04:00
namei.c	ext4: add ext4_iget_normal() which is to be used for dir tree lookups	2014-11-14 08:47:57 -08:00
page-io.c	ext4: fix zeroing of page during writeback	2014-06-30 20:09:42 -07:00
resize.c	ext4: fix overflow when updating superblock backups after resize	2014-11-14 08:47:58 -08:00
super.c	ext4: check s_chksum_driver when looking for bg csum presence	2014-11-14 08:47:57 -08:00
symlink.c	ext4: Remove CONFIG_EXT4_FS_XATTR	2012-12-10 16:30:43 -05:00
truncate.h	ext4: move common truncate functions to header file	2011-06-27 19:16:04 -04:00
xattr_security.c	Merge branch 'for_linus' into for_linus_merged	2012-01-10 11:54:07 -05:00
xattr_trusted.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
xattr_user.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
xattr.c	ext4: check EA value offset when loading	2014-11-14 08:47:57 -08:00
xattr.h	ext4: reserve xattr index for Rich ACL support	2013-04-18 14:53:15 -04:00