Jan Glauber 8e071518d1 ipmi: Fix timer race with module unload ... commit 0711e8c1b4 upstream. Please note that below oops is from an older kernel, but the same race seems to be present in the upstream kernel too. ---8<--- The following panic was encountered during removing the ipmi_ssif module: [ 526.352555] Unable to handle kernel paging request at virtual address ffff000006923090 [ 526.360464] Mem abort info: [ 526.363257] ESR = 0x86000007 [ 526.366304] Exception class = IABT (current EL), IL = 32 bits [ 526.372221] SET = 0, FnV = 0 [ 526.375269] EA = 0, S1PTW = 0 [ 526.378405] swapper pgtable: 4k pages, 48-bit VAs, pgd = 000000008ae60416 [ 526.385185] [ffff000006923090] *pgd=000000bffcffe803, *pud=000000bffcffd803, *pmd=0000009f4731a003, *pte=0000000000000000 [ 526.396141] Internal error: Oops: 86000007 [#1] SMP [ 526.401008] Modules linked in: nls_iso8859_1 ipmi_devintf joydev input_leds ipmi_msghandler shpchp sch_fq_codel ib_iser rdma_cm iw_cm ib_cm ib_core iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi ip_tables x_tables autofs4 btrfs zstd_compress raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 multipath linear i2c_smbus hid_generic usbhid uas hid usb_storage ast aes_ce_blk i2c_algo_bit aes_ce_cipher qede ttm crc32_ce ptp crct10dif_ce drm_kms_helper ghash_ce syscopyarea sha2_ce sysfillrect sysimgblt pps_core fb_sys_fops sha256_arm64 sha1_ce mpt3sas qed drm raid_class ahci scsi_transport_sas libahci gpio_xlp i2c_xlp9xx aes_neon_bs aes_neon_blk crypto_simd cryptd aes_arm64 [last unloaded: ipmi_ssif] [ 526.468085] CPU: 125 PID: 0 Comm: swapper/125 Not tainted 4.15.0-35-generic #38~lp1775396+build.1 [ 526.476942] Hardware name: To be filled by O.E.M. Saber/Saber, BIOS 0ACKL022 08/14/2018 [ 526.484932] pstate: 00400009 (nzcv daif +PAN -UAO) [ 526.489713] pc : 0xffff000006923090 [ 526.493198] lr : call_timer_fn+0x34/0x178 [ 526.497194] sp : ffff000009b0bdd0 [ 526.500496] x29: ffff000009b0bdd0 x28: 0000000000000082 [ 526.505796] x27: 0000000000000002 x26: ffff000009515188 [ 526.511096] x25: ffff000009515180 x24: ffff0000090f1018 [ 526.516396] x23: ffff000009519660 x22: dead000000000200 [ 526.521696] x21: ffff000006923090 x20: 0000000000000100 [ 526.526995] x19: ffff809eeb466a40 x18: 0000000000000000 [ 526.532295] x17: 000000000000000e x16: 0000000000000007 [ 526.537594] x15: 0000000000000000 x14: 071c71c71c71c71c [ 526.542894] x13: 0000000000000000 x12: 0000000000000000 [ 526.548193] x11: 0000000000000001 x10: ffff000009b0be88 [ 526.553493] x9 : 0000000000000000 x8 : 0000000000000005 [ 526.558793] x7 : ffff80befc1f8528 x6 : 0000000000000020 [ 526.564092] x5 : 0000000000000040 x4 : 0000000020001b20 [ 526.569392] x3 : 0000000000000000 x2 : ffff809eeb466a40 [ 526.574692] x1 : ffff000006923090 x0 : ffff809eeb466a40 [ 526.579992] Process swapper/125 (pid: 0, stack limit = 0x000000002eb50acc) [ 526.586854] Call trace: [ 526.589289] 0xffff000006923090 [ 526.592419] expire_timers+0xc8/0x130 [ 526.596070] run_timer_softirq+0xec/0x1b0 [ 526.600070] __do_softirq+0x134/0x328 [ 526.603726] irq_exit+0xc8/0xe0 [ 526.606857] __handle_domain_irq+0x6c/0xc0 [ 526.610941] gic_handle_irq+0x84/0x188 [ 526.614679] el1_irq+0xe8/0x180 [ 526.617822] cpuidle_enter_state+0xa0/0x328 [ 526.621993] cpuidle_enter+0x34/0x48 [ 526.625564] call_cpuidle+0x44/0x70 [ 526.629040] do_idle+0x1b8/0x1f0 [ 526.632256] cpu_startup_entry+0x2c/0x30 [ 526.636174] secondary_start_kernel+0x11c/0x130 [ 526.640694] Code: bad PC value [ 526.643800] ---[ end trace d020b0b8417c2498 ]--- [ 526.648404] Kernel panic - not syncing: Fatal exception in interrupt [ 526.654778] SMP: stopping secondary CPUs [ 526.658734] Kernel Offset: disabled [ 526.662211] CPU features: 0x5800c38 [ 526.665688] Memory Limit: none [ 526.668768] ---[ end Kernel panic - not syncing: Fatal exception in interrupt Prevent mod_timer from arming a timer that was already removed by del_timer during module unload. Signed-off-by: Jan Glauber <jglauber@cavium.com> Cc: <stable@vger.kernel.org> # 3.19 Signed-off-by: Corey Minyard <cminyard@mvista.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-11-13 11:08:17 -08:00
..
agp	char: amd64-agp: Use 64-bit arithmetic instead of 32-bit	2018-07-10 13:50:31 +10:00
hw_random	Char/Misc driver patches for 4.19-rc1	2018-08-18 11:04:51 -07:00
ipmi	ipmi: Fix timer race with module unload	2018-11-13 11:08:17 -08:00
mwave	char/mwave: make some arrays static const to make object code smaller	2017-07-17 17:23:16 +02:00
pcmcia	char: pcmcia: remove redundant pointer dev	2018-07-03 13:01:57 +02:00
tpm	tpm: replace TPM_TRANSMIT_RAW with TPM_TRANSMIT_NESTED	2018-07-28 17:03:11 +03:00
xilinx_hwicap	char: xilinx_hwicap: Fix warnings in the driver	2017-08-28 17:04:47 +02:00
xillybus	PCI: Add Altera vendor ID	2018-03-14 19:13:47 +01:00
adi.c	char: sparc64: Add privileged ADI driver	2018-06-05 11:24:55 -07:00
apm-emulation.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
applicom.c	applicom: constify pci_device_id.	2017-08-28 17:11:28 +02:00
applicom.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bsr.c
ds1620.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
dsp56k.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
dtlk.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
efirtc.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
generic_nvram.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
hangcheck-timer.c	treewide: Switch DEFINE_TIMER callbacks to struct timer_list *	2017-11-21 15:57:05 -08:00
hpet.c	hpet: remove redundant pointer hpet	2018-07-03 13:01:57 +02:00
Kconfig	random: make CPU trust a boot parameter	2018-09-01 12:51:54 -04:00
lp.c	char: lp: use true or false for boolean values	2018-01-25 10:56:02 +01:00
Makefile	char: sparc64: Add privileged ADI driver	2018-06-05 11:24:55 -07:00
mbcs.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
mbcs.h
mem.c	Char/Misc driver patches for 4.19-rc1	2018-08-18 11:04:51 -07:00
misc.c	proc: introduce proc_create_seq{,_data}	2018-05-16 07:23:35 +02:00
mspec.c	char: mspec: change return type to vm_fault_t	2018-04-23 13:51:53 +02:00
nsc_gpio.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
nvram.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
nwbutton.c	treewide: Switch DEFINE_TIMER callbacks to struct timer_list *	2017-11-21 15:57:05 -08:00
nwbutton.h	treewide: Switch DEFINE_TIMER callbacks to struct timer_list *	2017-11-21 15:57:05 -08:00
nwflash.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
pc8736x_gpio.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
powernv-op-panel.c	powerpc/powernv: Add driver for operator panel on FSP machines	2016-06-29 17:33:46 +10:00
ppdev.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
ps3flash.c	wrappers for ->i_mutex access	2016-01-22 18:04:28 -05:00
random.c	random: make CPU trust a boot parameter	2018-09-01 12:51:54 -04:00
raw.c	treewide: Use array_size() in vzalloc()	2018-06-12 16:19:22 -07:00
rtc.c	char: rtc: remove task handling	2018-08-02 17:16:03 +02:00
scx200_gpio.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
snsc_event.c	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/signal.h>	2017-03-02 08:42:29 +01:00
snsc.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
snsc.h
sonypi.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
tb0219.c	mips: separate extable.h, switch module.h to it	2016-10-05 18:36:18 -04:00
tlclk.c	timer: Remove last user of TIMER_INITIALIZER	2017-10-05 15:01:18 +02:00
toshiba.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
ttyprintk.c	ttyprintk: Neaten and simplify printing	2016-09-13 17:30:17 +02:00
uv_mmtimer.c
virtio_console.c	virtio: virtconsole: Use seq_file for debugfs operations	2018-07-16 12:03:53 +02:00