linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-07 14:04:54 +02:00

Linux kernel source tree

Go to file

Tao Liu dac2490d9e gso: do not skip outer ip header in case of ipip and net_failover commit `cc20cced05` upstream. We encounter a tcp drop issue in our cloud environment. Packet GROed in host forwards to a VM virtio_net nic with net_failover enabled. VM acts as a IPVS LB with ipip encapsulation. The full path like: host gro -> vm virtio_net rx -> net_failover rx -> ipvs fullnat -> ipip encap -> net_failover tx -> virtio_net tx When net_failover transmits a ipip pkt (gso_type = 0x0103, which means SKB_GSO_TCPV4, SKB_GSO_DODGY and SKB_GSO_IPXIP4), there is no gso did because it supports TSO and GSO_IPXIP4. But network_header points to inner ip header. Call Trace: tcp4_gso_segment ------> return NULL inet_gso_segment ------> inner iph, network_header points to ipip_gso_segment inet_gso_segment ------> outer iph skb_mac_gso_segment Afterwards virtio_net transmits the pkt, only inner ip header is modified. And the outer one just keeps unchanged. The pkt will be dropped in remote host. Call Trace: inet_gso_segment ------> inner iph, outer iph is skipped skb_mac_gso_segment __skb_gso_segment validate_xmit_skb validate_xmit_skb_list sch_direct_xmit __qdisc_run __dev_queue_xmit ------> virtio_net dev_hard_start_xmit __dev_queue_xmit ------> net_failover ip_finish_output2 ip_output iptunnel_xmit ip_tunnel_xmit ipip_tunnel_xmit ------> ipip dev_hard_start_xmit __dev_queue_xmit ip_finish_output2 ip_output ip_forward ip_rcv __netif_receive_skb_one_core netif_receive_skb_internal napi_gro_receive receive_buf virtnet_poll net_rx_action The root cause of this issue is specific with the rare combination of SKB_GSO_DODGY and a tunnel device that adds an SKB_GSO_ tunnel option. SKB_GSO_DODGY is set from external virtio_net. We need to reset network header when callbacks.gso_segment() returns NULL. This patch also includes ipv6_gso_segment(), considering SIT, etc. Fixes: `cb32f511a7` ("ipip: add GSO/TSO support") Signed-off-by: Tao Liu <thomas.liu@ucloud.cn> Reviewed-by: Willem de Bruijn <willemb@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-03-02 11:42:49 +01:00
arch	x86/fpu: Correct pkru/xstate inconsistency	2022-03-02 11:42:47 +01:00
block	block/wbt: fix negative inflight counter when remove scsi device	2022-02-23 12:01:04 +01:00
certs	certs: Trigger creation of RSA module signing key if it's not an RSA key	2021-09-15 09:50:29 +02:00
crypto	crypto: api - Move cryptomgr soft dependency into algapi	2022-02-11 09:09:03 +01:00
Documentation	ARM: dts: Fix timer regression for beagleboard revision c	2022-02-16 12:54:22 +01:00
drivers	hwmon: Handle failure to register sensor with thermal zone correctly	2022-03-02 11:42:48 +01:00
fs	io_uring: add a schedule point in io_add_buffers()	2022-03-02 11:42:49 +01:00
include	tee: export teedev_open() and teedev_close_context()	2022-03-02 11:42:47 +01:00
init	bpf: Add kconfig knob for disabling unpriv bpf by default	2022-01-05 12:40:34 +01:00
ipc	shm: extend forced shm destroy to support objects from several IPC nses	2021-12-01 09:19:10 +01:00
kernel	bpf: Add schedule points in batch ops	2022-03-02 11:42:49 +01:00
lib	lib/iov_iter: initialize "flags" in new pipe_buffer	2022-02-23 12:01:06 +01:00
LICENSES	LICENSES/deprecated: add Zlib license text	2020-09-16 14:33:49 +02:00
mm	mm: don't try to NUMA-migrate COW pages that have other uses	2022-02-23 12:00:57 +01:00
net	gso: do not skip outer ip header in case of ipip and net_failover	2022-03-02 11:42:49 +01:00
samples	ftrace/samples: Add missing prototypes direct functions	2022-01-11 15:25:00 +01:00
scripts	kconfig: fix failing to generate auto.conf	2022-02-23 12:01:07 +01:00
security	ima: Do not print policy rule with inactive LSM labels	2022-02-16 12:54:16 +01:00
sound	ASoC: tas2770: Insert post reset delay	2022-02-23 12:01:04 +01:00
tools	selftests: bpf: Check bpf_msg_push_data return value	2022-03-02 11:42:48 +01:00
usr	usr/include/Makefile: add linux/nfc.h to the compile-test coverage	2022-02-01 17:25:48 +01:00
virt	KVM: eventfd: Fix false positive RCU usage warning	2022-02-16 12:54:20 +01:00
.clang-format	RDMA 5.10 pull request	2020-10-17 11:18:18 -07:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore	kbuild: generate Module.symvers only when vmlinux exists	2021-05-19 10:12:59 +02:00
.mailmap	mailmap: add two more addresses of Uwe Kleine-König	2020-12-06 10:19:07 -08:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: Move Jason Cooper to CREDITS	2020-11-30 10:20:34 +01:00
Kbuild	kbuild: rename hostprogs-y/always to hostprogs/always-y	2020-02-04 01:53:07 +09:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	MAINTAINERS: adjust GCC PLUGINS after gcc-plugin.sh removal	2021-12-14 11:32:46 +01:00
Makefile	Linux 5.10.102	2022-02-23 12:01:08 +01:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.