Josef Bacik e3b5252b5c btrfs: shrink delalloc pages instead of full inodes ... [ Upstream commit e076ab2a2c ] Commit 38d715f494 ("btrfs: use btrfs_start_delalloc_roots in shrink_delalloc") cleaned up how we do delalloc shrinking by utilizing some infrastructure we have in place to flush inodes that we use for device replace and snapshot. However this introduced a pretty serious performance regression. To reproduce the user untarred the source tarball of Firefox (360MiB xz compressed/1.5GiB uncompressed), and would see it take anywhere from 5 to 20 times as long to untar in 5.10 compared to 5.9. This was observed on fast devices (SSD and better) and not on HDD. The root cause is because before we would generally use the normal writeback path to reclaim delalloc space, and for this we would provide it with the number of pages we wanted to flush. The referenced commit changed this to flush that many inodes, which drastically increased the amount of space we were flushing in certain cases, which severely affected performance. We cannot revert this patch unfortunately because of 3d45f221ce ("btrfs: fix deadlock when cloning inline extent and low on free metadata space") which requires the ability to skip flushing inodes that are being cloned in certain scenarios, which means we need to keep using our flushing infrastructure or risk re-introducing the deadlock. Instead to fix this problem we can go back to providing btrfs_start_delalloc_roots with a number of pages to flush, and then set up a writeback_control and utilize sync_inode() to handle the flushing for us. This gives us the same behavior we had prior to the fix, while still allowing us to avoid the deadlock that was fixed by Filipe. I redid the users original test and got the following results on one of our test machines (256GiB of ram, 56 cores, 2TiB Intel NVMe drive) 5.9 0m54.258s 5.10 1m26.212s 5.10+patch 0m38.800s 5.10+patch is significantly faster than plain 5.9 because of my patch series "Change data reservations to use the ticketing infra" which contained the patch that introduced the regression, but generally improved the overall ENOSPC flushing mechanisms. Additional testing on consumer-grade SSD (8GiB ram, 8 CPU) confirm the results: 5.10.5 4m00s 5.10.5+patch 1m08s 5.11-rc2 5m14s 5.11-rc2+patch 1m30s Reported-by: René Rebe <rene@exactcode.de> Fixes: 38d715f494 ("btrfs: use btrfs_start_delalloc_roots in shrink_delalloc") CC: stable@vger.kernel.org # 5.10 Signed-off-by: Josef Bacik <josef@toxicpanda.com> Tested-by: David Sterba <dsterba@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> [ add my test results ] Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-01-17 14:16:54 +01:00
..
9p	fs: 9p: add generic splice_write file operation	2020-12-01 21:40:47 +01:00
adfs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
affs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
afs	afs: Fix memory leak when mounting with multiple source parameters	2020-12-08 15:59:25 -08:00
autofs	autofs: harden ioctl table	2020-10-16 11:11:22 -07:00
befs	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
bfs	bfs: don't use WARNING: string when it's just info.	2021-01-06 14:56:52 +01:00
btrfs	btrfs: shrink delalloc pages instead of full inodes	2021-01-17 14:16:54 +01:00
cachefiles	cachefiles: Handle readpage error correctly	2020-10-26 10:42:54 -07:00
ceph	ceph: fix inode refcount leak when ceph_fill_inode on non-I_NEW inode fails	2021-01-06 14:56:55 +01:00
cifs	SMB3.1.1: do not log warning message if server doesn't populate salt	2020-12-30 11:54:17 +01:00
coda
configfs	fs: configfs: delete repeated words in comments	2020-10-16 11:11:19 -07:00
cramfs	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
crypto	fscrypt: add fscrypt_is_nokey_name()	2020-12-26 16:02:43 +01:00
debugfs	debugfs: remove return value of debugfs_create_devm_seqfile()	2020-10-30 08:37:39 +01:00
devpts
dlm	networking changes for the 5.10 merge window	2020-10-15 18:42:13 -07:00
ecryptfs	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
efivarfs	efivarfs: revert "fix memory leak in efivarfs_create()"	2020-11-25 16:55:02 +01:00
efs	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
erofs	erofs: avoid using generic_block_bmap	2020-12-30 11:53:46 +01:00
exfat	exfat: Avoid allocating upcase table using kcalloc()	2020-12-26 16:02:38 +01:00
exportfs
ext2	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
ext4	ext4: avoid s_mb_prefetch to be zero in individual scenarios	2021-01-06 14:56:56 +01:00
f2fs	f2fs: fix race of pending_pages in decompression	2021-01-06 14:56:54 +01:00
fat	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
freevxfs
fscache	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-06-03 16:27:18 -07:00
fuse	fuse: fix bad inode	2021-01-09 13:46:24 +01:00
gfs2	gfs2: Fix deadlock between gfs2_{create_inode,inode_lookup} and delete_work_func	2020-12-01 00:21:10 +01:00
hfs	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
hfsplus	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
hostfs
hpfs	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
hugetlbfs	hugetlbfs: prevent filesystem stacking of hugetlbfs	2020-08-12 10:57:56 -07:00
iomap	iomap: clean up writeback state logic on writepage error	2020-11-04 08:52:46 -08:00
isofs	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
jbd2	jbd2: fix kernel-doc markups	2020-11-19 22:38:29 -05:00
jffs2	jffs2: Fix NULL pointer dereference in rp_size fs option parsing	2021-01-06 14:56:49 +01:00
jfs	jfs: Fix array index bounds check in dbAdjTree	2020-12-30 11:54:18 +01:00
kernfs	fsnotify: pass dir and inode arguments to fsnotify()	2020-07-27 23:15:48 +02:00
lockd	lockd: don't use interval-based rebinding over TCP	2020-12-30 11:53:30 +01:00
minix	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
nfs	NFSv4.2: Don't error when exiting early on a READ_PLUS buffer overflow	2021-01-06 14:56:55 +01:00
nfs_common	nfs_common: need lock during iterate through the list	2020-12-30 11:53:45 +01:00
nfsd	fsnotify: generalize handle_inode_event()	2020-12-30 11:54:18 +01:00
nilfs2	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
nls	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
notify	fsnotify: fix events reported to watching parent and child	2020-12-30 11:54:18 +01:00
ntfs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
ocfs2	ocfs2: initialize ip_next_orphan	2020-11-14 11:26:04 -08:00
omfs	fs: omfs: use kmemdup() rather than kmalloc+memcpy	2020-09-22 23:39:45 -04:00
openpromfs
orangefs	orangefs: remove unnecessary assignment to variable ret	2020-08-04 15:01:58 -04:00
overlayfs	ovl: make ioctl() safe	2020-12-30 11:54:16 +01:00
proc	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:46:24 +01:00
pstore	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
qnx4	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
qnx6	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
quota	quota: Don't overflow quota file offsets	2021-01-06 14:56:53 +01:00
ramfs	ramfs: fix nommu mmap with gaps in the page cache	2020-10-16 11:11:22 -07:00
reiserfs	reiserfs: add check for an invalid ih_entry_count	2021-01-06 14:56:52 +01:00
romfs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
squashfs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
sysfs	sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output	2020-10-02 12:02:30 +02:00
sysv	[PATCH] reduce boilerplate in fsid handling	2020-09-18 16:45:50 -04:00
tracefs
ubifs	ubifs: wbuf: Don't leak kernel memory to flash	2020-12-30 11:54:17 +01:00
udf	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
ufs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
unicode	unicode: Add utf8_casefold_hash	2020-09-10 14:03:31 -07:00
vboxsf	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2020-10-15 15:11:56 -07:00
verity	fs-verity: use smp_load_acquire() for ->i_verity_info	2020-07-21 16:02:41 -07:00
xfs	xfs: revert "xfs: fix rmap key and record comparison functions"	2020-11-19 15:17:50 -08:00
zonefs	zonefs: fix page reference and BIO leak	2020-12-10 15:14:19 +09:00
aio.c	vfs: separate __sb_start_write into blocking and non-blocking helpers	2020-11-10 16:53:07 -08:00
anon_inodes.c
attr.c
bad_inode.c	fs: move the fiemap definitions out of fs.h	2020-06-03 23:16:55 -04:00
binfmt_aout.c
binfmt_elf_fdpic.c	binfmt_elf, binfmt_elf_fdpic: use a VMA list snapshot	2020-10-16 11:11:21 -07:00
binfmt_elf.c	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
binfmt_em86.c	Merge branch 'akpm' (patches from Andrew)	2020-06-04 19:18:29 -07:00
binfmt_flat.c	binfmt_flat: revert "binfmt_flat: don't offset the data start"	2020-08-24 08:49:13 +10:00
binfmt_misc.c	Merge branch 'akpm' (patches from Andrew)	2020-06-04 19:18:29 -07:00
binfmt_script.c	Merge branch 'akpm' (patches from Andrew)	2020-06-04 19:18:29 -07:00
block_dev.c	block: add a bdget_part helper	2020-10-05 10:38:33 -06:00
buffer.c	mm, memcg: rework remote charging API to support nesting	2020-10-18 09:27:09 -07:00
char_dev.c
compat_binfmt_elf.c	Split the old READ_IMPLIES_EXEC workaround from executable PT_GNU_STACK	2020-06-05 13:45:21 -07:00
coredump.c	coredump: fix core_pattern parse error	2020-12-06 10:19:07 -08:00
d_path.c	fs: fix NULL dereference due to data race in prepend_path()	2020-10-14 14:54:45 -07:00
dax.c	fuse update for 5.10	2020-10-19 14:28:30 -07:00
dcache.c	vfs: Use sequence counter with associated spinlock	2020-07-29 16:14:27 +02:00
dcookies.c
direct-io.c	\n	2020-10-15 15:03:10 -07:00
drop_caches.c
eventfd.c
eventpoll.c	epoll: check for events when removing a timed out thread from the wait queue	2020-12-30 11:54:00 +01:00
exec.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:46:24 +01:00
fcntl.c	fcntl: Fix potential deadlock in send_sig{io, urg}()	2021-01-06 14:56:53 +01:00
fhandle.c
file_table.c	task_work: cleanup notification modes	2020-10-17 15:05:30 -06:00
file.c	io_uring: don't rely on weak ->files references	2020-09-30 20:32:32 -06:00
filesystems.c
fs_context.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
fs_parser.c	fs_parse: mark fs_param_bad_value() as static	2020-10-13 18:38:27 -07:00
fs_pin.c
fs_struct.c	vfs: Use sequence counter with associated spinlock	2020-07-29 16:14:27 +02:00
fs_types.c
fs-writeback.c	block-5.10-2020-10-12	2020-10-13 12:12:44 -07:00
fsopen.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
init.c	init: add an init_dup helper	2020-08-04 21:02:38 -04:00
inode.c	fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()	2020-12-30 11:53:49 +01:00
internal.h	fs: remove compat_sys_mount	2020-09-22 23:45:57 -04:00
io_uring.c	io_uring: Fix return value from alloc_fixed_file_ref_node	2021-01-17 14:16:53 +01:00
io-wq.c	io-wq: cancel request if it's asking for files and we don't have them	2020-11-04 10:22:56 -07:00
io-wq.h	io_uring: fix io_wqe->work_list corruption	2020-12-30 11:54:03 +01:00
ioctl.c	fs: remove ksys_ioctl	2020-07-31 08:16:01 +02:00
Kconfig	tmpfs: support 64-bit inums per-sb	2020-08-07 11:33:24 -07:00
Kconfig.binfmt	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
kernel_read_file.c	fs/kernel_file_read: Add "offset" arg for partial reads	2020-10-05 13:37:04 +02:00
libfs.c	libfs: fix error cast of negative value in simple_attr_write()	2020-11-22 10:48:22 -08:00
locks.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
Makefile	Refactored code for 5.10:	2020-10-23 11:33:41 -07:00
mbcache.c
mount.h
mpage.c	fs: convert mpage_readpages to mpage_readahead	2020-06-02 10:59:07 -07:00
namei.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
namespace.c	fs/namespace.c: WARN if mnt_count has become negative	2021-01-06 14:56:54 +01:00
no-block.c
nsfs.c
open.c	openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT	2020-12-30 11:54:24 +01:00
pipe.c	Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-11 11:11:35 -07:00
pnode.c
pnode.h	fs/namespace.c: WARN if mnt_count has become negative	2021-01-06 14:56:54 +01:00
posix_acl.c	vfs: clean up posix_acl_permission() logic aroudn MAY_NOT_BLOCK	2020-06-08 11:04:19 -07:00
proc_namespace.c	proc mountinfo: make splice available again	2020-12-30 11:54:02 +01:00
read_write.c	Refactored code for 5.10:	2020-10-23 11:33:41 -07:00
readdir.c	fs: remove ksys_getdents64	2020-07-31 08:16:00 +02:00
remap_range.c	vfs: move the remap range helpers to remap_range.c	2020-10-15 09:48:49 -07:00
select.c	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
seq_file.c	fix return values of seq_read_iter()	2020-11-15 22:12:53 -05:00
signalfd.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
splice.c	io_uring-5.10-2020-10-24	2020-10-24 12:40:18 -07:00
stack.c
stat.c	fs: remove KSTAT_QUERY_FLAGS	2020-09-26 22:55:05 -04:00
statfs.c	Add a "nosymfollow" mount option.	2020-08-27 16:06:47 -04:00
super.c	vfs: move __sb_{start,end}_write* to fs.h	2020-11-10 16:53:11 -08:00
sync.c	overlayfs update for 5.8	2020-06-09 15:40:50 -07:00
timerfd.c
userfaultfd.c	mm: remove the now-unnecessary mmget_still_valid() hack	2020-10-16 11:11:22 -07:00
utimes.c	fs: expose utimes_common	2020-07-31 08:16:01 +02:00
xattr.c	fs/xattr.c: fix kernel-doc warnings for setxattr & removexattr	2020-10-13 18:38:27 -07:00