linux/drivers/iio/humidity
Jonathan Cameron 30bdaafb64 iio:humidity:hts221 Fix alignment and data leak issues
commit 5c49056ad9 upstream.

One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes).  This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here.  We close both issues by
moving to a suitable structure in the iio_priv() data.
This data is allocated with kzalloc so no data can leak
apart from previous readings.

Explicit alignment of ts needed to ensure consistent padding
on all architectures (particularly x86_32 with it's 4 byte alignment
of s64)

Fixes: e4a70e3e7d ("iio: humidity: add support to hts221 rh/temp combo device")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-07-22 09:32:02 +02:00
..
am2315.c iio:humidity: drop assign iio_info.driver_module and iio_trigger_ops.owner 2017-08-22 21:30:20 +01:00
dht11.c iio: dht11: Improve detection of sensor type 2018-02-17 12:03:16 +00:00
hdc100x.c iio:humidity:hdc100x Fix alignment and data leak issues 2020-07-22 09:32:02 +02:00
hid-sensor-humidity.c iio/hid-sensors: Fix IIO_CHAN_INFO_RAW returning wrong values for signed numbers 2018-12-05 19:32:13 +01:00
hts221_buffer.c iio:humidity:hts221 Fix alignment and data leak issues 2020-07-22 09:32:02 +02:00
hts221_core.c iio: humidity: hts221: remove unnecessary get_unaligned_le16() 2018-01-30 18:33:19 +00:00
hts221_i2c.c iio: humidity: hts221: add regmap API support 2018-01-30 18:33:18 +00:00
hts221_spi.c iio: humidity: hts221: add regmap API support 2018-01-30 18:33:18 +00:00
hts221.h iio:humidity:hts221 Fix alignment and data leak issues 2020-07-22 09:32:02 +02:00
htu21.c iio:humidity: drop assign iio_info.driver_module and iio_trigger_ops.owner 2017-08-22 21:30:20 +01:00
Kconfig iio: humidity: hts221: add regmap API support 2018-01-30 18:33:18 +00:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
si7005.c iio:humidity: drop assign iio_info.driver_module and iio_trigger_ops.owner 2017-08-22 21:30:20 +01:00
si7020.c iio:humidity: drop assign iio_info.driver_module and iio_trigger_ops.owner 2017-08-22 21:30:20 +01:00