Baolin Wang 1e0f216195 usb: gadget: f_fs: Fix possibe deadlock ... commit b3ce3ce02d upstream. When system try to close /dev/usb-ffs/adb/ep0 on one core, at the same time another core try to attach new UDC, which will cause deadlock as below scenario. Thus we should release ffs lock before issuing unregister_gadget_item(). [ 52.642225] c1 ====================================================== [ 52.642228] c1 [ INFO: possible circular locking dependency detected ] [ 52.642236] c1 4.4.6+ #1 Tainted: G W O [ 52.642241] c1 ------------------------------------------------------- [ 52.642245] c1 usb ffs open/2808 is trying to acquire lock: [ 52.642270] c0 (udc_lock){+.+.+.}, at: [<ffffffc00065aeec>] usb_gadget_unregister_driver+0x3c/0xc8 [ 52.642272] c1 but task is already holding lock: [ 52.642283] c0 (ffs_lock){+.+.+.}, at: [<ffffffc00066b244>] ffs_data_clear+0x30/0x140 [ 52.642285] c1 which lock already depends on the new lock. [ 52.642287] c1 the existing dependency chain (in reverse order) is: [ 52.642295] c0 -> #1 (ffs_lock){+.+.+.}: [ 52.642307] c0 [<ffffffc00012340c>] __lock_acquire+0x20f0/0x2238 [ 52.642314] c0 [<ffffffc000123b54>] lock_acquire+0xe4/0x298 [ 52.642322] c0 [<ffffffc000aaf6e8>] mutex_lock_nested+0x7c/0x3cc [ 52.642328] c0 [<ffffffc00066f7bc>] ffs_func_bind+0x504/0x6e8 [ 52.642334] c0 [<ffffffc000654004>] usb_add_function+0x84/0x184 [ 52.642340] c0 [<ffffffc000658ca4>] configfs_composite_bind+0x264/0x39c [ 52.642346] c0 [<ffffffc00065b348>] udc_bind_to_driver+0x58/0x11c [ 52.642352] c0 [<ffffffc00065b49c>] usb_udc_attach_driver+0x90/0xc8 [ 52.642358] c0 [<ffffffc0006598e0>] gadget_dev_desc_UDC_store+0xd4/0x128 [ 52.642369] c0 [<ffffffc0002c14e8>] configfs_write_file+0xd0/0x13c [ 52.642376] c0 [<ffffffc00023c054>] vfs_write+0xb8/0x214 [ 52.642381] c0 [<ffffffc00023cad4>] SyS_write+0x54/0xb0 [ 52.642388] c0 [<ffffffc000085ff0>] el0_svc_naked+0x24/0x28 [ 52.642395] c0 -> #0 (udc_lock){+.+.+.}: [ 52.642401] c0 [<ffffffc00011e3d0>] print_circular_bug+0x84/0x2e4 [ 52.642407] c0 [<ffffffc000123454>] __lock_acquire+0x2138/0x2238 [ 52.642412] c0 [<ffffffc000123b54>] lock_acquire+0xe4/0x298 [ 52.642420] c0 [<ffffffc000aaf6e8>] mutex_lock_nested+0x7c/0x3cc [ 52.642427] c0 [<ffffffc00065aeec>] usb_gadget_unregister_driver+0x3c/0xc8 [ 52.642432] c0 [<ffffffc00065995c>] unregister_gadget_item+0x28/0x44 [ 52.642439] c0 [<ffffffc00066b34c>] ffs_data_clear+0x138/0x140 [ 52.642444] c0 [<ffffffc00066b374>] ffs_data_reset+0x20/0x6c [ 52.642450] c0 [<ffffffc00066efd0>] ffs_data_closed+0xac/0x12c [ 52.642454] c0 [<ffffffc00066f070>] ffs_ep0_release+0x20/0x2c [ 52.642460] c0 [<ffffffc00023dbe4>] __fput+0xb0/0x1f4 [ 52.642466] c0 [<ffffffc00023dd9c>] ____fput+0x20/0x2c [ 52.642473] c0 [<ffffffc0000ee944>] task_work_run+0xb4/0xe8 [ 52.642482] c0 [<ffffffc0000cd45c>] do_exit+0x360/0xb9c [ 52.642487] c0 [<ffffffc0000cf228>] do_group_exit+0x4c/0xb0 [ 52.642494] c0 [<ffffffc0000dd3c8>] get_signal+0x380/0x89c [ 52.642501] c0 [<ffffffc00008a8f0>] do_signal+0x154/0x518 [ 52.642507] c0 [<ffffffc00008af00>] do_notify_resume+0x70/0x78 [ 52.642512] c0 [<ffffffc000085ee8>] work_pending+0x1c/0x20 [ 52.642514] c1 other info that might help us debug this: [ 52.642517] c1 Possible unsafe locking scenario: [ 52.642518] c1 CPU0 CPU1 [ 52.642520] c1 ---- ---- [ 52.642525] c0 lock(ffs_lock); [ 52.642529] c0 lock(udc_lock); [ 52.642533] c0 lock(ffs_lock); [ 52.642537] c0 lock(udc_lock); [ 52.642539] c1 *** DEADLOCK *** [ 52.642543] c1 1 lock held by usb ffs open/2808: [ 52.642555] c0 #0: (ffs_lock){+.+.+.}, at: [<ffffffc00066b244>] ffs_data_clear+0x30/0x140 [ 52.642557] c1 stack backtrace: [ 52.642563] c1 CPU: 1 PID: 2808 Comm: usb ffs open Tainted: G [ 52.642565] c1 Hardware name: Spreadtrum SP9860g Board (DT) [ 52.642568] c1 Call trace: [ 52.642573] c1 [<ffffffc00008b430>] dump_backtrace+0x0/0x170 [ 52.642577] c1 [<ffffffc00008b5c0>] show_stack+0x20/0x28 [ 52.642583] c1 [<ffffffc000422694>] dump_stack+0xa8/0xe0 [ 52.642587] c1 [<ffffffc00011e548>] print_circular_bug+0x1fc/0x2e4 [ 52.642591] c1 [<ffffffc000123454>] __lock_acquire+0x2138/0x2238 [ 52.642595] c1 [<ffffffc000123b54>] lock_acquire+0xe4/0x298 [ 52.642599] c1 [<ffffffc000aaf6e8>] mutex_lock_nested+0x7c/0x3cc [ 52.642604] c1 [<ffffffc00065aeec>] usb_gadget_unregister_driver+0x3c/0xc8 [ 52.642608] c1 [<ffffffc00065995c>] unregister_gadget_item+0x28/0x44 [ 52.642613] c1 [<ffffffc00066b34c>] ffs_data_clear+0x138/0x140 [ 52.642618] c1 [<ffffffc00066b374>] ffs_data_reset+0x20/0x6c [ 52.642621] c1 [<ffffffc00066efd0>] ffs_data_closed+0xac/0x12c [ 52.642625] c1 [<ffffffc00066f070>] ffs_ep0_release+0x20/0x2c [ 52.642629] c1 [<ffffffc00023dbe4>] __fput+0xb0/0x1f4 [ 52.642633] c1 [<ffffffc00023dd9c>] ____fput+0x20/0x2c [ 52.642636] c1 [<ffffffc0000ee944>] task_work_run+0xb4/0xe8 [ 52.642640] c1 [<ffffffc0000cd45c>] do_exit+0x360/0xb9c [ 52.642644] c1 [<ffffffc0000cf228>] do_group_exit+0x4c/0xb0 [ 52.642647] c1 [<ffffffc0000dd3c8>] get_signal+0x380/0x89c [ 52.642651] c1 [<ffffffc00008a8f0>] do_signal+0x154/0x518 [ 52.642656] c1 [<ffffffc00008af00>] do_notify_resume+0x70/0x78 [ 52.642659] c1 [<ffffffc000085ee8>] work_pending+0x1c/0x20 Acked-by: Michal Nazarewicz <mina86@mina86.com> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> Cc: Jerry Zhang <zhangjerry@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-07-05 14:37:16 +02:00
..
accessibility
acpi	ACPI / power: Avoid maybe-uninitialized warning	2017-04-27 09:09:33 +02:00
amba
android	ANDROID: binder: Clear binder and cookie when setting handle in flat binder struct	2016-11-10 16:36:33 +01:00
ata	libata: apply MAX_SEC_1024 to all CX1-JB*-HP devices	2017-02-09 08:02:45 +01:00
atm
auxdisplay
base	PM / runtime: Avoid false-positive warnings from might_sleep_if()	2017-06-17 06:39:36 +02:00
bcma	bcma: use (get|put)_device when probing/removing device driver	2017-03-12 06:37:30 +01:00
block	drbd: avoid redefinition of BITS_PER_PAGE	2017-05-08 07:46:01 +02:00
bluetooth	Bluetooth: hci_intel: add missing tty-device sanity check	2017-05-20 14:27:02 +02:00
bus	bus: vexpress-config: fix device reference leak	2017-01-19 20:17:22 +01:00
cdrom
char	drivers: char: mem: Fix wraparound check to allow mappings up to the end	2017-06-14 13:16:26 +02:00
clk	clk: Make x86/ conditional on CONFIG_COMMON_CLK	2017-05-14 13:32:55 +02:00
clocksource	clocksource/exynos_mct: Clear interrupt when cpu is shut down	2017-01-26 08:23:48 +01:00
connector
cpufreq	cpufreq: conservative: Allow down_threshold to take values from 1 to 10	2017-06-26 07:13:08 +02:00
cpuidle	ARM: cpuidle: Fix error return code	2016-10-16 17:36:15 +02:00
crypto	crypto: caam - fix RNG deinstantiation error checking	2017-04-18 07:14:36 +02:00
dca
devfreq
dio
dma	dmaengine: ep93xx: Always start from BASE0	2017-06-14 13:16:22 +02:00
dma-buf
edac	EDAC: Increment correct counter in edac_inc_ue_error()	2016-09-07 08:32:41 +02:00
eisa
extcon	extcon: max77843: Use correct size for reading the interrupt register	2016-05-04 14:48:54 -07:00
firewire	firewire: net: fix fragmented datagram_size off-by-one	2016-11-10 16:36:35 +01:00
firmware	efi: Expose non-blocking set_variable() wrapper to efivars	2016-05-04 14:48:49 -07:00
fmc
fpga
gpio	gpio: mpc8xxx: Correct irq handler function	2016-10-28 03:01:25 -04:00
gpu	drm/vmwgfx: Free hash table allocated by cmdbuf managed res mgr	2017-07-05 14:37:16 +02:00
hid	HID: Add quirk for Dell PIXART OEM mouse	2017-06-29 12:48:51 +02:00
hsi
hv	hv: don't reset hv_context.tsc_page on crash	2017-04-27 09:09:34 +02:00
hwmon	hwmon: (g762) Fix overflows and crash seen when writing limit attributes	2017-01-12 11:22:48 +01:00
hwspinlock
hwtracing	intel_th: Fix a deadlock in modprobing	2016-08-10 11:49:30 +02:00
i2c	i2c: piix4: Fix request_region size	2017-06-17 06:39:36 +02:00
ide
idle	intel_idle: Support for Intel Xeon Phi Processor x200 Product Family	2016-09-15 08:27:46 +02:00
iio	iio: proximity: as3935: recalibrate RCO after resume	2017-06-26 07:13:09 +02:00
infiniband	RDMA/qib,hfi1: Fix MR reference count leak on write with immediate	2017-06-14 13:16:27 +02:00
input	Input: i8042 - add Fujitsu Lifebook AH544 to notimeout list	2017-06-29 12:48:51 +02:00
iommu	iommu/vt-d: Flush the IOTLB to get rid of the initial kdump mappings	2017-05-25 14:30:16 +02:00
ipack
irqchip	xtensa: don't use linux IRQ #0	2017-06-17 06:39:38 +02:00
isdn	isdn/gigaset: fix NULL-deref at probe	2017-03-26 12:13:19 +02:00
leds	leds: ktd2692: avoid harmless maybe-uninitialized warning	2017-05-14 13:32:55 +02:00
lguest
lightnvm	lightnvm: put bio before return	2016-09-24 10:07:35 +02:00
macintosh
mailbox
mcb	mcb: Fixed bar number assignment for the gdd	2016-06-01 12:15:53 -07:00
md	md: update slab_cache before releasing new stripes when stripes resizing	2017-05-25 14:30:08 +02:00
media	pvrusb2: reduce stack usage pvr2_eeprom_analyze()	2017-06-26 07:13:09 +02:00
memory	memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing	2016-07-27 09:47:35 -07:00
memstick	memstick: rtsx_usb_ms: Manage runtime PM when accessing the device	2016-10-28 03:01:35 -04:00
message
mfd	mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode	2017-06-26 07:13:09 +02:00
misc	drivers/misc/c2port/c2port-duramar2150.c: checking for NULL instead of IS_ERR()	2017-06-26 07:13:10 +02:00
mmc	mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read	2017-06-07 12:06:00 +02:00
mtd	mtd: spi-nor: fix spansion quad enable	2017-06-29 12:48:52 +02:00
net	sfc: provide dummy definitions of vswitch functions	2017-07-05 14:37:14 +02:00
nfc	mei: bus: fix received data size check in NFC fixup	2016-11-18 10:48:36 +01:00
ntb	ntb_transport: Pick an unused queue	2017-02-23 17:43:10 +01:00
nubus
nvdimm	libnvdimm: fix reconfig_mutex, mmap_sem, and jbd2_handle lockdep splat	2017-04-21 09:30:06 +02:00
nvme	nvme: apply DELAY_BEFORE_CHK_RDY quirk at probe time too	2017-06-29 12:48:53 +02:00
nvmem	nvmem: mxs-ocotp: fix buffer overflow in read	2016-05-11 11:21:21 +02:00
of	of: Add check to of_scan_flat_dt() before accessing initial_boot_params	2017-06-29 12:48:52 +02:00
oprofile
parisc
parport	parisc, parport_gsc: Fixes for printk continuation lines	2017-06-17 06:39:37 +02:00
pci	PCI: Freeze PME scan before suspending devices	2017-05-25 14:30:17 +02:00
pcmcia	pcmcia: db1xxx_ss: fix last irq_to_gpio user	2016-04-20 15:42:09 +09:00
perf	drivers/perf: arm_pmu: Fix leak in error path	2016-10-07 15:23:41 +02:00
phy	phy: qcom-usb-hs: Add depends on EXTCON	2017-05-14 13:32:57 +02:00
pinctrl	pinctrl: berlin-bg4ct: fix the value for "sd1a" of pin SCRD0_CRD_PRES	2017-06-17 06:39:37 +02:00
platform	platform/x86: acer-wmi: setup accelerometer when machine has appropriate notify event	2017-04-21 09:30:07 +02:00
pnp	PNP: Add Broadwell to Intel MCH size workaround	2016-08-16 09:30:48 +02:00
power	power: supply: bq24190_charger: Handle fault before status on interrupt	2017-05-14 13:32:54 +02:00
powercap
pps	pps: do not crash when failed to register	2016-08-10 11:49:25 +02:00
ps3
ptp
pwm	pwm: pca9685: Fix period change with same duty cycle	2017-03-15 09:57:14 +08:00
rapidio
ras
regulator	regulator: tps65023: Fix inverted core enable logic.	2017-05-25 14:30:09 +02:00
remoteproc	remoteproc: Fix potential race condition in rproc_add	2016-08-20 18:09:20 +02:00
reset
rpmsg
rtc	rtc: tegra: Implement clock handling	2017-04-21 09:30:07 +02:00
s390	s390/qeth: avoid null pointer dereference on OSN	2017-06-07 12:05:57 +02:00
sbus
scsi	scsi: qla2xxx: don't disable a not previously enabled PCI device	2017-06-14 13:16:25 +02:00
sfi
sh
sn
soc	soc: qcom/spm: shut up uninitialized variable warning	2016-09-24 10:07:42 +02:00
spi	spi: mvebu: fix baudrate calculation for armada variant	2017-01-15 13:41:36 +01:00
spmi
ssb	ssb: Fix error routine when fallback SPROM fails	2017-01-09 08:07:42 +01:00
staging	staging: rtl8188eu: prevent an underflow in rtw_check_beacon_data()	2017-06-26 07:13:09 +02:00
target	iscsi-target: Reject immediate data underflow larger than SCSI transfer length	2017-06-29 12:48:52 +02:00
tc
thermal	thermal: hwmon: Properly report critical temperature in sysfs	2017-01-09 08:07:44 +01:00
thunderbolt	thunderbolt: Fix double free of drom buffer	2016-06-01 12:15:53 -07:00
tty	serial: efm32: Fix parity management in 'efm32_uart_console_get_options()'	2017-06-26 07:13:09 +02:00
uio	uio: fix dmem_region_start computation	2016-10-31 04:13:59 -06:00
usb	usb: gadget: f_fs: Fix possibe deadlock	2017-07-05 14:37:16 +02:00
uwb	uwb: fix device quirk on big-endian hosts	2017-05-25 14:30:17 +02:00
vfio	vfio/type1: Remove locked page accounting workqueue	2017-05-20 14:27:00 +02:00
vhost	vhost/scsi: fix reuse of &vq->iov[out] in response	2016-09-15 08:27:53 +02:00
video	xen, fbfront: fix connecting to backend	2017-04-21 09:30:06 +02:00
virt
virtio	virtio_balloon: init 1st buffer in stats vq	2017-03-31 09:49:53 +02:00
vlynq
vme	vme: Fix wrong pointer utilization in ca91cx42_slave_get	2017-01-19 20:17:21 +01:00
w1	w1: ds2490: USB transfer buffers need to be DMAable	2017-03-12 06:37:29 +01:00
watchdog	watchdog: pcwd_usb: fix NULL-deref at probe	2017-05-25 14:30:07 +02:00
xen	xen/privcmd: Support correctly 64KB page granularity when mapping memory	2017-06-14 13:16:22 +02:00
zorro
Kconfig
Makefile	usb: Make sure usb/phy/of gets built-in	2017-05-20 14:26:59 +02:00