linux/lib/crypto
Jason A. Donenfeld cdae15d806 UPSTREAM: crypto: arm64/chacha - correctly walk through blocks
Prior, passing in chunks of 2, 3, or 4, followed by any additional
chunks would result in the chacha state counter getting out of sync,
resulting in incorrect encryption/decryption, which is a pretty nasty
crypto vuln: "why do images look weird on webpages?" WireGuard users
never experienced this prior, because we have always, out of tree, used
a different crypto library, until the recent Frankenzinc addition. This
commit fixes the issue by advancing the pointers and state counter by
the actual size processed. It also fixes up a bug in the (optional,
costly) stride test that prevented it from running on arm64.

Fixes: b3aad5bad2 ("crypto: arm64/chacha - expose arm64 ChaCha routine as library function")
Reported-and-tested-by: Emil Renner Berthing <kernel@esmil.dk>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: stable@vger.kernel.org # v5.5+
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
(cherry picked from commit c8cfcb78c6)
Bug: 152722841
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Change-Id: I18d11d178019741643e8d6839af8b9c42f66e237
2020-10-25 11:48:02 +01:00
..
blake2s-generic.c UPSTREAM: crypto: blake2s - generic C library implementation and selftest 2020-10-24 22:42:43 +02:00
blake2s-selftest.c UPSTREAM: crypto: blake2s - generic C library implementation and selftest 2020-10-24 22:42:43 +02:00
blake2s.c UPSTREAM: crypto: blake2s - generic C library implementation and selftest 2020-10-24 22:42:43 +02:00
chacha.c UPSTREAM: crypto: chacha - move existing library code into lib/crypto 2020-10-24 14:43:29 +02:00
chacha20poly1305-selftest.c UPSTREAM: crypto: arm64/chacha - correctly walk through blocks 2020-10-25 11:48:02 +01:00
chacha20poly1305.c UPSTREAM: crypto: chacha20poly1305 - prevent integer overflow on large input 2020-10-25 11:48:01 +01:00
curve25519-fiat32.c UPSTREAM: crypto: lib/curve25519 - work around Clang stack spilling issue 2020-10-24 22:42:43 +02:00
curve25519-generic.c UPSTREAM: crypto: curve25519 - Fix selftest build error 2020-10-25 11:47:57 +01:00
curve25519-hacl64.c UPSTREAM: crypto: curve25519 - generic C library implementations 2020-10-24 22:42:43 +02:00
curve25519-selftest.c UPSTREAM: crypto: lib/curve25519 - re-add selftests 2020-10-25 11:47:53 +01:00
curve25519.c UPSTREAM: crypto: curve25519 - Fix selftest build error 2020-10-25 11:47:57 +01:00
Kconfig UPSTREAM: crypto: x86/poly1305 - wire up faster implementations for kernel 2020-10-25 11:47:55 +01:00
libchacha.c UPSTREAM: crypto: chacha - move existing library code into lib/crypto 2020-10-24 14:43:29 +02:00
Makefile UPSTREAM: crypto: curve25519 - Fix selftest build error 2020-10-25 11:47:57 +01:00
poly1305-donna32.c UPSTREAM: crypto: poly1305 - add new 32 and 64-bit generic versions 2020-10-25 11:47:54 +01:00
poly1305-donna64.c UPSTREAM: crypto: poly1305 - add new 32 and 64-bit generic versions 2020-10-25 11:47:54 +01:00
poly1305.c UPSTREAM: crypto: poly1305 - add new 32 and 64-bit generic versions 2020-10-25 11:47:54 +01:00