linux/drivers/iio/light
Jonathan Cameron 8660424807 iio:light:st_uvis25: Fix timestamp alignment and prevent data leak.
commit d837a996f5 upstream.

One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp() assumes the buffer used is aligned
to the size of the timestamp (8 bytes).  This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here.  We close both issues by
moving to a suitable structure in the iio_priv()

This data is allocated with kzalloc() so no data can leak apart
from previous readings.

A local unsigned int variable is used for the regmap call so it
is clear there is no potential issue with writing into the padding
of the structure.

Fixes: 3025c8688c ("iio: light: add support for UVIS25 sensor")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: <Stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200920112742.170751-3-jic23@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-30 11:26:15 +01:00
..
acpi-als.c
adjd_s311.c
al3320a.c
apds9300.c
apds9960.c
bh1750.c
bh1780.c
cm3232.c
cm3323.c
cm3605.c
cm32181.c
cm36651.c
cros_ec_light_prox.c
gp2ap020a00f.c
hid-sensor-als.c
hid-sensor-prox.c
isl29018.c
isl29028.c
isl29125.c
jsa1212.c
Kconfig
lm3533-als.c
ltr501.c iio:light:ltr501 Fix timestamp alignment issue. 2020-09-17 13:45:27 +02:00
lv0104cs.c
Makefile
max44000.c iio:light:max44000 Fix timestamp alignment and prevent data leak. 2020-09-17 13:45:27 +02:00
opt3001.c
pa12203001.c
rpr0521.c iio:light:rpr0521: Fix timestamp alignment and prevent data leak. 2020-12-30 11:26:15 +01:00
si1133.c iio: si1133: read 24-bit signed integer for measurement 2020-04-23 10:30:23 +02:00
si1145.c iio:light:si1145: Fix timestamp alignment and prevent data leak. 2020-11-05 11:08:50 +01:00
st_uvis25_core.c iio:light:st_uvis25: Fix timestamp alignment and prevent data leak. 2020-12-30 11:26:15 +01:00
st_uvis25_i2c.c
st_uvis25_spi.c
st_uvis25.h iio:light:st_uvis25: Fix timestamp alignment and prevent data leak. 2020-12-30 11:26:15 +01:00
stk3310.c
tcs3414.c
tcs3472.c
tsl2563.c
tsl2583.c
tsl2772.c iio: tsl2772: Use devm_add_action_or_reset for tsl2772_chip_off 2020-01-27 14:51:03 +01:00
tsl4531.c
us5182d.c
vcnl4000.c iio: vcnl4000: Fix i2c swapped word reading. 2020-06-10 21:35:00 +02:00
veml6070.c
vl6180.c
zopt2201.c