github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-14 16:10:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph
cb45ede21d
linux/sound/soc
History
Uday Khare 3238c63472
ASoC: tas2562: fix deprecated 'shut-down' GPIO always cleared after lookup 
In tas2562_parse_dt(), the fallback lookup for the deprecated
"shut-down" GPIO property is broken due to a missing pair of braces.

The code intends to reset sdz_gpio to NULL only when the lookup
returns an error that is not -EPROBE_DEFER (so the driver gracefully
continues without a GPIO). However, without braces the statement:

    tas2562->sdz_gpio = NULL;

falls outside the IS_ERR() check and is executed unconditionally
for every path through the if block, including a successful GPIO
lookup.

This means any device using the deprecated 'shut-down' DT property
will always have sdz_gpio == NULL after probe, making the GPIO
completely non-functional.

Fix this by adding the missing braces to scope the NULL assignment
inside the IS_ERR() branch, matching the pattern already used for
the primary 'shutdown' GPIO lookup above.

Fixes: f78a97003b ("ASoC: tas2562: Update shutdown GPIO property")
Signed-off-by: Uday Khare <udaykhare77@gmail.com>
Link: https://patch.msgid.link/20260706153109.10953-1-udaykhare77@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2026-07-09 00:33:20 +01:00
..
adi
amd Vijendar Mukunda <Vijendar.Mukunda@amd.com> says: 2026-07-07 23:47:25 +01:00
apple ASoC: apple: mca: Use guard() for mutex locks 2026-04-27 06:52:25 +09:00
atmel Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
au1x ASoC: au1x: name back to pcm_new()/pcm_free() 2026-03-16 13:37:45 +00:00
bcm ASoC: bcm: cygnus: use scoped child node loop 2026-06-12 16:12:11 +01:00
cirrus ASoC: ep93xx: Fix unchecked clk_prepare_enable() and add rollback on failure 2026-03-30 19:38:22 +01:00
codecs ASoC: tas2562: fix deprecated 'shut-down' GPIO always cleared after lookup 2026-07-09 00:33:20 +01:00
dwc ASoC: dwc: name back to pcm_new()/pcm_free() 2026-03-16 13:37:49 +00:00
fsl Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
generic Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
google ASoC: google: name back to pcm_new()/pcm_free() 2026-03-16 13:37:52 +00:00
hisilicon ASoC: hisilicon: Use guard() for spin locks 2026-06-12 14:20:37 +01:00
img ASoC: img: img-spdif-out: Use guard() for spin locks 2026-06-11 20:43:32 +01:00
intel ASoC: sof_sdw: Add a quirk for 0x17aa383c laptop using sidecar amps with cs42l43 2026-07-06 14:25:30 +01:00
jz4740 Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
kirkwood ASoC: kirkwood: name back to pcm_new()/pcm_free() 2026-03-16 13:37:54 +00:00
loongson ASoC: Updates for v7.2 2026-06-15 20:19:22 +02:00
mediatek Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
meson ASoC: meson: aiu: fifo-spdif: soft reset the S/PDIF datapath on start/stop 2026-07-07 23:01:44 +01:00
mxs ASoC: mxs-sgtl5000: disable MCLK on error paths of mxs_sgtl5000_probe() 2026-04-01 14:01:25 +01:00
pxa ASoC: pxa: integrate sound/arm/pxa2xx into sound/soc/pxa2xx 2026-05-06 10:14:43 +09:00
qcom ASoC: qcom: sc8280xp: Add support for Eliza 2026-07-08 12:25:20 +01:00
renesas ASoC: rsnd: src: Add missing scu_supply clock to suspend/resume 2026-07-02 18:56:38 +01:00
rockchip ASoC: rockchip: rockchip_sai: #include <linux/platform_device.h> explicitly 2026-06-24 12:59:54 +01:00
samsung ASoC: samsung: spdif: Use guard() for spin locks 2026-04-27 08:28:19 +09:00
sdca Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
sdw_utils ASoC: sdw_utils: fix missing component_name for cs42l43 part_id 0x2A3B 2026-06-12 16:07:57 +01:00
sof sound fixes for 7.2-rc2 2026-07-05 05:26:45 -10:00
sophgo ASoC: sophgo: fix 64-bit division build failure 2026-02-02 12:09:35 +00:00
spacemit ASoC: spacemit: add K3 SoC support with additional clocks 2026-06-01 16:00:44 +01:00
spear ASoC: Add SPDX ids to many soc files 2026-02-22 23:52:20 +00:00
sprd ASoC: sprd: sprd-mcdt: Use guard() for mutex & spin locks 2026-06-08 19:02:59 +01:00
starfive ASoC: Add SPDX ids to many soc files 2026-02-22 23:52:20 +00:00
sti ASoC: sti: uniperif_player: Use guard() for mutex & spin locks 2026-06-01 16:47:07 +01:00
stm ASoC: stm: stm32_adfsdm: set debugfs_prefix via Component driver 2026-06-10 12:21:13 +01:00
sunxi Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
tegra Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
ti Replace <linux/mod_devicetable.h> by more specific <linux/device-id/*.h> (c files) 2026-07-03 07:38:17 +02:00
uniphier ASoC: uniphier: aio-dma: Use guard() for spin locks 2026-05-04 22:08:21 +09:00
ux500 ASoC: ux500: Use guard() for mutex locks 2026-05-04 22:02:21 +09:00
xilinx ASoC: xilinx: name back to pcm_new()/pcm_free() 2026-03-16 13:38:06 +00:00
xtensa ASoC: xtensa: name back to pcm_new()/pcm_free() 2026-03-16 13:38:07 +00:00
Kconfig
Makefile
soc-ac97.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
soc-acpi.c
soc-card-test.c
soc-card.c ASoC: soc-card: add snd_soc_card_set_topology_name() 2026-05-28 12:18:29 +01:00
soc-component.c ASoC: soc-component: add snd_soc_component_regmap_val_bytes() 2026-03-20 12:55:59 +00:00
soc-compress.c ASoC: soc-compress: use function to clear symmetric params 2026-02-22 23:52:21 +00:00
soc-core.c ASoC: soc-core: Don't fail if device_link could not be created 2026-06-24 13:01:38 +01:00
soc-dai.c ASoC: update auto format selection method 2026-06-12 18:57:58 +01:00
soc-dapm.c ASoC: soc-core: Add core support for ignoring suspend on selected DAPM widgets 2026-05-25 13:37:18 +01:00
soc-devres.c ASoC: core: Move all users to deferrable card binding 2026-05-11 10:06:10 +09:00
soc-generic-dmaengine-pcm.c ASoC: soc-generic-dmaengine: set debugfs_prefix via Component driver 2026-06-10 12:21:12 +01:00
soc-jack.c
soc-link.c
soc-ops-test.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
soc-ops.c ASoC: ops: Log unknown controls in snd_soc_limit_volume() 2026-04-27 06:51:59 +09:00
soc-pcm.c ASoC: soc-pcm: constrain hw_params when DAIs share the same BCLK 2026-05-25 11:42:43 +01:00
soc-topology-test.c
soc-topology.c ASoC: topology: Check PCM and DAI name strings before use 2026-06-11 20:47:42 +01:00
soc-usb.c Convert 'alloc_obj' family to use the new default GFP_KERNEL argument 2026-02-21 17:09:51 -08:00
soc-utils-test.c
soc-utils.c ASoC: remove SND_SOC_POSSIBLE_xBx_xFx 2026-06-12 18:57:52 +01:00