linux

mirror of https://github.com/torvalds/linux.git synced 2026-08-01 12:11:59 +02:00

Linux kernel source tree

Go to file

Xin Long c863850ce2 sctp: not free the new asoc when sctp_wait_for_connect returns err When sctp_wait_for_connect is called to wait for connect ready for sp->strm_interleave in sctp_sendmsg_to_asoc, a panic could be triggered if cpu is scheduled out and the new asoc is freed elsewhere, as it will return err and later the asoc gets freed again in sctp_sendmsg. [ 285.840764] list_del corruption, ffff9f0f7b284078->next is LIST_POISON1 (dead000000000100) [ 285.843590] WARNING: CPU: 1 PID: 8861 at lib/list_debug.c:47 __list_del_entry_valid+0x50/0xa0 [ 285.846193] Kernel panic - not syncing: panic_on_warn set ... [ 285.846193] [ 285.848206] CPU: 1 PID: 8861 Comm: sctp_ndata Kdump: loaded Not tainted 4.19.0-rc7.label #584 [ 285.850559] Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 [ 285.852164] Call Trace: ... [ 285.872210] ? __list_del_entry_valid+0x50/0xa0 [ 285.872894] sctp_association_free+0x42/0x2d0 [sctp] [ 285.873612] sctp_sendmsg+0x5a4/0x6b0 [sctp] [ 285.874236] sock_sendmsg+0x30/0x40 [ 285.874741] ___sys_sendmsg+0x27a/0x290 [ 285.875304] ? __switch_to_asm+0x34/0x70 [ 285.875872] ? __switch_to_asm+0x40/0x70 [ 285.876438] ? ptep_set_access_flags+0x2a/0x30 [ 285.877083] ? do_wp_page+0x151/0x540 [ 285.877614] __sys_sendmsg+0x58/0xa0 [ 285.878138] do_syscall_64+0x55/0x180 [ 285.878669] entry_SYSCALL_64_after_hwframe+0x44/0xa9 This is a similar issue with the one fixed in Commit `ca3af4dd28` ("sctp: do not free asoc when it is already dead in sctp_sendmsg"). But this one can't be fixed by returning -ESRCH for the dead asoc in sctp_wait_for_connect, as it will break sctp_connect's return value to users. This patch is to simply set err to -ESRCH before it returns to sctp_sendmsg when any err is returned by sctp_wait_for_connect for sp->strm_interleave, so that no asoc would be freed due to this. When users see this error, they will know the packet hasn't been sent. And it also makes sense to not free asoc because waiting connect fails, like the second call for sctp_wait_for_connect in sctp_sendmsg_to_asoc. Fixes: `668c9beb90` ("sctp: implement assign_number for sctp_stream_interleave") Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-10-17 22:12:46 -07:00
arch	ARM: SoC fixes for 4.19	2018-10-12 17:41:27 +02:00
block	blk-mq: I/O and timer unplugs are inverted in blktrace	2018-09-27 13:12:44 -06:00
certs	export.h: remove VMLINUX_SYMBOL() and VMLINUX_SYMBOL_STR()	2018-08-22 23:21:44 +09:00
crypto	DMAengine updates for v4.19-rc1	2018-08-18 15:55:59 -07:00
Documentation	Char/Misc fixes for 4.19-rc7	2018-10-07 08:15:57 +02:00
drivers	r8169: re-enable MSI-X on RTL8168g	2018-10-17 22:10:33 -07:00
firmware	kbuild: remove all dummy assignments to obj-	2017-11-18 11:46:06 +09:00
fs	afs: Fix afs_server struct leak	2018-10-12 17:36:40 +02:00
include	geneve, vxlan: Don't set exceptions if skb->len < mtu	2018-10-17 21:51:13 -07:00
init	Kbuild updates for v4.19 (2nd)	2018-08-25 13:40:38 -07:00
ipc	ipc/shm.c: use ERR_CAST() for shm_lock() error return	2018-10-05 16:32:04 -07:00
kernel	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2018-10-14 13:01:20 -07:00
lib	* Fix a stack overflow in lib/bch.c	2018-10-12 12:54:26 +02:00
LICENSES	LICENSES: Add Linux-OpenIB license text	2018-04-27 16:41:53 -06:00
mm	Merge branch 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-11 12:27:47 +02:00
net	sctp: not free the new asoc when sctp_wait_for_connect returns err	2018-10-17 22:12:46 -07:00
samples	samples: disable CONFIG_SAMPLES for UML	2018-10-11 02:15:46 +09:00
scripts	Kbuild fixes for v4.19 (2nd)	2018-10-11 19:23:07 +02:00
security	Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name"	2018-09-25 13:28:58 +02:00
sound	ALSA: hda/realtek - Cannot adjust speaker's volume on Dell XPS 27 7760	2018-10-04 07:50:48 +02:00
tools	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2018-10-14 13:01:20 -07:00
usr	initramfs: move gen_initramfs_list.sh from scripts/ to usr/	2018-08-22 23:21:44 +09:00
virt	KVM: Remove obsolete kvm_unmap_hva notifier backend	2018-09-07 15:06:02 +02:00
.clang-format	clang-format: Set IndentWrappedFunctionNames false	2018-08-01 18:38:51 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes	.gitattributes: set git diff driver for C source code files	2016-10-07 18:46:30 -07:00
.gitignore	Kbuild updates for v4.17 (2nd)	2018-04-15 17:21:30 -07:00
.mailmap	libnvdimm-for-4.19_misc	2018-08-25 18:13:10 -07:00
COPYING	COPYING: use the new text with points to the license files	2018-03-23 12:41:45 -06:00
CREDITS	9p: remove Ron Minnich from MAINTAINERS	2018-08-17 16:20:26 -07:00
Kbuild	Kbuild updates for v4.15	2017-11-17 17:45:29 -08:00
Kconfig	kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt	2018-08-02 08:06:55 +09:00
MAINTAINERS	MAINTAINERS: use the correct location for dt-bindings includes for mux	2018-10-12 17:36:39 +02:00
Makefile	Kbuild fixes for v4.19 (2nd)	2018-10-11 19:23:07 +02:00
README	Docs: Added a pointer to the formatted docs to README	2018-03-21 09:02:53 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
See Documentation/00-INDEX for a list of what is contained in each file.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.