Matt Bobrowski c80d797206 bpf/selftests: Fix test_tcpnotify_user ... Based on a bisect, it appears that commit 7ee9887703 ("timers: Implement the hierarchical pull model") has somehow inadvertently broken BPF selftest test_tcpnotify_user. The error that is being generated by this test is as follows: FAILED: Wrong stats Expected 10 calls, got 8 It looks like the change allows timer functions to be run on CPUs different from the one they are armed on. The test had pinned itself to CPU 0, and in the past the retransmit attempts also occurred on CPU 0. The test had set the max_entries attribute for BPF_MAP_TYPE_PERF_EVENT_ARRAY to 2 and was calling bpf_perf_event_output() with BPF_F_CURRENT_CPU, so the entry was likely to be in range. With the change to allow timers to run on other CPUs, the current CPU tasked with performing the retransmit might be bumped and in turn fall out of range, as the event will be filtered out via __bpf_perf_event_output() using: if (unlikely(index >= array->map.max_entries)) return -E2BIG; A possible change would be to explicitly set the max_entries attribute for perf_event_map in test_tcpnotify_kern.c to a value that's at least as large as the number of CPUs. As it turns out however, if the field is left unset, then the libbpf will determine the number of CPUs available on the underlying system and update the max_entries attribute accordingly in map_set_def_max_entries(). A further problem with the test is that it has a thread that continues running up until the program exits. The main thread cleans up some LIBBPF data structures, while the other thread continues to use them, which inevitably will trigger a SIGSEGV. This can be dealt with by telling the thread to run for as long as necessary and doing a pthread_join on it before exiting the program. Finally, I don't think binding the process to CPU 0 is meaningful for this test any more, so get rid of that. Fixes: 435f90a338 ("selftests/bpf: add a test case for sock_ops perf-event notification") Signed-off-by: Matt Bobrowski <mattbobrowski@google.com> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org> Acked-by: Stanislav Fomichev <sdf@fomichev.me> Link: https://patch.msgid.link/aJ8kHhwgATmA3rLf@google.com		2025-08-15 13:05:29 -07:00
..
accounting	tools/getdelays: add backward compatibility for taskstats version	2025-08-02 12:01:41 -07:00
arch	x86/rdrand: Disable RDSEED on AMD Cyan Skillfish	2025-07-08 21:33:26 +02:00
bootconfig	bootconfig: Fix unaligned access when building footer	2025-07-24 22:16:48 +09:00
bpf	bpftool: Add bash completion for token argument	2025-08-01 18:03:23 -07:00
build	tools: Remove libcrypto dependency	2025-06-26 10:51:41 -07:00
certs
cgroup	memcg_slabinfo: Fix use of PG_slab	2025-07-23 11:55:22 +02:00
counter
crypto
debugging
firewire
firmware
gpio
hv	tools/hv: fcopy: Fix irregularities with size of ring buffer	2025-07-15 06:25:33 +00:00
iio
include	ARM:	2025-07-30 17:14:01 -07:00
kvm/kvm_stat
laptop
leds
lib	libbpf: Add the ability to suppress perf event enablement	2025-08-07 09:01:41 -07:00
memory-model
mm	tools/mm: add script to display page state for a given PID and VADDR	2025-07-09 22:41:53 -07:00
net	tools: ynl-gen: print setters for multi-val attrs	2025-07-24 17:28:49 -07:00
objtool	Runtime verification changes for 6.17	2025-07-30 16:23:12 -07:00
pcmcia
perf	perf bpf-filter: Enable events manually	2025-08-07 09:03:44 -07:00
power	tools/power turbostat: version 2025.09.09	2025-08-10 09:02:36 +03:00
rcu
sched	tools/sched: Add dl_bw_dump.py for printing bandwidth accounting info	2025-07-14 10:59:33 +02:00
sched_ext	sched_ext: Add support for cgroup bandwidth control interface	2025-06-20 17:03:51 -10:00
scripts	tools/build: Fix s390(x) cross-compilation with clang	2025-07-08 09:19:23 +02:00
sound
spi
testing	bpf/selftests: Fix test_tcpnotify_user	2025-08-15 13:05:29 -07:00
thermal
time
tracing	rtla/tests: Test timerlat -P option using actions	2025-07-28 10:22:39 -04:00
usb
verification	rv: Add opid per-cpu monitor	2025-07-28 16:47:35 -04:00
virtio
wmi
workqueue
writeback
Makefile