Shuah Khan 7696248f9b selftests: Fix test errors related to lib.mk khdr target ... commit 211929fd3f upstream. Commit b2d35fa5fc ("selftests: add headers_install to lib.mk") added khdr target to run headers_install target from the main Makefile. The logic uses KSFT_KHDR_INSTALL and top_srcdir as controls to initialize variables and include files to run headers_install from the top level Makefile. There are a few problems with this logic. 1. Exposes top_srcdir to all tests 2. Common logic impacts all tests 3. Uses KSFT_KHDR_INSTALL, top_srcdir, and khdr in an adhoc way. Tests add "khdr" dependency in their Makefiles to TEST_PROGS_EXTENDED in some cases, and STATIC_LIBS in other cases. This makes this framework confusing to use. The common logic that runs for all tests even when KSFT_KHDR_INSTALL isn't defined by the test. top_srcdir is initialized to a default value when test doesn't initialize it. It works for all tests without a sub-dir structure and tests with sub-dir structure fail to build. e.g: make -C sparc64/drivers/ or make -C drivers/dma-buf ../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directory make: *** No rule to make target '../../../../scripts/subarch.include'. Stop. There is no reason to require all tests to define top_srcdir and there is no need to require tests to add khdr dependency using adhoc changes to TEST_* and other variables. Fix it with a consistent use of KSFT_KHDR_INSTALL and top_srcdir from tests that have the dependency on headers_install. Change common logic to include khdr target define and "all" target with dependency on khdr when KSFT_KHDR_INSTALL is defined. Only tests that have dependency on headers_install have to define just the KSFT_KHDR_INSTALL, and top_srcdir variables and there is no need to specify khdr dependency in the test Makefiles. Fixes: b2d35fa5fc ("selftests: add headers_install to lib.mk") Cc: stable@vger.kernel.org Signed-off-by: Shuah Khan <shuah@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-01-22 21:40:38 +01:00
..
accounting
arch	tools arch uapi: Sync the x86 kvm.h copy	2018-10-08 12:04:51 -03:00
bpf	tools: bpftool: fix potential NULL pointer dereference in do_load	2018-12-17 09:24:34 +01:00
build	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2018-08-15 15:04:25 -07:00
cgroup
firewire
gpio
hv	tools: hv: fcopy: set 'error' in case an unknown operation was requested	2018-09-30 08:49:55 -07:00
iio	iio: Add modifier for DUV light	2018-07-23 19:18:10 +01:00
include	x86/speculation: Add prctl() control for indirect branch speculation	2018-12-05 19:32:04 +01:00
kvm/kvm_stat	tools/kvm_stat: cut down decimal places in update interval dialog	2018-10-01 15:40:59 +02:00
laptop
leds
lib	tools lib traceevent: Fix processing of dereferenced args in bprintk events	2019-01-09 17:38:47 +01:00
memory-model	tools/memory-model: Rename litmus tests to comply to norm7	2018-07-17 09:30:36 +02:00
nfsd
objtool	objtool: Fix segfault in .cold detection with -ffunction-sections	2018-12-17 09:24:33 +01:00
pci	tools: PCI: Add MSI-X support	2018-07-19 11:47:13 +01:00
pcmcia
perf	perf env: Also consider env->arch == NULL as local operation	2019-01-09 17:38:43 +01:00
power	tools/power/cpupower: fix compilation with STATIC=true	2018-12-01 09:37:27 +01:00
scripts
spi
testing	selftests: Fix test errors related to lib.mk khdr target	2019-01-22 21:40:38 +01:00
thermal/tmon
time
usb	tools: usb: ffs-test: Fix build on big endian systems	2018-07-17 10:12:51 +03:00
virtio	virtio: fix test build after uio.h change	2019-01-13 09:51:03 +01:00
vm	tools/vm/page-types.c: fix "defined but not used" warning	2018-09-04 16:45:02 -07:00
wmi
Makefile