Ye Bin 9f4bd00a6e PM: hibernate: Get block device exclusively in swsusp_check() ... [ Upstream commit 39fbef4b0f ] The following kernel crash can be triggered: [ 89.266592] ------------[ cut here ]------------ [ 89.267427] kernel BUG at fs/buffer.c:3020! [ 89.268264] invalid opcode: 0000 [#1] SMP KASAN PTI [ 89.269116] CPU: 7 PID: 1750 Comm: kmmpd-loop0 Not tainted 5.10.0-862.14.0.6.x86_64-08610-gc932cda3cef4-dirty #20 [ 89.273169] RIP: 0010:submit_bh_wbc.isra.0+0x538/0x6d0 [ 89.277157] RSP: 0018:ffff888105ddfd08 EFLAGS: 00010246 [ 89.278093] RAX: 0000000000000005 RBX: ffff888124231498 RCX: ffffffffb2772612 [ 89.279332] RDX: 1ffff11024846293 RSI: 0000000000000008 RDI: ffff888124231498 [ 89.280591] RBP: ffff8881248cc000 R08: 0000000000000001 R09: ffffed1024846294 [ 89.281851] R10: ffff88812423149f R11: ffffed1024846293 R12: 0000000000003800 [ 89.283095] R13: 0000000000000001 R14: 0000000000000000 R15: ffff8881161f7000 [ 89.284342] FS: 0000000000000000(0000) GS:ffff88839b5c0000(0000) knlGS:0000000000000000 [ 89.285711] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 89.286701] CR2: 00007f166ebc01a0 CR3: 0000000435c0e000 CR4: 00000000000006e0 [ 89.287919] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 89.289138] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 89.290368] Call Trace: [ 89.290842] write_mmp_block+0x2ca/0x510 [ 89.292218] kmmpd+0x433/0x9a0 [ 89.294902] kthread+0x2dd/0x3e0 [ 89.296268] ret_from_fork+0x22/0x30 [ 89.296906] Modules linked in: by running the following commands: 1. mkfs.ext4 -O mmp /dev/sda -b 1024 2. mount /dev/sda /home/test 3. echo "/dev/sda" > /sys/power/resume That happens because swsusp_check() calls set_blocksize() on the target partition which confuses the file system: Thread1 Thread2 mount /dev/sda /home/test get s_mmp_bh --> has mapped flag start kmmpd thread echo "/dev/sda" > /sys/power/resume resume_store software_resume swsusp_check set_blocksize truncate_inode_pages_range truncate_cleanup_page block_invalidatepage discard_buffer --> clean mapped flag write_mmp_block submit_bh submit_bh_wbc BUG_ON(!buffer_mapped(bh)) To address this issue, modify swsusp_check() to open the target block device with exclusive access. Signed-off-by: Ye Bin <yebin10@huawei.com> [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-11-18 14:03:59 +01:00
..
bpf	bpf: Prevent increasing bpf_jit_limit above max	2021-11-18 14:03:42 +01:00
cgroup	cgroup: Fix memory leak caused by missing cgroup_bpf_offline	2021-11-02 19:48:21 +01:00
configs
debug
dma	dma-debug: fix sg checks in debug_dma_map_sg()	2021-10-27 09:56:47 +02:00
entry	KVM: rseq: Update rseq when processing NOTIFY_RESUME on xfer to KVM guest	2021-10-06 15:55:49 +02:00
events	perf/core: fix userpage->time_enabled of inactive events	2021-10-17 10:43:33 +02:00
gcov
irq
kcsan
livepatch
locking	locking/lockdep: Avoid RCU-induced noinstr fail	2021-11-18 14:03:53 +01:00
power	PM: hibernate: Get block device exclusively in swsusp_check()	2021-11-18 14:03:59 +01:00
printk	printk/console: Allow to disable console output by using console="" or console=null	2021-11-12 14:58:33 +01:00
rcu	rcu-tasks: Move RTGS_WAIT_CBS to beginning of rcu_tasks_kthread() loop	2021-11-18 14:03:53 +01:00
sched	sched/scs: Reset the shadow stack when idle_task_exit	2021-10-27 09:56:55 +02:00
time
trace	tracing/cfi: Fix cmp_entries_* functions signature mismatch	2021-11-18 14:03:58 +01:00
.gitignore
acct.c
async.c
audit_fsnotify.c
audit_tree.c
audit_watch.c
audit.c
audit.h
auditfilter.c
auditsc.c	audit: fix possible null-pointer dereference in audit_filter_rules	2021-10-27 09:56:52 +02:00
backtracetest.c
bounds.c
capability.c
compat.c
configs.c
context_tracking.c
cpu_pm.c
cpu.c
crash_core.c
crash_dump.c
cred.c
delayacct.c
dma.c
exec_domain.c
exit.c
extable.c
fail_function.c
fork.c
freezer.c
futex.c
gen_kheaders.sh
groups.c
hung_task.c
iomem.c
irq_work.c
jump_label.c
kallsyms.c
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c
kexec_core.c
kexec_elf.c
kexec_file.c
kexec_internal.h
kexec.c
kheaders.c
kmod.c
kprobes.c
ksysfs.c
kthread.c
latencytop.c
Makefile
module_signature.c
module_signing.c
module-internal.h
module.c
notifier.c
nsproxy.c
padata.c
panic.c
params.c
pid_namespace.c
pid.c
profile.c	profiling: fix shift-out-of-bounds bugs	2021-09-26 14:08:58 +02:00
ptrace.c
range.c
reboot.c
regset.c
relay.c
resource.c
rseq.c	KVM: rseq: Update rseq when processing NOTIFY_RESUME on xfer to KVM guest	2021-10-06 15:55:49 +02:00
scftorture.c
scs.c
seccomp.c
signal.c	signal: Remove the bogus sigkill_pending in ptrace_stop	2021-11-18 14:03:47 +01:00
smp.c
smpboot.c
smpboot.h
softirq.c
stackleak.c
stacktrace.c
static_call.c
stop_machine.c
sys_ni.c
sys.c	prctl: allow to setup brk for et_dyn executables	2021-09-26 14:08:57 +02:00
sysctl-test.c
sysctl.c
task_work.c
taskstats.c
test_kprobes.c
torture.c
tracepoint.c
tsacct.c
ucount.c
uid16.c
uid16.h
umh.c
up.c
user_namespace.c
user-return-notifier.c
user.c
usermode_driver.c
utsname_sysctl.c
utsname.c
watch_queue.c
watchdog_hld.c
watchdog.c
workqueue_internal.h
workqueue.c	workqueue: make sysfs of unbound kworker cpumask more clever	2021-11-18 14:03:58 +01:00